* + mm-vmalloc-convert-vread-to-vread_iter-fix.patch added to mm-unstable branch
@ 2023-03-20 21:25 Andrew Morton
0 siblings, 0 replies; 4+ messages in thread
From: Andrew Morton @ 2023-03-20 21:25 UTC (permalink / raw)
To: mm-commits, lstoakes, sfr, akpm
The patch titled
Subject: mm: vmalloc: fix sparc64 warning
has been added to the -mm mm-unstable branch. Its filename is
mm-vmalloc-convert-vread-to-vread_iter-fix.patch
This patch will shortly appear at
https://git.kernel.org/pub/scm/linux/kernel/git/akpm/25-new.git/tree/patches/mm-vmalloc-convert-vread-to-vread_iter-fix.patch
This patch will later appear in the mm-unstable branch at
git://git.kernel.org/pub/scm/linux/kernel/git/akpm/mm
Before you just go and hit "reply", please:
a) Consider who else should be cc'ed
b) Prefer to cc a suitable mailing list as well
c) Ideally: find the original patch on the mailing list and do a
reply-to-all to that, adding suitable additional cc's
*** Remember to use Documentation/process/submit-checklist.rst when testing your code ***
The -mm tree is included into linux-next via the mm-everything
branch at git://git.kernel.org/pub/scm/linux/kernel/git/akpm/mm
and is updated there every 2-3 working days
------------------------------------------------------
From: Stephen Rothwell <sfr@canb.auug.org.au>
Subject: mm: vmalloc: fix sparc64 warning
This fixes this warning from a sparc64 defconfig build:
In file included from /home/sfr/next/next/include/linux/wait.h:11,
from /home/sfr/next/next/include/linux/swait.h:8,
from /home/sfr/next/next/include/linux/completion.h:12,
from /home/sfr/next/next/include/linux/mm_types.h:14,
from /home/sfr/next/next/include/linux/uio.h:10,
from /home/sfr/next/next/include/linux/vmalloc.h:12,
from /home/sfr/next/next/include/asm-generic/io.h:994,
from /home/sfr/next/next/arch/sparc/include/asm/io.h:22,
from /home/sfr/next/next/arch/sparc/vdso/vclock_gettime.c:=
18:
/home/sfr/next/next/arch/sparc/include/asm/current.h:18:30: warning: call-c=
lobbered register used for global register variable
18 | register struct task_struct *current asm("g4");
| ^~~~~~~
Link: https://lkml.kernel.org/r/20230320144721.663280c3@canb.auug.org.au
Fixes: 4e29dd9708cb ("mm: vmalloc: convert vread() to vread_iter()")
Signed-off-by: Stephen Rothwell <sfr@canb.auug.org.au>
Cc: Lorenzo Stoakes <lstoakes@gmail.com>
Signed-off-by: Andrew Morton <akpm@linux-foundation.org>
---
--- a/include/linux/vmalloc.h~mm-vmalloc-convert-vread-to-vread_iter-fix
+++ a/include/linux/vmalloc.h
@@ -9,12 +9,12 @@
#include <asm/page.h> /* pgprot_t */
#include <linux/rbtree.h>
#include <linux/overflow.h>
-#include <linux/uio.h>
#include <asm/vmalloc.h>
struct vm_area_struct; /* vma defining user mapping in mm_types.h */
struct notifier_block; /* in notifier.h */
+struct iov_iter; /* in uio.h */
/* bits in flags of vmalloc's vm_struct below */
#define VM_IOREMAP 0x00000001 /* ioremap() and friends */
--- a/mm/vmalloc.c~mm-vmalloc-convert-vread-to-vread_iter-fix
+++ a/mm/vmalloc.c
@@ -40,6 +40,7 @@
#include <linux/hugetlb.h>
#include <linux/sched/mm.h>
#include <linux/rwsem.h>
+#include <linux/uio.h>
#include <asm/tlbflush.h>
#include <asm/shmparam.h>
_
Patches currently in -mm which might be from sfr@canb.auug.org.au are
mm-vmalloc-convert-vread-to-vread_iter-fix.patch
^ permalink raw reply [flat|nested] 4+ messages in thread
* + mm-vmalloc-convert-vread-to-vread_iter-fix.patch added to mm-unstable branch
@ 2023-03-23 19:37 Andrew Morton
0 siblings, 0 replies; 4+ messages in thread
From: Andrew Morton @ 2023-03-23 19:37 UTC (permalink / raw)
To: mm-commits, lstoakes, sfr, akpm
The patch titled
Subject: mm: vmalloc: fix sparc64 warning
has been added to the -mm mm-unstable branch. Its filename is
mm-vmalloc-convert-vread-to-vread_iter-fix.patch
This patch will shortly appear at
https://git.kernel.org/pub/scm/linux/kernel/git/akpm/25-new.git/tree/patches/mm-vmalloc-convert-vread-to-vread_iter-fix.patch
This patch will later appear in the mm-unstable branch at
git://git.kernel.org/pub/scm/linux/kernel/git/akpm/mm
Before you just go and hit "reply", please:
a) Consider who else should be cc'ed
b) Prefer to cc a suitable mailing list as well
c) Ideally: find the original patch on the mailing list and do a
reply-to-all to that, adding suitable additional cc's
*** Remember to use Documentation/process/submit-checklist.rst when testing your code ***
The -mm tree is included into linux-next via the mm-everything
branch at git://git.kernel.org/pub/scm/linux/kernel/git/akpm/mm
and is updated there every 2-3 working days
------------------------------------------------------
From: Stephen Rothwell <sfr@canb.auug.org.au>
Subject: mm: vmalloc: fix sparc64 warning
This fixes this warning from a sparc64 defconfig build:
In file included from /home/sfr/next/next/include/linux/wait.h:11,
from /home/sfr/next/next/include/linux/swait.h:8,
from /home/sfr/next/next/include/linux/completion.h:12,
from /home/sfr/next/next/include/linux/mm_types.h:14,
from /home/sfr/next/next/include/linux/uio.h:10,
from /home/sfr/next/next/include/linux/vmalloc.h:12,
from /home/sfr/next/next/include/asm-generic/io.h:994,
from /home/sfr/next/next/arch/sparc/include/asm/io.h:22,
from /home/sfr/next/next/arch/sparc/vdso/vclock_gettime.c:=
18:
/home/sfr/next/next/arch/sparc/include/asm/current.h:18:30: warning: call-c=
lobbered register used for global register variable
18 | register struct task_struct *current asm("g4");
| ^~~~~~~
Link: https://lkml.kernel.org/r/20230320144721.663280c3@canb.auug.org.au
Fixes: 4e29dd9708cb ("mm: vmalloc: convert vread() to vread_iter()")
Signed-off-by: Stephen Rothwell <sfr@canb.auug.org.au>
Cc: Lorenzo Stoakes <lstoakes@gmail.com>
Signed-off-by: Andrew Morton <akpm@linux-foundation.org>
---
include/linux/vmalloc.h | 2 +-
mm/vmalloc.c | 1 +
2 files changed, 2 insertions(+), 1 deletion(-)
--- a/include/linux/vmalloc.h~mm-vmalloc-convert-vread-to-vread_iter-fix
+++ a/include/linux/vmalloc.h
@@ -9,12 +9,12 @@
#include <asm/page.h> /* pgprot_t */
#include <linux/rbtree.h>
#include <linux/overflow.h>
-#include <linux/uio.h>
#include <asm/vmalloc.h>
struct vm_area_struct; /* vma defining user mapping in mm_types.h */
struct notifier_block; /* in notifier.h */
+struct iov_iter; /* in uio.h */
/* bits in flags of vmalloc's vm_struct below */
#define VM_IOREMAP 0x00000001 /* ioremap() and friends */
--- a/mm/vmalloc.c~mm-vmalloc-convert-vread-to-vread_iter-fix
+++ a/mm/vmalloc.c
@@ -33,6 +33,7 @@
#include <linux/compiler.h>
#include <linux/memcontrol.h>
#include <linux/llist.h>
+#include <linux/uio.h>
#include <linux/bitops.h>
#include <linux/rbtree_augmented.h>
#include <linux/overflow.h>
_
Patches currently in -mm which might be from sfr@canb.auug.org.au are
mm-vmalloc-convert-vread-to-vread_iter-fix.patch
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: + mm-vmalloc-convert-vread-to-vread_iter-fix.patch added to mm-unstable branch
2023-03-21 21:36 Andrew Morton
@ 2023-03-21 22:23 ` Lorenzo Stoakes
0 siblings, 0 replies; 4+ messages in thread
From: Lorenzo Stoakes @ 2023-03-21 22:23 UTC (permalink / raw)
To: linux-kernel; +Cc: mm-commits, akpm
On Tue, Mar 21, 2023 at 02:36:32PM -0700, Andrew Morton wrote:
>
> The patch titled
> Subject: mm-vmalloc-convert-vread-to-vread_iter-fix
> has been added to the -mm mm-unstable branch. Its filename is
> mm-vmalloc-convert-vread-to-vread_iter-fix.patch
>
> This patch will shortly appear at
> https://git.kernel.org/pub/scm/linux/kernel/git/akpm/25-new.git/tree/patches/mm-vmalloc-convert-vread-to-vread_iter-fix.patch
>
> This patch will later appear in the mm-unstable branch at
> git://git.kernel.org/pub/scm/linux/kernel/git/akpm/mm
>
> Before you just go and hit "reply", please:
> a) Consider who else should be cc'ed
> b) Prefer to cc a suitable mailing list as well
> c) Ideally: find the original patch on the mailing list and do a
> reply-to-all to that, adding suitable additional cc's
>
> *** Remember to use Documentation/process/submit-checklist.rst when testing your code ***
>
> The -mm tree is included into linux-next via the mm-everything
> branch at git://git.kernel.org/pub/scm/linux/kernel/git/akpm/mm
> and is updated there every 2-3 working days
>
> ------------------------------------------------------
> From: Andrew Morton <akpm@linux-foundation.org>
> Subject: mm-vmalloc-convert-vread-to-vread_iter-fix
> Date: Tue Mar 21 02:34:51 PM PDT 2023
>
> fix nommu build
>
> Cc: Lorenzo Stoakes <lstoakes@gmail.com>
> Signed-off-by: Andrew Morton <akpm@linux-foundation.org>
> ---
>
>
> --- a/mm/nommu.c~mm-vmalloc-convert-vread-to-vread_iter-fix
> +++ a/mm/nommu.c
> @@ -199,7 +199,7 @@ unsigned long vmalloc_to_pfn(const void
> }
> EXPORT_SYMBOL(vmalloc_to_pfn);
>
> -long vread_iter(struct iov_iter *iter, char *addr, size_t count)
> +long vread_iter(struct iov_iter *iter, const char *addr, size_t count)
Apologies, missed that. Will make sure it's included in any future respin.
> {
> /* Don't allow overflow */
> if ((unsigned long) addr + count < count)
> _
>
> Patches currently in -mm which might be from akpm@linux-foundation.org are
>
> mm-page_alloc-reduce-page-alloc-free-sanity-checks-checkpatch-fixes.patch
> mm-page_alloc-reduce-page-alloc-free-sanity-checks-fix.patch
> mm-userfaultfd-support-wp-on-multiple-vmas-fix.patch
> mm-add-new-api-to-enable-ksm-per-process-fix.patch
> mm-treewide-redefine-max_order-sanely-fix-2.patch
> mm-treewide-redefine-max_order-sanely-fix-3-fix.patch
> memcg-do-not-drain-charge-pcp-caches-on-remote-isolated-cpus-fix.patch
> vmstat-add-pcp-remote-node-draining-via-cpu_vm_stats_fold-fix.patch
> mm-vmalloc-convert-vread-to-vread_iter-fix.patch
> scripts-link-vmlinuxsh-fix-error-message-presentation.patch
> notifiers-add-tracepoints-to-the-notifiers-infrastructure-checkpatch-fixes.patch
>
^ permalink raw reply [flat|nested] 4+ messages in thread
* + mm-vmalloc-convert-vread-to-vread_iter-fix.patch added to mm-unstable branch
@ 2023-03-21 21:36 Andrew Morton
2023-03-21 22:23 ` Lorenzo Stoakes
0 siblings, 1 reply; 4+ messages in thread
From: Andrew Morton @ 2023-03-21 21:36 UTC (permalink / raw)
To: mm-commits, lstoakes, akpm, akpm
The patch titled
Subject: mm-vmalloc-convert-vread-to-vread_iter-fix
has been added to the -mm mm-unstable branch. Its filename is
mm-vmalloc-convert-vread-to-vread_iter-fix.patch
This patch will shortly appear at
https://git.kernel.org/pub/scm/linux/kernel/git/akpm/25-new.git/tree/patches/mm-vmalloc-convert-vread-to-vread_iter-fix.patch
This patch will later appear in the mm-unstable branch at
git://git.kernel.org/pub/scm/linux/kernel/git/akpm/mm
Before you just go and hit "reply", please:
a) Consider who else should be cc'ed
b) Prefer to cc a suitable mailing list as well
c) Ideally: find the original patch on the mailing list and do a
reply-to-all to that, adding suitable additional cc's
*** Remember to use Documentation/process/submit-checklist.rst when testing your code ***
The -mm tree is included into linux-next via the mm-everything
branch at git://git.kernel.org/pub/scm/linux/kernel/git/akpm/mm
and is updated there every 2-3 working days
------------------------------------------------------
From: Andrew Morton <akpm@linux-foundation.org>
Subject: mm-vmalloc-convert-vread-to-vread_iter-fix
Date: Tue Mar 21 02:34:51 PM PDT 2023
fix nommu build
Cc: Lorenzo Stoakes <lstoakes@gmail.com>
Signed-off-by: Andrew Morton <akpm@linux-foundation.org>
---
--- a/mm/nommu.c~mm-vmalloc-convert-vread-to-vread_iter-fix
+++ a/mm/nommu.c
@@ -199,7 +199,7 @@ unsigned long vmalloc_to_pfn(const void
}
EXPORT_SYMBOL(vmalloc_to_pfn);
-long vread_iter(struct iov_iter *iter, char *addr, size_t count)
+long vread_iter(struct iov_iter *iter, const char *addr, size_t count)
{
/* Don't allow overflow */
if ((unsigned long) addr + count < count)
_
Patches currently in -mm which might be from akpm@linux-foundation.org are
mm-page_alloc-reduce-page-alloc-free-sanity-checks-checkpatch-fixes.patch
mm-page_alloc-reduce-page-alloc-free-sanity-checks-fix.patch
mm-userfaultfd-support-wp-on-multiple-vmas-fix.patch
mm-add-new-api-to-enable-ksm-per-process-fix.patch
mm-treewide-redefine-max_order-sanely-fix-2.patch
mm-treewide-redefine-max_order-sanely-fix-3-fix.patch
memcg-do-not-drain-charge-pcp-caches-on-remote-isolated-cpus-fix.patch
vmstat-add-pcp-remote-node-draining-via-cpu_vm_stats_fold-fix.patch
mm-vmalloc-convert-vread-to-vread_iter-fix.patch
scripts-link-vmlinuxsh-fix-error-message-presentation.patch
notifiers-add-tracepoints-to-the-notifiers-infrastructure-checkpatch-fixes.patch
^ permalink raw reply [flat|nested] 4+ messages in thread
end of thread, other threads:[~2023-03-23 19:37 UTC | newest]
Thread overview: 4+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2023-03-20 21:25 + mm-vmalloc-convert-vread-to-vread_iter-fix.patch added to mm-unstable branch Andrew Morton
2023-03-21 21:36 Andrew Morton
2023-03-21 22:23 ` Lorenzo Stoakes
2023-03-23 19:37 Andrew Morton
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).