* + squashfs-squashfs_read_data-need-to-check-if-the-length-is-0.patch added to mm-hotfixes-unstable branch
@ 2023-11-16 21:48 Andrew Morton
0 siblings, 0 replies; only message in thread
From: Andrew Morton @ 2023-11-16 21:48 UTC (permalink / raw)
To: mm-commits, phillip, lizhi.xu, akpm
The patch titled
Subject: squashfs: squashfs_read_data need to check if the length is 0
has been added to the -mm mm-hotfixes-unstable branch. Its filename is
squashfs-squashfs_read_data-need-to-check-if-the-length-is-0.patch
This patch will shortly appear at
https://git.kernel.org/pub/scm/linux/kernel/git/akpm/25-new.git/tree/patches/squashfs-squashfs_read_data-need-to-check-if-the-length-is-0.patch
This patch will later appear in the mm-hotfixes-unstable branch at
git://git.kernel.org/pub/scm/linux/kernel/git/akpm/mm
Before you just go and hit "reply", please:
a) Consider who else should be cc'ed
b) Prefer to cc a suitable mailing list as well
c) Ideally: find the original patch on the mailing list and do a
reply-to-all to that, adding suitable additional cc's
*** Remember to use Documentation/process/submit-checklist.rst when testing your code ***
The -mm tree is included into linux-next via the mm-everything
branch at git://git.kernel.org/pub/scm/linux/kernel/git/akpm/mm
and is updated there every 2-3 working days
------------------------------------------------------
From: Lizhi Xu <lizhi.xu@windriver.com>
Subject: squashfs: squashfs_read_data need to check if the length is 0
Date: Thu, 16 Nov 2023 11:13:52 +0800
When the length passed in is 0, the pagemap_scan_test_walk() caller should
bail. This error causes at least a WARN_ON().
Link: https://lkml.kernel.org/r/20231116031352.40853-1-lizhi.xu@windriver.com
Reported-by: syzbot+32d3767580a1ea339a81@syzkaller.appspotmail.com
Closes: https://lkml.kernel.org/r/0000000000000526f2060a30a085@google.com
Signed-off-by: Lizhi Xu <lizhi.xu@windriver.com>
Reviewed-by: Phillip Lougher <phillip@squashfs.org.uk>
Signed-off-by: Andrew Morton <akpm@linux-foundation.org>
---
fs/squashfs/block.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
--- a/fs/squashfs/block.c~squashfs-squashfs_read_data-need-to-check-if-the-length-is-0
+++ a/fs/squashfs/block.c
@@ -321,7 +321,7 @@ int squashfs_read_data(struct super_bloc
TRACE("Block @ 0x%llx, %scompressed size %d\n", index - 2,
compressed ? "" : "un", length);
}
- if (length < 0 || length > output->length ||
+ if (length <= 0 || length > output->length ||
(index + length) > msblk->bytes_used) {
res = -EIO;
goto out;
_
Patches currently in -mm which might be from lizhi.xu@windriver.com are
squashfs-squashfs_read_data-need-to-check-if-the-length-is-0.patch
^ permalink raw reply [flat|nested] only message in thread
only message in thread, other threads:[~2023-11-16 21:48 UTC | newest]
Thread overview: (only message) (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2023-11-16 21:48 + squashfs-squashfs_read_data-need-to-check-if-the-length-is-0.patch added to mm-hotfixes-unstable branch Andrew Morton
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).