mm-commits.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
* [merged] mm-rmap-call-page_check_address-with-sync-enabled-to-avoid-racy-check.patch removed from -mm tree
@ 2016-07-19 18:10 akpm
  0 siblings, 0 replies; only message in thread
From: akpm @ 2016-07-19 18:10 UTC (permalink / raw)
  To: n-horiguchi, kirill.shutemov, mm-commits


The patch titled
     Subject: mm: rmap: call page_check_address() with sync enabled to avoid racy check
has been removed from the -mm tree.  Its filename was
     mm-rmap-call-page_check_address-with-sync-enabled-to-avoid-racy-check.patch

This patch was dropped because it was merged into mainline or a subsystem tree

------------------------------------------------------
From: Naoya Horiguchi <n-horiguchi@ah.jp.nec.com>
Subject: mm: rmap: call page_check_address() with sync enabled to avoid racy check

The previous patch addresses the race between split_huge_pmd_address() and
someone changing the pmd. The fix is only for splitting of normal thp
(i.e. pmd-mapped thp,) and for splitting of pte-mapped thp there still is
the similar race.

For splitting pte-mapped thp, the pte's conversion is done by
try_to_unmap_one(TTU_MIGRATION). This function checks page_check_address() to
get the target pte, but it can return NULL under some race, leading to
VM_BUG_ON() in freeze_page(). Fortunately, page_check_address() already has
an argument to decide whether we do a quick/racy check or not, so let's flip
it when called from freeze_page().

Link: http://lkml.kernel.org/r/1466990929-7452-2-git-send-email-n-horiguchi@ah.jp.nec.com
Signed-off-by: Naoya Horiguchi <n-horiguchi@ah.jp.nec.com>
Cc: Kirill A. Shutemov <kirill.shutemov@linux.intel.com>
Signed-off-by: Andrew Morton <akpm@linux-foundation.org>
---

 mm/rmap.c |    3 ++-
 1 file changed, 2 insertions(+), 1 deletion(-)

diff -puN mm/rmap.c~mm-rmap-call-page_check_address-with-sync-enabled-to-avoid-racy-check mm/rmap.c
--- a/mm/rmap.c~mm-rmap-call-page_check_address-with-sync-enabled-to-avoid-racy-check
+++ a/mm/rmap.c
@@ -1427,7 +1427,8 @@ static int try_to_unmap_one(struct page
 			goto out;
 	}
 
-	pte = page_check_address(page, mm, address, &ptl, 0);
+	pte = page_check_address(page, mm, address, &ptl,
+				 PageTransCompound(page));
 	if (!pte)
 		goto out;
 
_

Patches currently in -mm which might be from n-horiguchi@ah.jp.nec.com are

mm-thp-check-pmd_trans_unstable-after-split_huge_pmd.patch


^ permalink raw reply	[flat|nested] only message in thread

only message in thread, other threads:[~2016-07-19 18:10 UTC | newest]

Thread overview: (only message) (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2016-07-19 18:10 [merged] mm-rmap-call-page_check_address-with-sync-enabled-to-avoid-racy-check.patch removed from -mm tree akpm

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).