* + 9p-fix-a-potential-acl-leak.patch added to -mm tree
@ 2017-02-15 1:11 akpm
0 siblings, 0 replies; only message in thread
From: akpm @ 2017-02-15 1:11 UTC (permalink / raw)
To: xiyou.wangcong, ericvh, groug, jack, lucho, rminnich, salyzyn,
mm-commits
The patch titled
Subject: 9p: fix a potential acl leak
has been added to the -mm tree. Its filename is
9p-fix-a-potential-acl-leak.patch
This patch should soon appear at
http://ozlabs.org/~akpm/mmots/broken-out/9p-fix-a-potential-acl-leak.patch
and later at
http://ozlabs.org/~akpm/mmotm/broken-out/9p-fix-a-potential-acl-leak.patch
Before you just go and hit "reply", please:
a) Consider who else should be cc'ed
b) Prefer to cc a suitable mailing list as well
c) Ideally: find the original patch on the mailing list and do a
reply-to-all to that, adding suitable additional cc's
*** Remember to use Documentation/SubmitChecklist when testing your code ***
The -mm tree is included into linux-next and is updated
there every 3-4 working days
------------------------------------------------------
From: Cong Wang <xiyou.wangcong@gmail.com>
Subject: 9p: fix a potential acl leak
posix_acl_update_mode() could possibly clear 'acl', if so we leak the
memory pointed by 'acl'. Save this pointer before calling
posix_acl_update_mode() and release the memory if 'acl' really gets
cleared.
Link: http://lkml.kernel.org/r/1486678332-2430-1-git-send-email-xiyou.wangcong@gmail.com
Signed-off-by: Cong Wang <xiyou.wangcong@gmail.com>
Reported-by: Mark Salyzyn <salyzyn@android.com>
Reviewed-by: Jan Kara <jack@suse.cz>
Reviewed-by: Greg Kurz <groug@kaod.org>
Cc: Eric Van Hensbergen <ericvh@gmail.com>
Cc: Ron Minnich <rminnich@sandia.gov>
Cc: Latchesar Ionkov <lucho@ionkov.net>
Signed-off-by: Andrew Morton <akpm@linux-foundation.org>
---
fs/9p/acl.c | 2 ++
1 file changed, 2 insertions(+)
diff -puN fs/9p/acl.c~9p-fix-a-potential-acl-leak fs/9p/acl.c
--- a/fs/9p/acl.c~9p-fix-a-potential-acl-leak
+++ a/fs/9p/acl.c
@@ -277,6 +277,7 @@ static int v9fs_xattr_set_acl(const stru
case ACL_TYPE_ACCESS:
if (acl) {
struct iattr iattr;
+ struct posix_acl *old_acl = acl;
retval = posix_acl_update_mode(inode, &iattr.ia_mode, &acl);
if (retval)
@@ -287,6 +288,7 @@ static int v9fs_xattr_set_acl(const stru
* by the mode bits. So don't
* update ACL.
*/
+ posix_acl_release(old_acl);
value = NULL;
size = 0;
}
_
Patches currently in -mm which might be from xiyou.wangcong@gmail.com are
9p-fix-a-potential-acl-leak.patch
^ permalink raw reply [flat|nested] only message in thread
only message in thread, other threads:[~2017-02-15 1:11 UTC | newest]
Thread overview: (only message) (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2017-02-15 1:11 + 9p-fix-a-potential-acl-leak.patch added to -mm tree akpm
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).