mm-commits.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
* [folded-merged] z3fold-add-kref-refcounting-checkpatch-fixes.patch removed from -mm tree
@ 2017-02-24 22:49 akpm
  0 siblings, 0 replies; only message in thread
From: akpm @ 2017-02-24 22:49 UTC (permalink / raw)
  To: akpm, vitalywool, mm-commits


The patch titled
     Subject: z3fold-add-kref-refcounting-checkpatch-fixes
has been removed from the -mm tree.  Its filename was
     z3fold-add-kref-refcounting-checkpatch-fixes.patch

This patch was dropped because it was folded into z3fold-add-kref-refcounting.patch

------------------------------------------------------
From: Andrew Morton <akpm@linux-foundation.org>
Subject: z3fold-add-kref-refcounting-checkpatch-fixes

WARNING: Missing a blank line after declarations
#93: FILE: mm/z3fold.c:172:
+	struct page *page = virt_to_page(zhdr);
+	if (!list_empty(&zhdr->buddy))

total: 0 errors, 1 warnings, 261 lines checked

NOTE: For some of the reported defects, checkpatch may be able to
      mechanically convert to the typical style using --fix or --fix-inplace.

./patches/z3fold-add-kref-refcounting.patch has style problems, please review.

NOTE: If any of the errors are false positives, please report
      them to the maintainer, see CHECKPATCH in MAINTAINERS.

Please run checkpatch prior to sending patches

Cc: Vitaly Wool <vitalywool@gmail.com>
Signed-off-by: Andrew Morton <akpm@linux-foundation.org>
---

 mm/z3fold.c |   10 ++++++----
 1 file changed, 6 insertions(+), 4 deletions(-)

diff -puN mm/z3fold.c~z3fold-add-kref-refcounting-checkpatch-fixes mm/z3fold.c
--- a/mm/z3fold.c~z3fold-add-kref-refcounting-checkpatch-fixes
+++ a/mm/z3fold.c
@@ -166,9 +166,12 @@ static void free_z3fold_page(struct page
 
 static void release_z3fold_page(struct kref *ref)
 {
-	struct z3fold_header *zhdr = container_of(ref, struct z3fold_header,
-						refcount);
-	struct page *page = virt_to_page(zhdr);
+	struct z3fold_header *zhdr;
+	struct page *page;
+
+	zhdr = container_of(ref, struct z3fold_header, refcount);
+	page = virt_to_page(zhdr);
+
 	if (!list_empty(&zhdr->buddy))
 		list_del(&zhdr->buddy);
 	if (!list_empty(&page->lru))
@@ -188,7 +191,6 @@ static inline void z3fold_page_unlock(st
 	spin_unlock(&zhdr->page_lock);
 }
 

^ permalink raw reply	[flat|nested] only message in thread

only message in thread, other threads:[~2017-02-24 22:49 UTC | newest]

Thread overview: (only message) (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2017-02-24 22:49 [folded-merged] z3fold-add-kref-refcounting-checkpatch-fixes.patch removed from -mm tree akpm

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).