* incoming @ 2021-08-25 19:17 Andrew Morton 2021-08-25 19:17 ` [patch 1/2] mm/memory_hotplug: fix potential permanent lru cache disable Andrew Morton 2021-08-25 19:17 ` [patch 2/2] MAINTAINERS: exfat: update my email address Andrew Morton 0 siblings, 2 replies; 4+ messages in thread From: Andrew Morton @ 2021-08-25 19:17 UTC (permalink / raw) To: Linus Torvalds; +Cc: mm-commits, linux-mm 2 patches, based on 6e764bcd1cf72a2846c0e53d3975a09b242c04c9. Subsystems affected by this patch series: mm/memory-hotplug MAINTAINERS Subsystem: mm/memory-hotplug Miaohe Lin <linmiaohe@huawei.com>: mm/memory_hotplug: fix potential permanent lru cache disable Subsystem: MAINTAINERS Namjae Jeon <namjae.jeon@samsung.com>: MAINTAINERS: exfat: update my email address MAINTAINERS | 2 +- mm/memory_hotplug.c | 1 + 2 files changed, 2 insertions(+), 1 deletion(-) ^ permalink raw reply [flat|nested] 4+ messages in thread
* [patch 1/2] mm/memory_hotplug: fix potential permanent lru cache disable 2021-08-25 19:17 incoming Andrew Morton @ 2021-08-25 19:17 ` Andrew Morton 2021-08-25 23:17 ` Minchan Kim 2021-08-25 19:17 ` [patch 2/2] MAINTAINERS: exfat: update my email address Andrew Morton 1 sibling, 1 reply; 4+ messages in thread From: Andrew Morton @ 2021-08-25 19:17 UTC (permalink / raw) To: akpm, cgoldswo, david, linmiaohe, linux-mm, mhocko, minchan, mm-commits, naoya.horiguchi, osalvador, stable, torvalds From: Miaohe Lin <linmiaohe@huawei.com> Subject: mm/memory_hotplug: fix potential permanent lru cache disable If offline_pages failed after lru_cache_disable(), it forgot to do lru_cache_enable() in error path. So we would have lru cache disabled permanently in this case. Link: https://lkml.kernel.org/r/20210821094246.10149-3-linmiaohe@huawei.com Fixes: d479960e44f2 ("mm: disable LRU pagevec during the migration temporarily") Signed-off-by: Miaohe Lin <linmiaohe@huawei.com> Reviewed-by: David Hildenbrand <david@redhat.com> Reviewed-by: Oscar Salvador <osalvador@suse.de> Reviewed-by: Naoya Horiguchi <naoya.horiguchi@nec.com> Cc: Chris Goldsworthy <cgoldswo@codeaurora.org> Cc: Michal Hocko <mhocko@suse.com> Cc: Minchan Kim <minchan@kernel.org> Cc: <stable@vger.kernel.org> Signed-off-by: Andrew Morton <akpm@linux-foundation.org> --- mm/memory_hotplug.c | 1 + 1 file changed, 1 insertion(+) --- a/mm/memory_hotplug.c~mm-memory_hotplug-fix-potential-permanent-lru-cache-disable +++ a/mm/memory_hotplug.c @@ -1731,6 +1731,7 @@ failed_removal_isolated: undo_isolate_page_range(start_pfn, end_pfn, MIGRATE_MOVABLE); memory_notify(MEM_CANCEL_OFFLINE, &arg); failed_removal_pcplists_disabled: + lru_cache_enable(); zone_pcp_enable(zone); failed_removal: pr_debug("memory offlining [mem %#010llx-%#010llx] failed due to %s\n", _ ^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [patch 1/2] mm/memory_hotplug: fix potential permanent lru cache disable 2021-08-25 19:17 ` [patch 1/2] mm/memory_hotplug: fix potential permanent lru cache disable Andrew Morton @ 2021-08-25 23:17 ` Minchan Kim 0 siblings, 0 replies; 4+ messages in thread From: Minchan Kim @ 2021-08-25 23:17 UTC (permalink / raw) To: Andrew Morton Cc: cgoldswo, david, linmiaohe, linux-mm, mhocko, mm-commits, naoya.horiguchi, osalvador, stable, torvalds On Wed, Aug 25, 2021 at 12:17:55PM -0700, Andrew Morton wrote: > From: Miaohe Lin <linmiaohe@huawei.com> > Subject: mm/memory_hotplug: fix potential permanent lru cache disable > > If offline_pages failed after lru_cache_disable(), it forgot to do > lru_cache_enable() in error path. So we would have lru cache disabled > permanently in this case. > > Link: https://lkml.kernel.org/r/20210821094246.10149-3-linmiaohe@huawei.com > Fixes: d479960e44f2 ("mm: disable LRU pagevec during the migration temporarily") > Signed-off-by: Miaohe Lin <linmiaohe@huawei.com> > Reviewed-by: David Hildenbrand <david@redhat.com> > Reviewed-by: Oscar Salvador <osalvador@suse.de> > Reviewed-by: Naoya Horiguchi <naoya.horiguchi@nec.com> > Cc: Chris Goldsworthy <cgoldswo@codeaurora.org> > Cc: Michal Hocko <mhocko@suse.com> > Cc: Minchan Kim <minchan@kernel.org> > Cc: <stable@vger.kernel.org> > Signed-off-by: Andrew Morton <akpm@linux-foundation.org> Acked-by: Minchan Kim <minchan@kernel.org> Thanks for catching. ^ permalink raw reply [flat|nested] 4+ messages in thread
* [patch 2/2] MAINTAINERS: exfat: update my email address 2021-08-25 19:17 incoming Andrew Morton 2021-08-25 19:17 ` [patch 1/2] mm/memory_hotplug: fix potential permanent lru cache disable Andrew Morton @ 2021-08-25 19:17 ` Andrew Morton 1 sibling, 0 replies; 4+ messages in thread From: Andrew Morton @ 2021-08-25 19:17 UTC (permalink / raw) To: akpm, linux-mm, mm-commits, namjae.jeon, torvalds From: Namjae Jeon <namjae.jeon@samsung.com> Subject: MAINTAINERS: exfat: update my email address My email address in exfat entry will be not available in a few days. Update it to my own kernel.org address. Link: https://lkml.kernel.org/r/20210825044833.16806-1-namjae.jeon@samsung.com Signed-off-by: Namjae Jeon <namjae.jeon@samsung.com> Signed-off-by: Andrew Morton <akpm@linux-foundation.org> --- MAINTAINERS | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) --- a/MAINTAINERS~maintainers-exfat-update-my-email-address +++ a/MAINTAINERS @@ -6955,7 +6955,7 @@ F: include/uapi/linux/mdio.h F: include/uapi/linux/mii.h EXFAT FILE SYSTEM -M: Namjae Jeon <namjae.jeon@samsung.com> +M: Namjae Jeon <linkinjeon@kernel.org> M: Sungjong Seo <sj1557.seo@samsung.com> L: linux-fsdevel@vger.kernel.org S: Maintained _ ^ permalink raw reply [flat|nested] 4+ messages in thread
end of thread, other threads:[~2021-08-25 23:17 UTC | newest] Thread overview: 4+ messages (download: mbox.gz / follow: Atom feed) -- links below jump to the message on this page -- 2021-08-25 19:17 incoming Andrew Morton 2021-08-25 19:17 ` [patch 1/2] mm/memory_hotplug: fix potential permanent lru cache disable Andrew Morton 2021-08-25 23:17 ` Minchan Kim 2021-08-25 19:17 ` [patch 2/2] MAINTAINERS: exfat: update my email address Andrew Morton
This is a public inbox, see mirroring instructions for how to clone and mirror all data and code used for this inbox; as well as URLs for NNTP newsgroup(s).