* [PATCH mptcp-next v2] Squash-to: "selftests: mptcp: tweak simult_flows for debug kernels"
@ 2022-07-05 23:51 Mat Martineau
2022-07-06 1:40 ` Squash-to: "selftests: mptcp: tweak simult_flows for debug kernels": Tests Results MPTCP CI
2022-07-06 17:19 ` [PATCH mptcp-next v2] Squash-to: "selftests: mptcp: tweak simult_flows for debug kernels" Matthieu Baerts
0 siblings, 2 replies; 4+ messages in thread
From: Mat Martineau @ 2022-07-05 23:51 UTC (permalink / raw)
To: mptcp; +Cc: Mat Martineau
kbuild is still seeing intermittent failures in the simult_flows.sh
test. It uses a kernel config without kmemleak, but with other
performance-affecting debug options like lockdep and kasan.
Example failures:
kernel-selftests.net/mptcp.simult_flows.sh.unbalanced_bwidth_with_unbalanced_delay_transfer_slower_than_expected!_runtime_4339_ms_expected_4005_ms_max_4005.fail
kernel-selftests.net/mptcp.simult_flows.sh.unbalanced_bwidth_transfer_slower_than_expected!_runtime_4285_ms_expected_4005_ms_max_4005.fail
kernel-selftests.net/mptcp.simult_flows.sh.unbalanced_bwidth_transfer_slower_than_expected!_runtime_4346_ms_expected_4005_ms_max_4005.fail
Adjust the debug detection to look for more kernel debug features and
further loosen the simult_flows timing constraints if any of those
features are detected.
v2: Use kallsyms for debug feature detection, increase the debug timeout.
Signed-off-by: Mat Martineau <mathew.j.martineau@linux.intel.com>
---
tools/testing/selftests/net/mptcp/simult_flows.sh | 9 ++++++---
1 file changed, 6 insertions(+), 3 deletions(-)
diff --git a/tools/testing/selftests/net/mptcp/simult_flows.sh b/tools/testing/selftests/net/mptcp/simult_flows.sh
index e266b26a4274..ffa13a957a36 100755
--- a/tools/testing/selftests/net/mptcp/simult_flows.sh
+++ b/tools/testing/selftests/net/mptcp/simult_flows.sh
@@ -110,9 +110,12 @@ setup()
# debug build can slow down measurably the test program
# we use quite tight time limit on the run-time, to ensure
# maximum B/W usage.
- # Use the kmemleak file presence as a rough estimate for this being
- # a debug kernel and increase the maximum run-time accordingly
- [ -f /sys/kernel/debug/kmemleak ] && slack=$((slack+200))
+ # Use kmemleak/lockdep/kasan/prove_locking presence as a rough
+ # estimate for this being a debug kernel and increase the
+ # maximum run-time accordingly. Observed run times for CI builds
+ # running selftests, including kbuild, were used to determine the
+ # amount of time to add.
+ grep -q ' kmemleak_init$\| lockdep_init$\| kasan_init$\| prove_locking$' /proc/kallsyms && slack=$((slack+550))
}
# $1: ns, $2: port
--
2.37.0
^ permalink raw reply related [flat|nested] 4+ messages in thread
* Re: Squash-to: "selftests: mptcp: tweak simult_flows for debug kernels": Tests Results
2022-07-05 23:51 [PATCH mptcp-next v2] Squash-to: "selftests: mptcp: tweak simult_flows for debug kernels" Mat Martineau
@ 2022-07-06 1:40 ` MPTCP CI
2022-07-06 17:19 ` [PATCH mptcp-next v2] Squash-to: "selftests: mptcp: tweak simult_flows for debug kernels" Matthieu Baerts
1 sibling, 0 replies; 4+ messages in thread
From: MPTCP CI @ 2022-07-06 1:40 UTC (permalink / raw)
To: Mat Martineau; +Cc: mptcp
Hi Mat,
Thank you for your modifications, that's great!
Our CI did some validations and here is its report:
- KVM Validation: normal:
- Success! ✅:
- Task: https://cirrus-ci.com/task/5834940309831680
- Summary: https://api.cirrus-ci.com/v1/artifact/task/5834940309831680/summary/summary.txt
- KVM Validation: debug:
- Success! ✅:
- Task: https://cirrus-ci.com/task/5271990356410368
- Summary: https://api.cirrus-ci.com/v1/artifact/task/5271990356410368/summary/summary.txt
Initiator: Patchew Applier
Commits: https://github.com/multipath-tcp/mptcp_net-next/commits/153529610b41
If there are some issues, you can reproduce them using the same environment as
the one used by the CI thanks to a docker image, e.g.:
$ cd [kernel source code]
$ docker run -v "${PWD}:${PWD}:rw" -w "${PWD}" --privileged --rm -it \
--pull always mptcp/mptcp-upstream-virtme-docker:latest \
auto-debug
For more details:
https://github.com/multipath-tcp/mptcp-upstream-virtme-docker
Please note that despite all the efforts that have been already done to have a
stable tests suite when executed on a public CI like here, it is possible some
reported issues are not due to your modifications. Still, do not hesitate to
help us improve that ;-)
Cheers,
MPTCP GH Action bot
Bot operated by Matthieu Baerts (Tessares)
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [PATCH mptcp-next v2] Squash-to: "selftests: mptcp: tweak simult_flows for debug kernels"
2022-07-05 23:51 [PATCH mptcp-next v2] Squash-to: "selftests: mptcp: tweak simult_flows for debug kernels" Mat Martineau
2022-07-06 1:40 ` Squash-to: "selftests: mptcp: tweak simult_flows for debug kernels": Tests Results MPTCP CI
@ 2022-07-06 17:19 ` Matthieu Baerts
1 sibling, 0 replies; 4+ messages in thread
From: Matthieu Baerts @ 2022-07-06 17:19 UTC (permalink / raw)
To: Mat Martineau; +Cc: mptcp
Hi Mat,
On 06/07/2022 01:51, Mat Martineau wrote:
> kbuild is still seeing intermittent failures in the simult_flows.sh
> test. It uses a kernel config without kmemleak, but with other
> performance-affecting debug options like lockdep and kasan.
>
> Example failures:
> kernel-selftests.net/mptcp.simult_flows.sh.unbalanced_bwidth_with_unbalanced_delay_transfer_slower_than_expected!_runtime_4339_ms_expected_4005_ms_max_4005.fail
> kernel-selftests.net/mptcp.simult_flows.sh.unbalanced_bwidth_transfer_slower_than_expected!_runtime_4285_ms_expected_4005_ms_max_4005.fail
> kernel-selftests.net/mptcp.simult_flows.sh.unbalanced_bwidth_transfer_slower_than_expected!_runtime_4346_ms_expected_4005_ms_max_4005.fail
>
> Adjust the debug detection to look for more kernel debug features and
> further loosen the simult_flows timing constraints if any of those
> features are detected.
>
> v2: Use kallsyms for debug feature detection, increase the debug timeout.
Thank you for the v2!
- a240e7e697a6: "squashed" in "selftests: mptcp: tweak simult_flows for
debug kernels"
- 3925007b31c6: "Signed-off-by" + "Co-developed-by"
- Results: 7d868133e0d9..bf96db80c6d5 (export)
I left the Co-dev tags because they make sense and I'm sure you will
change the tags anyway when sending them to netdev :)
Builds and tests are now in progress:
https://cirrus-ci.com/github/multipath-tcp/mptcp_net-next/export/20220706T171803
https://github.com/multipath-tcp/mptcp_net-next/actions/workflows/build-validation.yml?query=branch:export
Cheers,
Matt
--
Tessares | Belgium | Hybrid Access Solutions
www.tessares.net
^ permalink raw reply [flat|nested] 4+ messages in thread
* [PATCH mptcp-next] Squash-to: "selftests: mptcp: tweak simult_flows for debug kernels"
@ 2022-06-27 21:44 Mat Martineau
2022-06-27 23:11 ` Squash-to: "selftests: mptcp: tweak simult_flows for debug kernels": Tests Results MPTCP CI
0 siblings, 1 reply; 4+ messages in thread
From: Mat Martineau @ 2022-06-27 21:44 UTC (permalink / raw)
To: mptcp; +Cc: Mat Martineau, pabeni
kbuild is still seeing intermittent failures in the simult_flows.sh
test. It uses a kernel config without kmemleak, but with other
performance-affecting debug options like lockdep and kasan.
Example failures:
kernel-selftests.net/mptcp.simult_flows.sh.unbalanced_bwidth_with_unbalanced_delay_transfer_slower_than_expected!_runtime_4339_ms_expected_4005_ms_max_4005.fail
kernel-selftests.net/mptcp.simult_flows.sh.unbalanced_bwidth_transfer_slower_than_expected!_runtime_4285_ms_expected_4005_ms_max_4005.fail
kernel-selftests.net/mptcp.simult_flows.sh.unbalanced_bwidth_transfer_slower_than_expected!_runtime_4346_ms_expected_4005_ms_max_4005.fail
Adjust the debug detection to loosen the simult_flows timing constraints
if either kmemleak or lockdep are configured.
Signed-off-by: Mat Martineau <mathew.j.martineau@linux.intel.com>
---
tools/testing/selftests/net/mptcp/simult_flows.sh | 7 ++++---
1 file changed, 4 insertions(+), 3 deletions(-)
diff --git a/tools/testing/selftests/net/mptcp/simult_flows.sh b/tools/testing/selftests/net/mptcp/simult_flows.sh
index e266b26a4274..fa4f0bf55049 100755
--- a/tools/testing/selftests/net/mptcp/simult_flows.sh
+++ b/tools/testing/selftests/net/mptcp/simult_flows.sh
@@ -110,9 +110,10 @@ setup()
# debug build can slow down measurably the test program
# we use quite tight time limit on the run-time, to ensure
# maximum B/W usage.
- # Use the kmemleak file presence as a rough estimate for this being
- # a debug kernel and increase the maximum run-time accordingly
- [ -f /sys/kernel/debug/kmemleak ] && slack=$((slack+200))
+ # Use the kmemleak or lockdep file presence as a rough estimate
+ # for this being a debug kernel and increase the maximum
+ # run-time accordingly
+ [ -f /sys/kernel/debug/kmemleak -o -f /proc/lockdep ] && slack=$((slack+200))
}
# $1: ns, $2: port
--
2.36.1
^ permalink raw reply related [flat|nested] 4+ messages in thread
end of thread, other threads:[~2022-07-06 17:19 UTC | newest]
Thread overview: 4+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2022-07-05 23:51 [PATCH mptcp-next v2] Squash-to: "selftests: mptcp: tweak simult_flows for debug kernels" Mat Martineau
2022-07-06 1:40 ` Squash-to: "selftests: mptcp: tweak simult_flows for debug kernels": Tests Results MPTCP CI
2022-07-06 17:19 ` [PATCH mptcp-next v2] Squash-to: "selftests: mptcp: tweak simult_flows for debug kernels" Matthieu Baerts
-- strict thread matches above, loose matches on Subject: below --
2022-06-27 21:44 [PATCH mptcp-next] " Mat Martineau
2022-06-27 23:11 ` Squash-to: "selftests: mptcp: tweak simult_flows for debug kernels": Tests Results MPTCP CI
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).