mptcp.lists.linux.dev archive mirror
 help / color / mirror / Atom feed
From: wujianguo106@163.com
To: mptcp@lists.linux.dev
Cc: pabeni@redhat.com, mathew.j.martineau@linux.intel.com
Subject: [PATCH mptcp-net v7 5/5] selftests: mptcp: fix case multiple subflows limited by server
Date: Fri, 25 Jun 2021 16:25:59 +0800	[thread overview]
Message-ID: <1624609559-6786-6-git-send-email-wujianguo106@163.com> (raw)
In-Reply-To: <1624609559-6786-1-git-send-email-wujianguo106@163.com>

From: Jianguo Wu <wujianguo@chinatelecom.cn>

After patch "mptcp: fix syncookie process if mptcp can not_accept new subflow",
If subflow is limited, MP_JOIN SYN is dropped, and no SYN/ACK will be replied.
So in case "multiple subflows limited by server", the expected SYN/ACK number
should be 1.

Reported-by: kernel test robot <oliver.sang@intel.com>
Signed-off-by: Jianguo Wu <wujianguo@chinatelecom.cn>
---
 tools/testing/selftests/net/mptcp/mptcp_join.sh | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/tools/testing/selftests/net/mptcp/mptcp_join.sh b/tools/testing/selftests/net/mptcp/mptcp_join.sh
index 9a191c1..f02f4de 100755
--- a/tools/testing/selftests/net/mptcp/mptcp_join.sh
+++ b/tools/testing/selftests/net/mptcp/mptcp_join.sh
@@ -1409,7 +1409,7 @@ syncookies_tests()
 	ip netns exec $ns2 ./pm_nl_ctl add 10.0.3.2 flags subflow
 	ip netns exec $ns2 ./pm_nl_ctl add 10.0.2.2 flags subflow
 	run_tests $ns1 $ns2 10.0.1.1
-	chk_join_nr "subflows limited by server w cookies" 2 2 1
+	chk_join_nr "subflows limited by server w cookies" 2 1 1
 
 	# test signal address with cookies
 	reset_with_cookies
-- 
1.8.3.1



      parent reply	other threads:[~2021-06-25  8:26 UTC|newest]

Thread overview: 13+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2021-06-25  8:25 [PATCH mptcp-net v7 0/5] Fix some mptcp syncookie process bugs wujianguo106
2021-06-25  8:25 ` [PATCH mptcp-net v7 1/5] mptcp: fix warning in __skb_flow_dissect() when do syn cookie for subflow join wujianguo106
2021-06-25  8:25 ` [PATCH mptcp-net v7 2/5] mptcp: remove redundant req destruct in subflow_check_req() wujianguo106
2021-06-25  8:25 ` [PATCH mptcp-net v7 3/5] mptcp: fix syncookie process if mptcp can not_accept new subflow wujianguo106
2021-06-25  8:25 ` [PATCH mptcp-net v7 4/5] mptcp: avoid processing packet if a subflow reset wujianguo106
2021-06-25  8:58   ` Geliang Tang
2021-06-25  9:07   ` Matthieu Baerts
2021-06-25  9:46     ` Jianguo Wu
2021-06-26  1:07       ` Mat Martineau
2021-06-25 10:38   ` Paolo Abeni
2021-06-25 10:45   ` Paolo Abeni
2021-06-26  8:59     ` Jianguo Wu
2021-06-25  8:25 ` wujianguo106 [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1624609559-6786-6-git-send-email-wujianguo106@163.com \
    --to=wujianguo106@163.com \
    --cc=mathew.j.martineau@linux.intel.com \
    --cc=mptcp@lists.linux.dev \
    --cc=pabeni@redhat.com \
    --subject='Re: [PATCH mptcp-net v7 5/5] selftests: mptcp: fix case multiple subflows limited by server' \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).