[Weekly meetings] MoM - 8th of July 2021

[Weekly meetings] MoM - 8th of July 2021

[Matthieu Baerts]

Hello everyone,

Today, we just had our 156th meeting with Mat and Ossama (Intel),
Florian, Paolo, Davide, Poorva (RedHat), Geliang (Xiaomi) and myself
(Tessares).


Thanks again for this new good meeting!

Here are the minutes of the meeting:



Accepted patches:
    - The list of accepted patches can be seen on PatchWork:
      https://patchwork.kernel.org/project/mptcp/list/?state=3

    netdev (if mptcp ML is in cc) (by: Paolo Abeni, Yangbo Lu):

12351833  [net] tcp: consistently disable header prediction for mptcp

12351509  [net-next,v5,08/11] net: sock: extend SO_TIMESTAMPING for PHC
binding


    our repo (by: Paolo Abeni):

12348239  [v2,mptcp-net] mptcp: properly account bulk freed memory



Pending patches:
    - The list of pending patches can be seen on PatchWork:
      https://patchwork.kernel.org/project/mptcp/list/?state=*

    netdev (if mptcp ML is in cc) (by: /):

/


    our repo (by: Geliang Tang, Jiapeng Chong, Matthieu Baerts, Paolo
Abeni, Yonglong Li):

12279739: RFC: [RFC,3/4] mptcp: move the whole rx path under msk socket
lock protection:
    - WIP

12282219: RFC: [RESEND,RFC,2/4] tcp: move selected mptcp helpers to
tcp.h/mptcp.h
12282221: RFC: [RESEND,RFC,4/4] tcp: parse tcp options contained in
reset packets:
    - WIP

12282223: RFC: [RESEND,RFC,mptpcp-next] mptcp: add ooo prune support:
    - WIP

12282225: RFC: [RESEND,1/5] tcp: make two mptcp helpers available to tcp
stack
12282227: RFC: [RESEND,5/5] mptcp: send fastclose if userspace closes
socket with unread data:
    - WIP

12321111: Changes Requested: mptcp: Remove redundant assignment to
remaining:
    - Can be taken by someone else?

12347221: Changes Requested: [v3,mptcp-next,1/8] mptcp: MP_FAIL
suboption sending
12347223: Changes Requested: [v3,mptcp-next,2/8] mptcp: MP_FAIL
suboption receiving
12347225: Changes Requested: [v3,mptcp-next,3/8] mptcp: send out MP_FAIL
when data checksum fail
12347227: Changes Requested: [v3,mptcp-next,4/8] mptcp: add the mibs for
MP_FAIL
12347229: Changes Requested: [v3,mptcp-next,5/8] selftests: mptcp: add
MP_FAIL mibs check
12347231: Changes Requested: [v3,mptcp-next,6/8] mptcp: infinite mapping
sending
12347233: Changes Requested: [v3,mptcp-next,7/8] mptcp: infinite mapping
receiving
12347235: Changes Requested: [v3,mptcp-next,8/8] mptcp: add a mib for
the infinite mapping sending:
12351927: Changes Requested: [mptcp-next] Squash to "mptcp: send out
MP_FAIL when data checksum fail":
    - Mat did a review of the v3, asking for some modifications
    - v4 expected including the Squash-to patch

12348297: Needs ACK: [mptcp-next,1/7] mptcp: more accurate timeout
12348299: Needs ACK: [mptcp-next,2/7] mptcp: less aggressive
retransmission stragegy
12348291: Needs ACK: [mptcp-next,3/7] mptcp: handle pending data on
closed subflow
12348293: Needs ACK: [mptcp-next,4/7] mptcp: faster active backup recovery
12348301: Needs ACK: [mptcp-next,5/7] mptcp: add mibs for stale subflows
processing
12348295: Needs ACK: [mptcp-next,6/7] mptcp: backup flag from incoming
MPJ ack option
12348305: Needs ACK: [mptcp-next,7/7] selftests: mptcp: add testcase for
active-back:
    - To be reviewed

12363073: New: [v8,1/4] mptcp: make MPTCP_ADD_ADDR_SIGNAL and
MPTCP_ADD_ADDR_ECHO separate
12363059: New: [v8,2/4] mptcp: fix ADD_ADDR and RM_ADDR maybe flush
addr_signal each other
12363061: New: [v8,3/4] mptcp: build ADD_ADDR/echo-ADD_ADDR option
according pm.add_signal
12363063: New: [v8,4/4] mptcp: remove MPTCP_ADD_ADDR_IPV6 and
MPTCP_ADD_ADDR_PORT:
    - To be reviewed
    - Geliang will look at this patch set next week.



Issues on Github:
    https://github.com/multipath-tcp/mptcp_net-next/issues/

    Recently opened (latest from last week: 213)

  215  TCP Urgent pointer and MPTCP [enhancement]:
      - at least to make sure we don't have issue:
          - if from userspace we request it
          - if we receive one from the other side
          - Maybe something to check with packetdrill
      - URG point is "deprecated": probably we don't need to support it
but best to make sure we don't have issue
      - (probably more "urgent" stuff to do with packetdrill)


    Bugs (opened, flagged as "bug" and assigned)

  191  Could you please let me know how to use "ip mptcp end points
backup"? [bug] [question] @matttbe:
      - TODO: Matth: check what still need to be done there after having
applied Paolo's series


    Bugs (opened and flagged as "bug" and not assigned)

  203  PM: server: accept subflows [bug]
  181  implement data_fin ack retransmission for subflow in  TIME_WAIT
state [bug]
  137  selftests: simult_flows.sh: unbalanced bwidth tests are unstable
[bug]
   65  clearing properly the status in listen() [bug]


    In Progress (opened and assigned)

  206  MPTCP-level retransmission strategy is probably too aggressive.
[enhancement] @pabeni
  194  Round-robin packet scheduler support [enhancement] @geliangtang

  193  Fullmesh path manager support [enhancement] @geliangtang
        - patches are nearly ready.
        - will send out next week

  189  Wireshark / TCPDump doesn't understand option subtype 8
(MP_TCPRST) [enhancement] @dcaratti
  186  Add netlink command support [enhancement] @mjmartineau
  167  packetdrill: add coverage for RM_ADDR [enhancement] [packetdrill]
@dcaratti
  158  iproute2: change backup mode (MP_PRIO) for active connections
[enhancement] [iproute2] @dcaratti
   52  MP_FAIL support [enhancement] @geliangtang


    Recently closed (since last week)

  211  mptcp connection stalls when mptcp retransmission are disabled
[bug] @pabeni



FYI: Current Roadmap:
    - Bugs: https://github.com/multipath-tcp/mptcp_net-next/projects/2
    - Current/Coming merge window (5.14):
https://github.com/multipath-tcp/mptcp_net-next/projects/9
    - For later: https://github.com/multipath-tcp/mptcp_net-next/projects/4
    - TODO: Matth: new project for 5.15 + update changelog, etc.



Patches to send to netdev:
    - net:
        - "Fix some mptcp syncookie process bugs" series?:
            - Last version has not been reviewed by Mat
            - But it can be sent to -net
        - @paolo: can we send "mptcp: properly account bulk freed
memory" that has been applied yesterday?:
            - yes we can!

    - net-next:
        - / → net-next is closed



Extra tests:
    - news about Syzkaller? (Mat):
        - didn't find anything related to MPTCP


    - news about interop with mptcp.org? (Mat):
        - /
        - Mat would like to check interop with big/little endian
        - 2 new comments on
https://github.com/multipath-tcp/mptcp/issues/427
        - Matth: TODO: create tickets from there


    - news about Intel's kbuild? (Mat):
        - still running without MPTCP issue


    - packetdrill (Davide):
        - Davide is looking at MP_PRIO
        - Poorva is looking at testing more setsockopt, will share that
later
        - could be nice to cover the disconnect and listen part:
            - issue 65: clearing properly the status in listen()


    - Patchew (Davide):
        - Accounts will be fixed/added soon


    - CI (Matth):
        - some selftests are often failing:
            - selftest_diag: not all the time
            - selftest_mptcp_join: always with debug
            - selftest_simult_flows: always with debug
        - @Mat: check if all tests are executed on kbuild
        - TODO: Matth: report this on Github to track the issues:
            - always the same error?
            - timing issue?



Next meeting:
    - On Thursday, the 15th of July.
    - Usual UTC time: 15:00 UTC (8am PDT, 5pm CEST, 11pm CST)
    - Still open to everyone!
    - https://annuel2.framapad.org/p/mptcp_upstreaming_20210715



Feel free to comment on these points and propose new ones for the next
meeting!

Talk to you on Thursday,
Matt
-- 
Tessares | Belgium | Hybrid Access Solutions
www.tessares.net

Re: [Weekly meetings] MoM - 8th of July 2021

[Mat Martineau]

On Thu, 8 Jul 2021, Matthieu Baerts wrote:

> Hello everyone,
>
> Today, we just had our 156th meeting with Mat and Ossama (Intel),
> Florian, Paolo, Davide, Poorva (RedHat), Geliang (Xiaomi) and myself
> (Tessares).
>
>
> Thanks again for this new good meeting!
>
> Here are the minutes of the meeting:

...

> Extra tests:

...

>    - CI (Matth):
>        - some selftests are often failing:
>            - selftest_diag: not all the time
>            - selftest_mptcp_join: always with debug
>            - selftest_simult_flows: always with debug
>        - @Mat: check if all tests are executed on kbuild

kbuild is only skipping diag.sh, because it has an older 'ss' version that 
doesn't support MPTCP.

>        - TODO: Matth: report this on Github to track the issues:
>            - always the same error?
>            - timing issue?

--
Mat Martineau
Intel