From: Jianguo Wu <wujianguo106@163.com>
To: Matthieu Baerts <matthieu.baerts@tessares.net>,
Geliang Tang <geliangtang@gmail.com>
Cc: mptcp@lists.linux.dev, Paolo Abeni <pabeni@redhat.com>,
Mat Martineau <mathew.j.martineau@linux.intel.com>
Subject: Re: [PATCH mptcp-net v8 4/5] mptcp: avoid processing packet if a subflow reset
Date: Tue, 29 Jun 2021 10:54:50 +0800 [thread overview]
Message-ID: <8d1bd111-4e44-8097-b53d-e3146530068d@163.com> (raw)
In-Reply-To: <02fdfd28-812d-0242-e354-9cd629288bcd@tessares.net>
On 2021/6/29 0:45, Matthieu Baerts wrote:
> Hi Jianguo, Geliang,
>
> On 28/06/2021 10:35, Geliang Tang wrote:
>> Thank you for this new patch set!
>>
>> There are three checkpatch.pl warnings in this patch set, please fix them.
>> And a minor comment below.
>
> As pointed out by Paolo on IRC, these modifications are required but
> they are minor. Because it is already your v8 and your first major
> series, we did these small modifications for you ;)
>
> Note that we didn't change the "goto" just to return "true".
> Also, I didn't add any Acked-by or RvB tags because none were given but
> I can easily add them later if I get any but I guess Mat will send these
> patches later to netdev with his SoB.
>
Hi Matt,
Thanks for all your work :)
> - 6bb69e9b2123: mptcp: fix warning in __skb_flow_dissect() when do syn
> cookie for subflow join
>
> - ee4bcc0a7a64: mptcp: remove redundant req destruct in subflow_check_req()
>
> - f0056198a479: mptcp: fix syncookie process if mptcp can not_accept new
> subflow
>
> - b65e3f889d44: mptcp: avoid processing packet if a subflow reset
>
> - fc66a740c7c7: selftests: mptcp: fix case multiple subflows limited by
> server
>
> - Results: 31aa314277b1..60851d13158d
>
> Builds and tests are now in progress:
>
> https://cirrus-ci.com/github/multipath-tcp/mptcp_net-next/export/20210628T164431
> https://github.com/multipath-tcp/mptcp_net-next/actions/workflows/build-validation.yml?query=branch:export/20210628T164431
>
> Cheers,
> Matt
>
next prev parent reply other threads:[~2021-06-29 2:56 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-06-26 9:16 [PATCH mptcp-net v8 0/5] Fix some mptcp syncookie process bugs wujianguo106
2021-06-26 9:16 ` [PATCH mptcp-net v8 1/5] mptcp: fix warning in __skb_flow_dissect() when do syn cookie for subflow join wujianguo106
2021-06-26 9:16 ` [PATCH mptcp-net v8 2/5] mptcp: remove redundant req destruct in subflow_check_req() wujianguo106
2021-06-26 9:16 ` [PATCH mptcp-net v8 3/5] mptcp: fix syncookie process if mptcp can not_accept new subflow wujianguo106
2021-06-26 9:16 ` [PATCH mptcp-net v8 4/5] mptcp: avoid processing packet if a subflow reset wujianguo106
2021-06-28 8:35 ` Geliang Tang
2021-06-28 16:45 ` Matthieu Baerts
2021-06-29 2:54 ` Jianguo Wu [this message]
2021-06-29 2:55 ` Jianguo Wu
2021-06-26 9:16 ` [PATCH mptcp-net v8 5/5] selftests: mptcp: fix case multiple subflows limited by server wujianguo106
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=8d1bd111-4e44-8097-b53d-e3146530068d@163.com \
--to=wujianguo106@163.com \
--cc=geliangtang@gmail.com \
--cc=mathew.j.martineau@linux.intel.com \
--cc=matthieu.baerts@tessares.net \
--cc=mptcp@lists.linux.dev \
--cc=pabeni@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).