[Weekly meetings] MoM

* [Weekly meetings] MoM - 13th of May 2021
@ 2021-05-13 16:29 Matthieu Baerts
  2021-05-13 22:00 ` Mat Martineau
  0 siblings, 1 reply; 2+ messages in thread
From: Matthieu Baerts @ 2021-05-13 16:29 UTC (permalink / raw)
  To: MPTCP Upstream

Hello everyone,

Today, we just had our 148th meeting with Mat (Intel), Christoph
(Apple), Paolo and Davide (RedHat), Jianguo and Yonglong (China Telecom)
and myself (Tessares).

Thanks again for this new good meeting!

Here are the minutes of the meeting:

Jianguo / Yonglong:
    - Welcome!
    - From China Telecom
    - Interested by MPTCP for CDN nodes
    - Thank you for contributing and participating at this meeting which
is also very late for you!

Reminder: workflow:
    - people can send patches to our ML (mptcp@lists.linux.dev)
    - patches are applied by Matth in our tree: "export" branch on Github
    - Status is updated on patchwork (ozlab: mptcp)
    - then validated by CI + tested by others
    - usually Mat sends them to netdev (if open)

Accepted patches:
    - The list of accepted patches can be seen on PatchWork:
      https://patchwork.ozlabs.org/project/mptcp/list/?state=3

    netdev (if mptcp ML is in cc) (Mat Martineau, Paolo Abeni):

1477252  [v2,net] mptcp: fix data stream corruption
1475271  [net] mptcp: fix splat when closing unaccepted socket

    our repo (by: Geliang Tang, Jianguo Wu, Paolo Abeni):

1477397  [mptcp-next] Squash to "mptcp: receive checksum for MP_CAPABLE
with d...
1475402  mptcp: generate subflow hmac after mptcp_finish_join()
1475350  [mptcp-next] Squash to "mptcp: generate the data checksum"
1475306  [mptcp-next] Squash to "mptcp: receive checksum for MP_CAPABLE
with d...
1475295  [mptcp-next] Squash to "mptcp: add csum_reqd in
mptcp_options_receive...
1475294  [mptcp-next] Squash to "mptcp: add sk parameter for
mptcp_parse_optio...
1475176  [mptcp-net] mptcp: avoid OOB access in setsockopt()

Pending patches:
    - The list of pending patches can be seen on PatchWork:
      https://patchwork.ozlabs.org/project/mptcp/list/?state=*

    netdev (if mptcp ML is in cc) (by: /):

/

    our repo (by: Davide Caratti, Florian Westphal, Geliang Tang):

1370700: RFC: [RFC,2/4] tcp: move selected mptcp helpers to tcp.h/mptcp.h
1370702: RFC: [RFC,4/4] tcp: parse tcp options contained in reset packets:
    - WIP

1375893: RFC: [RFC,mptpcp-next] mptcp: add ooo prune support
    - WIP

1395128: RFC: [1/5] tcp: make two mptcp helpers available to tcp stack
1395133: RFC: [5/5] mptcp: send fastclose if userspace closes socket
with unread data:
    - WIP

1474821: Changes Requested: [mptcp-next,1/3] mptcp: MP_FAIL suboption
sending
1474822: Changes Requested: [mptcp-next,2/3] mptcp: MP_FAIL suboption
receiving
1474823: Changes Requested: [mptcp-next,3/3] mptcp: send out MP_FAIL
when data checksum fail:
    - Reviewed by Mat
    - v2 is expected

1475381: Rejected: [mptcp-next] mptcp: don't fallback when data_fin enabled:
    - rejected because We don't want to send a reset in this case

1475835: Changes Requested: [v5,mptcp-next,1/5] mptcp: add sysctl
allow_join_initial_addr_port
1475836: Changes Requested: [v5,mptcp-next,2/5] mptcp: add
allow_join_id0 in mptcp_out_options
1475837: Changes Requested: [v5,mptcp-next,3/5] mptcp: add add_list in
mptcp_pm_data
1475838: Changes Requested: [v5,mptcp-next,4/5] mptcp: add deny_join_id0
in mptcp_options_received
1475839: Changes Requested: [v5,mptcp-next,5/5] selftests: mptcp: add
deny_join_id0 testcases:
    - series: "add MP_CAPABLE 'C' flag"
    - almost there, just one last small change to do related to the data
structure

1477138: Changes Requested: [v2,mptcp-next,1/8] mptcp: enable busypoll
from mptcp receive path
1477139: Changes Requested: [v2,mptcp-next,2/8] sock: expose
so_timestamp options for mptcp
1477140: Changes Requested: [v2,mptcp-next,3/8] sock: expose
so_timestamping options for mptcp
1477141: Changes Requested: [v2,mptcp-next,4/8] mptcp: sockopt:
propagate timestamp request to subflows
1477142: Changes Requested: [v2,mptcp-next,5/8] mptcp: setsockopt:
handle SOL_SOCKET in one place only
1477143: Changes Requested: [v2,mptcp-next,6/8] tcp: export timestamp
helpers for mptcp
1477144: Changes Requested: [v2,mptcp-next,7/8] mptcp: receive path cmsg
support
1477145: Changes Requested: [v2,mptcp-next,8/8] selftests:
mptcp_connect: add SO_TIMESTAMPNS cmsg support:
    - series: "add cmsg support to receive path"
    - the first patch needs to be modified but first finish the
discussions on this first patch
    - reviewed by Paolo

1477260: Under Review: [net] mptcp: validate 'id' when stopping the
ADD_ADDR retransmit timer:
    - reviewed by Mat
    - Davide will send a v2 to address Mat's comment

Issues on Github:
    https://github.com/multipath-tcp/mptcp_net-next/issues/

    Recently opened (latest from last week: 190)

  191  Could you please let me know how to use "ip mptcp end points
backup"?:
      - Question
      - Do we cover this case in selftests or packetdrill?
      - TODO: Matth: to reply

    Bugs (opened, flagged as "bug" and assigned)

  176  BPF selftest got "fallback to TCP" error [bug] @geliangtang:
      - everything OK there
      - just a "debug message" and we fallback for a good reason
      - close the ticket or send a patch to add comments to avoid
confusions?
      - TODO: Matth: check this

    Bugs (opened and flagged as "bug" and not assigned)

  181  implement data_fin ack retransmission for subflow in  TIME_WAIT
state [bug]

  172  WARNING in sk_stream_kill_queues [bug]:
      - Assigned to Paolo
      - There is a patch, under test
      - Matth: send the error with the patch → Done

  137  selftests: simult_flows.sh: unbalanced bwidth tests are unstable
[bug]
  120  [interop] netnext is dropping packets, causing MPTCP-level
retransmissions on mptcp.org [bug]
  107  Review use of WARN_ON() / WARN_ON_ONCE() [bug]
   65  clearing properly the status in listen() [bug]
   56  msk connection state set without msk lock [bug]

    In Progress (opened and assigned)

  189  Wireshark / TCPDump doesn't understand option subtype 8
(MP_TCPRST) [enhancement] @dcaratti:
      - wireshark is done
      - tcpdump needs review / merge

  188  Netlink events for MP_TCPRST [enhancement] @dcaratti
  187  add recvmsg support for ancillary data [enhancement] @fw-strlen
  186  Add netlink command support [enhancement] @mjmartineau

  183  MP_CAPABLE 'C' flag is ignored [enhancement] @geliangtang:
       - Patches have been sent, new version expected

  167  packetdrill: add coverage for RM_ADDR [enhancement] [packetdrill]
@dcaratti
  158  iproute2: change backup mode (MP_PRIO) for active connections
[enhancement] [iproute2] @dcaratti

  143  Packetdrill: ADD_ADDR for v6 only socket should only contain v6
addresses [enhancement] [packetdrill] @dcaratti:
      - can be closed soon

   96  Python: add support for IPPROTO_MPTCP [enhancement] @matttbe

   52  MP_FAIL support [enhancement] @geliangtang:
      - Patches have been sent, v2 expected

    Recently closed (since last week)

  182  [syzkaller] KASAN: slab-out-of-bounds Write in
tcp_init_congestion_control [bug] [syzkaller] @pabeni
  178  Server hang when proxying over multiple subflows [bug] [v5.11]
[v5.12] @pabeni
  134  Checksum support [enhancement] @pabeni
   53  MP_TCPRST support [enhancement] @fw-strlen

FYI: Current Roadmap:
    - Bugs: https://github.com/multipath-tcp/mptcp_net-next/projects/2
    - Current/Coming merge window (5.14):
https://github.com/multipath-tcp/mptcp_net-next/projects/9
    - For later: https://github.com/multipath-tcp/mptcp_net-next/projects/4

Patches to send to netdev:
    - net:
        - patches in our tree in the "fixes for net" section are either
already there or will be sent to net-next instead

    - net-next:
        - net-next is still closed
        - Mat will sent fixes first when net-next will re-open

Extra tests:
    - news about Syzkaller? (Christoph):
        - no new issues
        - Mat is running a new Syzkaller instance for when Christoph is
not available
        - some syscalls are ignored:
            - "disable_syscalls": ["perf_event_open", "syz_mount_image",
"syz_read_part_table", "openat$ttyprintk", "mount", "mkdir",
"openat$ptmx", "mq_open", "fsetxattr", "rt_tgsigqueueinfo",
"ioctl$VT_RESIZE", "ioctl$TIOCVHANGUP", "get_robust_list",
"openat$nullb", "ioctl$SCSI_IOCTL_SEND_COMMAND", "lremovexattr",
"mknod$loop", "write$binfmt_script", "syz_open_dev$sg", "write$nbd",
"prlimit64", "write$P9_RRENAMEAT", "fcntl$addseals", "finit_module",
"ioctl$KDSETMODE", "write$FUSE_NOTIFY_STORE", "ioctl$TIOC
                - *@Christoph* will send the rest on the ML
            - not all debug options needs to be turned on otherwise it
is too slow → share ideal .config?
            - Could be good to have a dedicated Wiki page about that

    - news about interop with mptcp.org? (Christoph):
        - /

    - news about Intel's kbuild? (Mat):
        - no failure but stop triggering recently
        - will check to re-start them

    - packetdrill (Davide):
        - might be good at some points to rewrite mptcp.c to fix some
core issues and make the code "upstreamable"
        - new repo or new branch → then later we can have "nice commits"
on top of the upstream branch

    - CI (Matth):
        - improve the README file of
https://github.com/multipath-tcp/mptcp-upstream-virtme-docker
        - easier for people to use it
        - e.g. to have a ready to use environment to launch MPTCP
selftests or packetdrill
        - TODO: Matth: write in the Wiki page how to use the CI:
            - new branch on Github → start build
            - using cirrus-ci
            - later with patchew

Patchwork:
    - switching to kernel.org instance (see prev meeting)
    - who modified status in the ozlab instance?:
        - Paolo, sometimes
        - Mat is updating status
        - Matth but not everyday: status might not be marked as "changed
requested" directly.
        - → we need admin rights for Paolo, Mat, Matth
        - Applied patches are marked as so automatically with scripts
        - After each meeting, "old" patches are archived

Next meeting:
    - On Thursday, the 20th of May.
    - Usual UTC time: 15:00 UTC (8am PDT, 5pm CEST, 11pm CST)
    - Still open to everyone!
    - https://annuel2.framapad.org/p/mptcp_upstreaming_20210520

Feel free to comment on these points and propose new ones for the next
meeting!

Talk to you on Thursday,
Matt
-- 
Tessares | Belgium | Hybrid Access Solutions
www.tessares.net

^ permalink raw reply	[flat|nested] 2+ messages in thread