From: Matthieu Baerts <matthieu.baerts@tessares.net>
To: Mat Martineau <mathew.j.martineau@linux.intel.com>,
mptcp@lists.linux.dev
Cc: pabeni@redhat.com
Subject: Re: [PATCH mptcp-next] Squash-to: "selftests: mptcp: tweak simult_flows for debug kernels"
Date: Tue, 28 Jun 2022 11:42:32 +0200 [thread overview]
Message-ID: <acfcb031-4be5-c5a2-6858-02fed78a89f3@tessares.net> (raw)
In-Reply-To: <20220627214438.17887-1-mathew.j.martineau@linux.intel.com>
Hi Mat,
On 27/06/2022 23:44, Mat Martineau wrote:
> kbuild is still seeing intermittent failures in the simult_flows.sh
> test. It uses a kernel config without kmemleak, but with other
> performance-affecting debug options like lockdep and kasan.
>
> Example failures:
> kernel-selftests.net/mptcp.simult_flows.sh.unbalanced_bwidth_with_unbalanced_delay_transfer_slower_than_expected!_runtime_4339_ms_expected_4005_ms_max_4005.fail
> kernel-selftests.net/mptcp.simult_flows.sh.unbalanced_bwidth_transfer_slower_than_expected!_runtime_4285_ms_expected_4005_ms_max_4005.fail
> kernel-selftests.net/mptcp.simult_flows.sh.unbalanced_bwidth_transfer_slower_than_expected!_runtime_4346_ms_expected_4005_ms_max_4005.fail
If I'm not mistaken, adding 200ms would not prevent these failures if
you got 4346ms instead of 4005ms, right? It looks like we need to extend
the time to something around 350ms.
> Adjust the debug detection to loosen the simult_flows timing constraints
> if either kmemleak or lockdep are configured.
Good idea!
I didn't find any "safe" ways to easily check that KASAN is used.
Checking dmesg doesn't seem to be a safe way for all environments.
But maybe we could do this? (with '-q')
$ grep mm/kasan /sys/devices/system/cpu/hotplug/states/sys/devices
/system/cpu/hotplug/states:70:214: mm/kasan:online
Cheers,
Matt
--
Tessares | Belgium | Hybrid Access Solutions
www.tessares.net
next prev parent reply other threads:[~2022-06-28 9:42 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-06-27 21:44 [PATCH mptcp-next] Squash-to: "selftests: mptcp: tweak simult_flows for debug kernels" Mat Martineau
2022-06-27 23:11 ` Squash-to: "selftests: mptcp: tweak simult_flows for debug kernels": Tests Results MPTCP CI
2022-06-28 9:42 ` Matthieu Baerts [this message]
2022-06-28 17:55 ` [PATCH mptcp-next] Squash-to: "selftests: mptcp: tweak simult_flows for debug kernels" Mat Martineau
2022-06-29 8:32 ` Matthieu Baerts
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=acfcb031-4be5-c5a2-6858-02fed78a89f3@tessares.net \
--to=matthieu.baerts@tessares.net \
--cc=mathew.j.martineau@linux.intel.com \
--cc=mptcp@lists.linux.dev \
--cc=pabeni@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).