From: Mat Martineau <mathew.j.martineau@linux.intel.com>
To: Paolo Abeni <pabeni@redhat.com>
Cc: mptcp@lists.linux.dev
Subject: Re: [PATCH v4 mptcp-next 4/4] net: remove SK_RECLAIM_THRESHOLD and SK_RECLAIM_CHUNK
Date: Tue, 21 Jun 2022 15:38:56 -0700 (PDT) [thread overview]
Message-ID: <b324f6a1-6f17-c52b-4725-22893fc13cd4@linux.intel.com> (raw)
In-Reply-To: <746be47fdbbf4c5fadb9d5dcb2ee2e9cff0dacf5.1655828070.git.pabeni@redhat.com>
On Tue, 21 Jun 2022, Paolo Abeni wrote:
> There are no more users for the mentioned macros, just
> drop them.
>
> Signed-off-by: Paolo Abeni <pabeni@redhat.com>
Looks good:
Acked-by: Mat Martineau <mathew.j.martineau@linux.intel.com>
(even though I'll end up replacing that with a Signed-off-by when
upstreaming anyway...)
- Mat
> ---
> include/net/sock.h | 5 -----
> 1 file changed, 5 deletions(-)
>
> diff --git a/include/net/sock.h b/include/net/sock.h
> index 5bed1ea7a722..c3ac36b7b7b8 100644
> --- a/include/net/sock.h
> +++ b/include/net/sock.h
> @@ -1619,11 +1619,6 @@ static inline void sk_mem_charge(struct sock *sk, int size)
> sk->sk_forward_alloc -= size;
> }
>
> -/* the following macros control memory reclaiming in mptcp_rmem_uncharge()
> - */
> -#define SK_RECLAIM_THRESHOLD (1 << 21)
> -#define SK_RECLAIM_CHUNK (1 << 20)
> -
> static inline void sk_mem_uncharge(struct sock *sk, int size)
> {
> if (!sk_has_account(sk))
> --
> 2.35.3
>
>
>
--
Mat Martineau
Intel
next prev parent reply other threads:[~2022-06-21 22:38 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-06-21 16:27 [PATCH v4 mptcp-next 1/4] mptcp: never fetch fwd memory from the subflow Paolo Abeni
2022-06-21 16:27 ` [PATCH v4 mptcp-next 2/4] mptcp: drop SK_RECLAIM_* macros Paolo Abeni
2022-06-21 16:27 ` [PATCH v4 mptcp-next 3/4] mptcp: refine memory scheduling Paolo Abeni
2022-06-21 16:27 ` [PATCH v4 mptcp-next 4/4] net: remove SK_RECLAIM_THRESHOLD and SK_RECLAIM_CHUNK Paolo Abeni
2022-06-21 22:38 ` Mat Martineau [this message]
2022-06-22 21:09 ` Matthieu Baerts
2022-06-21 22:35 ` [PATCH v4 mptcp-next 1/4] mptcp: never fetch fwd memory from the subflow Mat Martineau
2022-06-21 22:46 ` Mat Martineau
2022-06-22 8:31 ` Paolo Abeni
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=b324f6a1-6f17-c52b-4725-22893fc13cd4@linux.intel.com \
--to=mathew.j.martineau@linux.intel.com \
--cc=mptcp@lists.linux.dev \
--cc=pabeni@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).