[MPTCP] Re: [MPTCP][PATCH v2 mptcp-next 0/3] send ack for rm_addr and cleanups

[MPTCP] Re: [MPTCP][PATCH v2 mptcp-next 0/3] send ack for rm_addr and cleanups

[Matthieu Baerts]

[-- Attachment #1: Type: text/plain, Size: 1926 bytes --]

Hi Geliang, Mat,

On 18/03/2021 03:14, Geliang Tang wrote:
> Hi Matt,
> 
> Mat Martineau <mathew.j.martineau(a)linux.intel.com> 于2021年3月18日周四 上午8:09写道：
>>
>> On Tue, 16 Mar 2021, Geliang Tang wrote:
>>
>>> v2:
>>> - add patch 1 and patch 3.
>>> - update the debug output in patch 2.
>>> - tag: export/20210315T064655.
>>>
>>> Note:
>>> - Please insert this patchset between the commit "mptcp: move to next
>>> addr when subflow creation fail" and the commit "selftests: mptcp: signal
>>> addresses testcases" when merging it.
>>>
>>> Closes: https://github.com/multipath-tcp/mptcp_net-next/issues/173
>>>
>>> Geliang Tang (3):
>>>   mptcp: drop useless addr_signal clear
>>>   mptcp: send ack for rm_addr
>>>   mptcp: rename mptcp_pm_nl_add_addr_send_ack
>>>
>>> net/mptcp/pm.c         |  1 +
>>> net/mptcp/pm_netlink.c | 24 ++++++++----------------
>>> net/mptcp/protocol.h   |  1 +
>>> 3 files changed, 10 insertions(+), 16 deletions(-)
>>>
>>> --
>>> 2.30.2
>>
>> Geliang -
>>
>> Thanks for pointing out the dependency I missed when testing. Patch set
>> looks good for the export branch.
>>
>> Reviewed-by: Mat Martineau <mathew.j.martineau(a)linux.intel.com>
> 
> Please insert this patchset between the commit "mptcp: move to next
> addr when subflow creation fail" and the commit "selftests: mptcp: signal
> addresses testcases" when merging it into the export branch.

Thank you for the patch, the review and the reminder!

Now in our tree with Mat's RvB tag and placed before "selftests: mptcp: 
signal addresses testcases":

- 66d562873299: mptcp: drop useless addr_signal clear
- 8c3e5d0c47d0: mptcp: send ack for rm_addr
- 1790775f4e49: mptcp: rename mptcp_pm_nl_add_addr_send_ack
- Results: 1a2847789704..c11e1a8e9572

Tests + export are in progress!

Cheers,
Matt
-- 
Tessares | Belgium | Hybrid Access Solutions
www.tessares.net

[MPTCP] Re: [MPTCP][PATCH v2 mptcp-next 0/3] send ack for rm_addr and cleanups

[Geliang Tang]

[-- Attachment #1: Type: text/plain, Size: 1411 bytes --]

Hi Matt,

Mat Martineau <mathew.j.martineau(a)linux.intel.com> 于2021年3月18日周四 上午8:09写道：
>
> On Tue, 16 Mar 2021, Geliang Tang wrote:
>
> > v2:
> > - add patch 1 and patch 3.
> > - update the debug output in patch 2.
> > - tag: export/20210315T064655.
> >
> > Note:
> > - Please insert this patchset between the commit "mptcp: move to next
> > addr when subflow creation fail" and the commit "selftests: mptcp: signal
> > addresses testcases" when merging it.
> >
> > Closes: https://github.com/multipath-tcp/mptcp_net-next/issues/173
> >
> > Geliang Tang (3):
> >  mptcp: drop useless addr_signal clear
> >  mptcp: send ack for rm_addr
> >  mptcp: rename mptcp_pm_nl_add_addr_send_ack
> >
> > net/mptcp/pm.c         |  1 +
> > net/mptcp/pm_netlink.c | 24 ++++++++----------------
> > net/mptcp/protocol.h   |  1 +
> > 3 files changed, 10 insertions(+), 16 deletions(-)
> >
> > --
> > 2.30.2
>
> Geliang -
>
> Thanks for pointing out the dependency I missed when testing. Patch set
> looks good for the export branch.
>
> Reviewed-by: Mat Martineau <mathew.j.martineau(a)linux.intel.com>

Please insert this patchset between the commit "mptcp: move to next
addr when subflow creation fail" and the commit "selftests: mptcp: signal
addresses testcases" when merging it into the export branch.

Thanks.

-Geliang

>
> --
> Mat Martineau
> Intel

[MPTCP] Re: [MPTCP][PATCH v2 mptcp-next 0/3] send ack for rm_addr and cleanups

[Mat Martineau]

[-- Attachment #1: Type: text/plain, Size: 996 bytes --]

On Tue, 16 Mar 2021, Geliang Tang wrote:

> v2:
> - add patch 1 and patch 3.
> - update the debug output in patch 2.
> - tag: export/20210315T064655.
>
> Note:
> - Please insert this patchset between the commit "mptcp: move to next
> addr when subflow creation fail" and the commit "selftests: mptcp: signal
> addresses testcases" when merging it.
>
> Closes: https://github.com/multipath-tcp/mptcp_net-next/issues/173
>
> Geliang Tang (3):
>  mptcp: drop useless addr_signal clear
>  mptcp: send ack for rm_addr
>  mptcp: rename mptcp_pm_nl_add_addr_send_ack
>
> net/mptcp/pm.c         |  1 +
> net/mptcp/pm_netlink.c | 24 ++++++++----------------
> net/mptcp/protocol.h   |  1 +
> 3 files changed, 10 insertions(+), 16 deletions(-)
>
> -- 
> 2.30.2

Geliang -

Thanks for pointing out the dependency I missed when testing. Patch set 
looks good for the export branch.

Reviewed-by: Mat Martineau <mathew.j.martineau(a)linux.intel.com>

--
Mat Martineau
Intel