[PATCH mptcp-next v7 00/13] BPF packet scheduler

* [PATCH mptcp-next v7 00/13] BPF packet scheduler
@ 2022-06-02  4:53 Geliang Tang
  2022-06-02  4:53 ` [PATCH mptcp-next v7 01/13] Squash to "mptcp: add struct mptcp_sched_ops" Geliang Tang
                   ` (13 more replies)
  0 siblings, 14 replies; 19+ messages in thread
From: Geliang Tang @ 2022-06-02  4:53 UTC (permalink / raw)
  To: mptcp; +Cc: Geliang Tang

v7:
 - Compared with v6, only one line of code is modified, adding the
   missing preserve_access_index for mptcp_sched_data:

'''

--- a/tools/testing/selftests/bpf/bpf_tcp_helpers.h
+++ b/tools/testing/selftests/bpf/bpf_tcp_helpers.h
@@ -241,7 +241,7 @@ struct mptcp_subflow_context {
 struct mptcp_sched_data {
 	bool	reinject;
 	struct mptcp_subflow_context *contexts[MPTCP_SUBFLOWS_MAX];
-};
+} __attribute__((preserve_access_index));
 
 struct mptcp_sched_ops {
 	char name[MPTCP_SCHED_NAME_MAX];
'''

 - split the changes to bpf_tcp_helpers.h into "selftests/bpf: Add mptcp
sched structs" as Mat suggested.

 - split the commit "mptcp: add subflow_set_scheduled helper" in v6 into
two: "mptcp: add scheduled in mptcp_subflow_context" and "bpf: Add
bpf_mptcp_sched_kfunc_set".

 - update subjects and commit logs.

 - full patches of this series are in my git tree: https://github.com/geliangtang/mptcp_net-next
24744c54b1ff selftests/bpf: Add bpf_rr test
38025f9d475d selftests/bpf: Add bpf_rr scheduler
3a3ff68c3a5c selftests/bpf: Add bpf_bkup test
dca2db73fbf7 selftests/bpf: Add bpf_bkup scheduler
1c4aa6d66fa4 selftests/bpf: Add bpf_first test
22e828c59707 selftests/bpf: Add bpf_first scheduler
fec3332cdd65 selftests/bpf: Add mptcp sched structs
9827fdb964a3 bpf: Add bpf_mptcp_sched_kfunc_set
43422ac185dc bpf: Add bpf_mptcp_sched_ops
4d1b800070ec mptcp: add get_subflow wrappers
ae39f16c28a5 mptcp: add scheduled in mptcp_subflow_context
83e578b46253 mptcp: add sched in mptcp_sock
e69ba4ac0a70 mptcp: add a new sysctl scheduler
1f6ee94e97a0 mptcp: add struct mptcp_sched_ops

v6:
 - fix the warning reported by kernel test robot:

>> net/mptcp/bpf.c:165:6: warning: no previous prototype for 'bpf_mptcp_subflow_set_scheduled' [-Wmissing-prototypes]
     165 | void bpf_mptcp_subflow_set_scheduled(struct mptcp_subflow_context *subflow)
         |      ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
 - rename bpf_mptcp_subflow_set_scheduled to mptcp_subflow_set_scheduled

v5:
 - add bpf_mptcp_subflow_set_scheduled helper.
 - drop padding bits before backup, use BPF_CORE_READ_BITFIELD_PROBED()
   instead.
 - The new patch "mptcp: add bpf set scheduled helper" should be inserted
   between the commits "mptcp: add bpf_mptcp_sched_ops" and
   "selftests/bpf: add bpf_first scheduler"

v4:
 - merge "mptcp: move is_scheduled into mptcp_subflow_context"
 - rename bpf_backup tp bpf_bkup

v3:
 - use new BPF scheduler API:
 - add backup scheduler
 - add round-robin scheduler
 - check bytes_sent of 'ss' output.

v2:
- Use new BPF scheduler API:
 unsigned long (*get_subflow)(const struct mptcp_sock *msk, bool reinject,
                              struct mptcp_sched_data *data);

Geliang Tang (13):
  Squash to "mptcp: add struct mptcp_sched_ops"
  Squash to "mptcp: add sched in mptcp_sock"
  mptcp: add scheduled in mptcp_subflow_context
  Squash to "mptcp: add get_subflow wrappers"
  Squash to "mptcp: add bpf_mptcp_sched_ops"
  bpf: Add bpf_mptcp_sched_kfunc_set
  selftests/bpf: Add mptcp sched structs
  Squash to "selftests/bpf: add bpf_first scheduler"
  Squash to "selftests/bpf: add bpf_first test"
  selftests/bpf: Add bpf_bkup scheduler
  selftests/bpf: Add bpf_bkup test
  selftests/bpf: Add bpf_rr scheduler
  selftests/bpf: Add bpf_rr test

 include/net/mptcp.h                           |  7 +-
 net/mptcp/bpf.c                               | 34 ++++---
 net/mptcp/protocol.h                          |  3 +
 net/mptcp/sched.c                             | 60 ++++++++++---
 tools/testing/selftests/bpf/bpf_tcp_helpers.h | 19 ++--
 .../testing/selftests/bpf/prog_tests/mptcp.c  | 89 ++++++++++++++++++-
 .../selftests/bpf/progs/mptcp_bpf_bkup.c      | 43 +++++++++
 .../selftests/bpf/progs/mptcp_bpf_first.c     |  5 +-
 .../selftests/bpf/progs/mptcp_bpf_rr.c        | 46 ++++++++++
 9 files changed, 273 insertions(+), 33 deletions(-)
 create mode 100644 tools/testing/selftests/bpf/progs/mptcp_bpf_bkup.c
 create mode 100644 tools/testing/selftests/bpf/progs/mptcp_bpf_rr.c

-- 
2.34.1


^ permalink raw reply	[flat|nested] 19+ messages in thread