* [PATCH] selftests: mptcp: turn rp_filter off on every NIC
@ 2021-06-09 6:22 Yonglong Li
2021-06-10 0:29 ` Mat Martineau
0 siblings, 1 reply; 2+ messages in thread
From: Yonglong Li @ 2021-06-09 6:22 UTC (permalink / raw)
To: mptcp
Cc: pabeni, matthieu.baerts, mathew.j.martineau, geliangtang, Yonglong Li
To turn rp_filter off we should:
echo 0 > /proc/sys/net/ipv4/conf/<device>/rp_filter
and
echo 0 > /proc/sys/net/ipv4/conf/all/rp_filter
Signed-off-by: Yonglong Li <liyonglong@chinatelecom.cn>
---
tools/testing/selftests/net/mptcp/simult_flows.sh | 2 ++
1 file changed, 2 insertions(+)
diff --git a/tools/testing/selftests/net/mptcp/simult_flows.sh b/tools/testing/selftests/net/mptcp/simult_flows.sh
index 3aeef3b..a29ffef 100755
--- a/tools/testing/selftests/net/mptcp/simult_flows.sh
+++ b/tools/testing/selftests/net/mptcp/simult_flows.sh
@@ -81,6 +81,8 @@ setup()
ip netns exec "$ns1" ./pm_nl_ctl limits 1 1
ip netns exec "$ns1" ./pm_nl_ctl add 10.0.2.1 dev ns1eth2 flags subflow
ip netns exec "$ns1" sysctl -q net.ipv4.conf.all.rp_filter=0
+ ip netns exec "$ns1" sysctl -q net.ipv4.conf.ns1eth1.rp_filter=0
+ ip netns exec "$ns1" sysctl -q net.ipv4.conf.ns1eth2.rp_filter=0
ip -net "$ns2" addr add 10.0.1.2/24 dev ns2eth1
ip -net "$ns2" addr add dead:beef:1::2/64 dev ns2eth1 nodad
--
1.8.3.1
^ permalink raw reply related [flat|nested] 2+ messages in thread
* Re: [PATCH] selftests: mptcp: turn rp_filter off on every NIC
2021-06-09 6:22 [PATCH] selftests: mptcp: turn rp_filter off on every NIC Yonglong Li
@ 2021-06-10 0:29 ` Mat Martineau
0 siblings, 0 replies; 2+ messages in thread
From: Mat Martineau @ 2021-06-10 0:29 UTC (permalink / raw)
To: Yonglong Li; +Cc: mptcp, pabeni, matthieu.baerts, geliangtang
On Wed, 9 Jun 2021, Yonglong Li wrote:
> To turn rp_filter off we should:
> echo 0 > /proc/sys/net/ipv4/conf/<device>/rp_filter
> and
> echo 0 > /proc/sys/net/ipv4/conf/all/rp_filter
>
> Signed-off-by: Yonglong Li <liyonglong@chinatelecom.cn>
> ---
> tools/testing/selftests/net/mptcp/simult_flows.sh | 2 ++
> 1 file changed, 2 insertions(+)
>
> diff --git a/tools/testing/selftests/net/mptcp/simult_flows.sh b/tools/testing/selftests/net/mptcp/simult_flows.sh
> index 3aeef3b..a29ffef 100755
> --- a/tools/testing/selftests/net/mptcp/simult_flows.sh
> +++ b/tools/testing/selftests/net/mptcp/simult_flows.sh
> @@ -81,6 +81,8 @@ setup()
> ip netns exec "$ns1" ./pm_nl_ctl limits 1 1
> ip netns exec "$ns1" ./pm_nl_ctl add 10.0.2.1 dev ns1eth2 flags subflow
> ip netns exec "$ns1" sysctl -q net.ipv4.conf.all.rp_filter=0
> + ip netns exec "$ns1" sysctl -q net.ipv4.conf.ns1eth1.rp_filter=0
> + ip netns exec "$ns1" sysctl -q net.ipv4.conf.ns1eth2.rp_filter=0
>
> ip -net "$ns2" addr add 10.0.1.2/24 dev ns2eth1
> ip -net "$ns2" addr add dead:beef:1::2/64 dev ns2eth1 nodad
> --
> 1.8.3.1
>
>
Would it make sense to set net.ipv4.conf.all.rp_filter=0 and
net.ipv4.conf.default.rp_filter=0 at line 63 (in the loop that runs 'ip
netns add') like mptcp_join.sh and mptcp_connect.sh do?
--
Mat Martineau
Intel
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2021-06-10 0:29 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2021-06-09 6:22 [PATCH] selftests: mptcp: turn rp_filter off on every NIC Yonglong Li
2021-06-10 0:29 ` Mat Martineau
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).