From: Matthieu Baerts <matthieu.baerts@tessares.net>
To: menglong8.dong@gmail.com, pabeni@redhat.com
Cc: mptcp@lists.linux.dev, Menglong Dong <imagedong@tencent.com>
Subject: Re: [PATCH net v5 0/2] net: mptcp: fix unreleased socket in accept queue
Date: Mon, 19 Sep 2022 17:14:52 +0200 [thread overview]
Message-ID: <f7f23136-3227-5c80-45c0-29a52c5ec11a@tessares.net> (raw)
In-Reply-To: <20220911041418.818201-1-imagedong@tencent.com>
Hi Menglong, Paolo,
On 11/09/2022 06:14, menglong8.dong@gmail.com wrote:
> From: Menglong Dong <imagedong@tencent.com>
>
> The mptcp socket and its subflow sockets in accept queue can't be
> released after the process exit.
>
> While the release of a mptcp socket in listening state, the
> corresponding tcp socket will be released too. Meanwhile, the tcp
> socket in the unaccept queue will be released too. However, only init
> subflow is in the unaccept queue, and the joined subflow is not in the
> unaccept queue, which makes the joined subflow won't be released, and
> therefore the corresponding unaccepted mptcp socket will not be released
> to.
>
> In the 1th patch, we factor-out __mptcp_close() which should run under
> socket lock.
>
> And in the 2th patch, we fix the problem we mentioned above by closing
> all of the unaccepted mptcp socket in mptcp_subflow_queue_clean()
> with __mptcp_close().
Thank you for the patches and the reviews!
This series is now in our tree (fix for -net) with Paolo's ACK and
without one typo found by "checkpatch.pl --codespell" and 'net:' prefix
has been strip from the commit titles ('mptcp:' is enough)
New patches for t/upstream-net:
- 8c21b4904d34: mptcp: factor out __mptcp_close() without socket lock
- f00ac22032b8: mptcp: fix unreleased socket in accept queue
- Results: 69b3bebab7a6..2882a52515ba (export-net)
New patches for t/upstream:
- 8c21b4904d34: mptcp: factor out __mptcp_close() without socket lock
- f00ac22032b8: mptcp: fix unreleased socket in accept queue
- Results: 6cd726fd86f8..6c59a4b0aee6 (export)
Tests are now in progress:
https://cirrus-ci.com/github/multipath-tcp/mptcp_net-next/export-net/20220919T151225
https://cirrus-ci.com/github/multipath-tcp/mptcp_net-next/export/20220919T151225
Cheers,
Matt
--
Tessares | Belgium | Hybrid Access Solutions
www.tessares.net
prev parent reply other threads:[~2022-09-19 15:14 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-09-11 4:14 [PATCH net v5 0/2] net: mptcp: fix unreleased socket in accept queue menglong8.dong
2022-09-11 4:14 ` [PATCH net v5 1/2] net: mptcp: factor out __mptcp_close() without socket lock menglong8.dong
2022-09-11 4:14 ` [PATCH net v5 2/2] net: mptcp: fix unreleased socket in accept queue menglong8.dong
2022-09-19 14:17 ` [PATCH net v5 0/2] " Paolo Abeni
2022-09-19 15:14 ` Matthieu Baerts [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=f7f23136-3227-5c80-45c0-29a52c5ec11a@tessares.net \
--to=matthieu.baerts@tessares.net \
--cc=imagedong@tencent.com \
--cc=menglong8.dong@gmail.com \
--cc=mptcp@lists.linux.dev \
--cc=pabeni@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).