* [PATCH 03/36] net: can: flexcan: remove unnecessary platform_set_drvdata()
@ 2013-05-07 4:15 Jingoo Han
2013-05-07 7:08 ` Marc Kleine-Budde
0 siblings, 1 reply; 2+ messages in thread
From: Jingoo Han @ 2013-05-07 4:15 UTC (permalink / raw)
To: 'David S. Miller'
Cc: netdev, Jingoo Han, 'Fabio Baltieri', Marc Kleine-Budde
The driver core clears the driver data to NULL after device_release
or on probe failure, since commit 0998d0631001288a5974afc0b2a5f568bcdecb4d
(device-core: Ensure drvdata = NULL when no driver is bound).
Thus, it is not needed to manually clear the device driver data to NULL.
Signed-off-by: Jingoo Han <jg1.han@samsung.com>
---
drivers/net/can/flexcan.c | 1 -
1 files changed, 0 insertions(+), 1 deletions(-)
diff --git a/drivers/net/can/flexcan.c b/drivers/net/can/flexcan.c
index 769d29e..4a40a18 100644
--- a/drivers/net/can/flexcan.c
+++ b/drivers/net/can/flexcan.c
@@ -1127,7 +1127,6 @@ static int flexcan_remove(struct platform_device *pdev)
struct resource *mem;
unregister_flexcandev(dev);
- platform_set_drvdata(pdev, NULL);
iounmap(priv->base);
mem = platform_get_resource(pdev, IORESOURCE_MEM, 0);
--
1.7.2.5
^ permalink raw reply related [flat|nested] 2+ messages in thread
* Re: [PATCH 03/36] net: can: flexcan: remove unnecessary platform_set_drvdata()
2013-05-07 4:15 [PATCH 03/36] net: can: flexcan: remove unnecessary platform_set_drvdata() Jingoo Han
@ 2013-05-07 7:08 ` Marc Kleine-Budde
0 siblings, 0 replies; 2+ messages in thread
From: Marc Kleine-Budde @ 2013-05-07 7:08 UTC (permalink / raw)
To: Jingoo Han; +Cc: 'David S. Miller', netdev, 'Fabio Baltieri'
[-- Attachment #1: Type: text/plain, Size: 725 bytes --]
On 05/07/2013 06:15 AM, Jingoo Han wrote:
> The driver core clears the driver data to NULL after device_release
> or on probe failure, since commit 0998d0631001288a5974afc0b2a5f568bcdecb4d
> (device-core: Ensure drvdata = NULL when no driver is bound).
> Thus, it is not needed to manually clear the device driver data to NULL.
>
> Signed-off-by: Jingoo Han <jg1.han@samsung.com>
Acked-by: Marc Kleine-Budde <mkl@pengutronix.de>
Marc
--
Pengutronix e.K. | Marc Kleine-Budde |
Industrial Linux Solutions | Phone: +49-231-2826-924 |
Vertretung West/Dortmund | Fax: +49-5121-206917-5555 |
Amtsgericht Hildesheim, HRA 2686 | http://www.pengutronix.de |
[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 263 bytes --]
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2013-05-07 7:08 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2013-05-07 4:15 [PATCH 03/36] net: can: flexcan: remove unnecessary platform_set_drvdata() Jingoo Han
2013-05-07 7:08 ` Marc Kleine-Budde
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).