netdev.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
* [PATCH] nl80211: add NL80211_CMD_UPDATE_FT_IES to supported commands
@ 2019-08-22 17:48 Matthew Wang
  2019-08-22 18:07 ` Brian Norris
  0 siblings, 1 reply; 3+ messages in thread
From: Matthew Wang @ 2019-08-22 17:48 UTC (permalink / raw)
  To: johannes; +Cc: davem, linux-wireless, netdev, linux-kernel, Matthew Wang

Add NL80211_CMD_UPDATE_FT_IES to supported commands. In mac80211 drivers,
this can be implemented via existing NL80211_CMD_AUTHENTICATE and
NL80211_ATTR_IE, but non-mac80211 drivers have a separate command for
this. A driver supports FT if it either is mac80211 or supports this
command.

Signed-off-by: Matthew Wang <matthewmwang@chromium.org>
Change-Id: I93e3d09a6d949466d1aea48bff2c3ad862edccc6
---
 net/wireless/nl80211.c | 1 +
 1 file changed, 1 insertion(+)

diff --git a/net/wireless/nl80211.c b/net/wireless/nl80211.c
index fd05ae1437a9..c2f9e6b429b2 100644
--- a/net/wireless/nl80211.c
+++ b/net/wireless/nl80211.c
@@ -2065,6 +2065,7 @@ static int nl80211_send_wiphy(struct cfg80211_registered_device *rdev,
 				CMD(add_tx_ts, ADD_TX_TS);
 			CMD(set_multicast_to_unicast, SET_MULTICAST_TO_UNICAST);
 			CMD(update_connect_params, UPDATE_CONNECT_PARAMS);
+			CMD(update_ft_ies, UPDATE_FT_IES);
 		}
 #undef CMD
 
-- 
2.23.0.187.g17f5b7556c-goog


^ permalink raw reply related	[flat|nested] 3+ messages in thread

* Re: [PATCH] nl80211: add NL80211_CMD_UPDATE_FT_IES to supported commands
  2019-08-22 17:48 [PATCH] nl80211: add NL80211_CMD_UPDATE_FT_IES to supported commands Matthew Wang
@ 2019-08-22 18:07 ` Brian Norris
  2019-08-22 18:08   ` Johannes Berg
  0 siblings, 1 reply; 3+ messages in thread
From: Brian Norris @ 2019-08-22 18:07 UTC (permalink / raw)
  To: Matthew Wang; +Cc: johannes, davem, linux-wireless, netdev, linux-kernel

On Thu, Aug 22, 2019 at 10:48:06AM -0700, Matthew Wang wrote:
> Add NL80211_CMD_UPDATE_FT_IES to supported commands. In mac80211 drivers,
> this can be implemented via existing NL80211_CMD_AUTHENTICATE and
> NL80211_ATTR_IE, but non-mac80211 drivers have a separate command for
> this. A driver supports FT if it either is mac80211 or supports this
> command.
> 
> Signed-off-by: Matthew Wang <matthewmwang@chromium.org>

FWIW:

Reviewed-by: Brian Norris <briannorris@chromium.org>

> Change-Id: I93e3d09a6d949466d1aea48bff2c3ad862edccc6

Oops :)

^ permalink raw reply	[flat|nested] 3+ messages in thread

* Re: [PATCH] nl80211: add NL80211_CMD_UPDATE_FT_IES to supported commands
  2019-08-22 18:07 ` Brian Norris
@ 2019-08-22 18:08   ` Johannes Berg
  0 siblings, 0 replies; 3+ messages in thread
From: Johannes Berg @ 2019-08-22 18:08 UTC (permalink / raw)
  To: Brian Norris, Matthew Wang; +Cc: davem, linux-wireless, netdev, linux-kernel

On Thu, 2019-08-22 at 11:07 -0700, Brian Norris wrote:
> On Thu, Aug 22, 2019 at 10:48:06AM -0700, Matthew Wang wrote:
> > Add NL80211_CMD_UPDATE_FT_IES to supported commands. In mac80211 drivers,
> > this can be implemented via existing NL80211_CMD_AUTHENTICATE and
> > NL80211_ATTR_IE, but non-mac80211 drivers have a separate command for
> > this. A driver supports FT if it either is mac80211 or supports this
> > command.
> > 
> > Signed-off-by: Matthew Wang <matthewmwang@chromium.org>
> 
> FWIW:
> 
> Reviewed-by: Brian Norris <briannorris@chromium.org>
> 
> > Change-Id: I93e3d09a6d949466d1aea48bff2c3ad862edccc6
> 
> Oops :)

:)

No worries, I can edit that out.

johannes


^ permalink raw reply	[flat|nested] 3+ messages in thread

end of thread, other threads:[~2019-08-22 18:09 UTC | newest]

Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2019-08-22 17:48 [PATCH] nl80211: add NL80211_CMD_UPDATE_FT_IES to supported commands Matthew Wang
2019-08-22 18:07 ` Brian Norris
2019-08-22 18:08   ` Johannes Berg

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).