From: Saeed Mahameed <saeedm@mellanox.com>
To: "saeedm@dev.mellanox.co.il" <saeedm@dev.mellanox.co.il>,
"olof@lixom.net" <olof@lixom.net>
Cc: "joe@perches.com" <joe@perches.com>,
"netdev@vger.kernel.org" <netdev@vger.kernel.org>,
"linux-rdma@vger.kernel.org" <linux-rdma@vger.kernel.org>,
"leon@kernel.org" <leon@kernel.org>,
"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH] net/mlx5e: Fix printk format warning
Date: Tue, 21 Jan 2020 20:43:18 +0000 [thread overview]
Message-ID: <028a4905eaf02dce476e8cfc517b49760f57f577.camel@mellanox.com> (raw)
In-Reply-To: <CAOesGMhXHCz+ahs6whKsS32uECVry9Lk6BQxcvczPXgcoh6b6w@mail.gmail.com>
On Mon, 2020-01-20 at 19:20 -0800, Olof Johansson wrote:
> Hi,
>
> On Mon, Dec 30, 2019 at 8:35 PM Saeed Mahameed
> <saeedm@dev.mellanox.co.il> wrote:
> > On Sat, Dec 21, 2019 at 1:19 PM Olof Johansson <olof@lixom.net>
> > wrote:
> > > On Thu, Dec 19, 2019 at 6:07 PM Joe Perches <joe@perches.com>
> > > wrote:
> > > > On Thu, 2019-12-19 at 16:15 -0800, Olof Johansson wrote:
> > > > > Use "%zu" for size_t. Seen on ARM allmodconfig:
> > > > []
> > > > > diff --git a/drivers/net/ethernet/mellanox/mlx5/core/wq.c
> > > > > b/drivers/net/ethernet/mellanox/mlx5/core/wq.c
> > > > []
> > > > > @@ -89,7 +89,7 @@ void mlx5_wq_cyc_wqe_dump(struct
> > > > > mlx5_wq_cyc *wq, u16 ix, u8 nstrides)
> > > > > len = nstrides << wq->fbc.log_stride;
> > > > > wqe = mlx5_wq_cyc_get_wqe(wq, ix);
> > > > >
> > > > > - pr_info("WQE DUMP: WQ size %d WQ cur size %d, WQE index
> > > > > 0x%x, len: %ld\n",
> > > > > + pr_info("WQE DUMP: WQ size %d WQ cur size %d, WQE index
> > > > > 0x%x, len: %zu\n",
> > > > > mlx5_wq_cyc_get_size(wq), wq->cur_sz, ix, len);
> > > > > print_hex_dump(KERN_WARNING, "", DUMP_PREFIX_OFFSET,
> > > > > 16, 1, wqe, len, false);
> > > > > }
> > > >
> > > > One might expect these 2 outputs to be at the same KERN_<LEVEL>
> > > > too.
> > > > One is KERN_INFO the other KERN_WARNING
> > >
> > > Sure, but I'll leave that up to the driver maintainers to
> > > decide/fix
> > > -- I'm just addressing the type warning here.
> >
> > Hi Olof, sorry for the delay, and thanks for the patch,
> >
> > I will apply this to net-next-mlx5 and will submit to net-next
> > myself.
> > we will fixup and address the warning level comment by Joe.
>
> This seems to still be pending, and the merge window is soon here.
> Any
> chance we can see it show up in linux-next soon?
>
>
Hi Olof,
I am still preparing my next pull request which will include this patch
I will send it soon to net-next branch, but still the patch will not
hit linux-next until the merge window when netdev subsystem is pulled
into linux-next..
Thanks,
Saeed.
next prev parent reply other threads:[~2020-01-21 20:43 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-12-20 0:15 [PATCH] net/mlx5e: Fix printk format warning Olof Johansson
2019-12-20 2:06 ` Joe Perches
2019-12-21 21:19 ` Olof Johansson
2019-12-31 4:35 ` Saeed Mahameed
2020-01-21 3:20 ` Olof Johansson
2020-01-21 20:43 ` Saeed Mahameed [this message]
2020-01-22 16:36 ` Olof Johansson
2020-01-22 18:51 ` Saeed Mahameed
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=028a4905eaf02dce476e8cfc517b49760f57f577.camel@mellanox.com \
--to=saeedm@mellanox.com \
--cc=joe@perches.com \
--cc=leon@kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-rdma@vger.kernel.org \
--cc=netdev@vger.kernel.org \
--cc=olof@lixom.net \
--cc=saeedm@dev.mellanox.co.il \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).