From: Joe Perches <joe@perches.com>
To: Olof Johansson <olof@lixom.net>,
Saeed Mahameed <saeedm@mellanox.com>,
Leon Romanovsky <leon@kernel.org>
Cc: netdev@vger.kernel.org, linux-rdma@vger.kernel.org,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH] net/mlx5e: Fix printk format warning
Date: Thu, 19 Dec 2019 18:06:57 -0800 [thread overview]
Message-ID: <ff6dc8997083c5d8968df48cc191e5b9e8797618.camel@perches.com> (raw)
In-Reply-To: <20191220001517.105297-1-olof@lixom.net>
On Thu, 2019-12-19 at 16:15 -0800, Olof Johansson wrote:
> Use "%zu" for size_t. Seen on ARM allmodconfig:
[]
> diff --git a/drivers/net/ethernet/mellanox/mlx5/core/wq.c b/drivers/net/ethernet/mellanox/mlx5/core/wq.c
[]
> @@ -89,7 +89,7 @@ void mlx5_wq_cyc_wqe_dump(struct mlx5_wq_cyc *wq, u16 ix, u8 nstrides)
> len = nstrides << wq->fbc.log_stride;
> wqe = mlx5_wq_cyc_get_wqe(wq, ix);
>
> - pr_info("WQE DUMP: WQ size %d WQ cur size %d, WQE index 0x%x, len: %ld\n",
> + pr_info("WQE DUMP: WQ size %d WQ cur size %d, WQE index 0x%x, len: %zu\n",
> mlx5_wq_cyc_get_size(wq), wq->cur_sz, ix, len);
> print_hex_dump(KERN_WARNING, "", DUMP_PREFIX_OFFSET, 16, 1, wqe, len, false);
> }
One might expect these 2 outputs to be at the same KERN_<LEVEL> too.
One is KERN_INFO the other KERN_WARNING
next prev parent reply other threads:[~2019-12-20 2:07 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-12-20 0:15 [PATCH] net/mlx5e: Fix printk format warning Olof Johansson
2019-12-20 2:06 ` Joe Perches [this message]
2019-12-21 21:19 ` Olof Johansson
2019-12-31 4:35 ` Saeed Mahameed
2020-01-21 3:20 ` Olof Johansson
2020-01-21 20:43 ` Saeed Mahameed
2020-01-22 16:36 ` Olof Johansson
2020-01-22 18:51 ` Saeed Mahameed
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=ff6dc8997083c5d8968df48cc191e5b9e8797618.camel@perches.com \
--to=joe@perches.com \
--cc=leon@kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-rdma@vger.kernel.org \
--cc=netdev@vger.kernel.org \
--cc=olof@lixom.net \
--cc=saeedm@mellanox.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).