From: "Jonathan Lemon" <jonathan.lemon@gmail.com>
To: "Maxim Mikityanskiy" <maximmi@mellanox.com>
Cc: netdev@vger.kernel.org, bjorn.topel@intel.com,
magnus.karlsson@intel.com, jakub.kicinski@netronome.com,
jeffrey.t.kirsher@intel.com, kernel-team@fb.com
Subject: Re: [PATCH 2/3 bpf-next] i40e: Support zero-copy XDP_TX on the RX path for AF_XDP sockets.
Date: Tue, 02 Jul 2019 09:31:00 -0700 [thread overview]
Message-ID: <042416A5-BA37-4F07-BD59-7FA13813B8A7@gmail.com> (raw)
In-Reply-To: <f9c7b86c-91a6-9585-d1f1-f6f325794038@mellanox.com>
On 2 Jul 2019, at 0:07, Maxim Mikityanskiy wrote:
> On 2019-06-29 01:15, Jonathan Lemon wrote:
>> + xdpf = convert_to_xdp_frame_keep_zc(xdp);
>> + if (unlikely(!xdpf))
>> + return I40E_XDP_CONSUMED;
>> + xdpf->handle = xdp->handle;
>
> Shouldn't this line belong to convert_to_xdp_frame_keep_zc (and the
> previous patch)? It looks like it's code common for all drivers, and
> also patch 1 adds the handle field, but doesn't use it, which looks weird.
Good point. I'll move it into the function.
--
Jonathan
next prev parent reply other threads:[~2019-07-02 16:31 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-06-28 22:15 [PATCH 0/3 bpf-next] intel: AF_XDP support for TX of RX packets Jonathan Lemon
2019-06-28 22:15 ` [PATCH 1/3 bpf-next] net: add convert_to_xdp_frame_keep_zc function Jonathan Lemon
2019-07-01 11:02 ` Magnus Karlsson
2019-06-28 22:15 ` [PATCH 2/3 bpf-next] i40e: Support zero-copy XDP_TX on the RX path for AF_XDP sockets Jonathan Lemon
2019-07-01 11:04 ` Magnus Karlsson
2019-07-02 16:44 ` Jonathan Lemon
2019-07-02 7:07 ` Maxim Mikityanskiy
2019-07-02 16:31 ` Jonathan Lemon [this message]
2019-06-28 22:15 ` [PATCH 3/3 bpf-next] ixgbe: " Jonathan Lemon
2019-07-01 11:01 ` [PATCH 0/3 bpf-next] intel: AF_XDP support for TX of RX packets Magnus Karlsson
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=042416A5-BA37-4F07-BD59-7FA13813B8A7@gmail.com \
--to=jonathan.lemon@gmail.com \
--cc=bjorn.topel@intel.com \
--cc=jakub.kicinski@netronome.com \
--cc=jeffrey.t.kirsher@intel.com \
--cc=kernel-team@fb.com \
--cc=magnus.karlsson@intel.com \
--cc=maximmi@mellanox.com \
--cc=netdev@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).