From: Edward Cree <ecree@solarflare.com>
To: Jakub Kicinski <kuba@kernel.org>
Cc: <linux-net-drivers@solarflare.com>, <davem@davemloft.net>,
<netdev@vger.kernel.org>
Subject: Re: [PATCH net-next 2/8] sfc: make capability checking a nic_type function
Date: Tue, 12 May 2020 14:01:24 +0100 [thread overview]
Message-ID: <05438101-2706-e791-abd3-e52694fdfe9c@solarflare.com> (raw)
In-Reply-To: <20200511153636.0f9cd385@kicinski-fedora-pc1c0hjn.dhcp.thefacebook.com>
On 11/05/2020 23:36, Jakub Kicinski wrote:
> Also with W=1:
>
> ../drivers/net/ethernet/sfc/siena.c:951:14: warning: symbol 'siena_check_caps' was not declared. Should it be static?
> 1a3,5
> ../drivers/net/ethernet/sfc/siena.c:951:14: warning: no previous prototype for ‘siena_check_caps’ [-Wmissing-prototypes]
> 951 | unsigned int siena_check_caps(const struct efx_nic *efx,
> | ^~~~~~~~~~~~~~~~
Yup, it turns out not only is this missing 'static' but it's also not
used — the assignment into siena_a0_nic_typeis missing, I must have
screwed up a rebase at some point. I'll send a follow-up, since Dave
has already applied it. Thanks for the review.
(And I'll try to get in the habit of checking the SOBs better; sorry
about that. I'm still used to the old "first sign-off is the point
of exit from the company" flow; plus I messed up my checkpatch
invocation in a way that prevented it catching this.)
-ed
next prev parent reply other threads:[~2020-05-12 13:01 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-05-11 12:23 [PATCH net-next 0/8] sfc: remove nic_data usage in common code Edward Cree
2020-05-11 12:28 ` [PATCH net-next 1/8] sfc: move vport_id to struct efx_nic Edward Cree
2020-05-11 12:28 ` [PATCH net-next 2/8] sfc: make capability checking a nic_type function Edward Cree
2020-05-11 22:36 ` Jakub Kicinski
2020-05-12 13:01 ` Edward Cree [this message]
2020-05-12 1:01 ` kbuild test robot
2020-05-12 1:01 ` [RFC PATCH] sfc: siena_check_caps() can be static kbuild test robot
2020-05-11 12:28 ` [PATCH net-next 3/8] sfc: use efx_has_cap for capability checks outside of NIC-specific code Edward Cree
2020-05-11 12:29 ` [PATCH net-next 4/8] sfc: move 'must restore' flags out of ef10-specific nic_data Edward Cree
2020-05-11 12:29 ` [PATCH net-next 5/8] sfc: rework handling of (firmware) multicast chaining state Edward Cree
2020-05-11 12:29 ` [PATCH net-next 6/8] sfc: move rx_rss_context_exclusive into struct efx_mcdi_filter_table Edward Cree
2020-05-11 12:29 ` [PATCH net-next 7/8] sfc: make filter table probe caller responsible for adding VLANs Edward Cree
2020-05-11 12:30 ` [PATCH net-next 8/8] sfc: make firmware-variant printing a nic_type function Edward Cree
2020-05-11 20:32 ` [PATCH net-next 0/8] sfc: remove nic_data usage in common code David Miller
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=05438101-2706-e791-abd3-e52694fdfe9c@solarflare.com \
--to=ecree@solarflare.com \
--cc=davem@davemloft.net \
--cc=kuba@kernel.org \
--cc=linux-net-drivers@solarflare.com \
--cc=netdev@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).