netdev.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Edward Cree <ecree@solarflare.com>
To: <linux-net-drivers@solarflare.com>, <davem@davemloft.net>
Cc: <netdev@vger.kernel.org>
Subject: [PATCH net-next 0/8] sfc: remove nic_data usage in common code
Date: Mon, 11 May 2020 13:23:55 +0100	[thread overview]
Message-ID: <8154dba6-b312-7dcf-7d49-cd6c6801ffc2@solarflare.com> (raw)

efx->nic_data should only be used from NIC-specific code (i.e. nic_type
 functions and things they call), in files like ef10[_sriov].c and
 siena.c.  This series refactors several nic_data usages from common
 code (mainly in mcdi_filters.c) into nic_type functions, in preparation
 for the upcoming ef100 driver which will use those functions but have
 its own struct layout for efx->nic_data distinct from ef10's.
After this series, one nic_data usage (in ptp.c) remains; it wasn't
 clear to me how to fix it, and ef100 devices don't yet have PTP support
 (so the initial ef100 driver will not call that code).

Edward Cree (7):
  sfc: move vport_id to struct efx_nic
  sfc: use efx_has_cap for capability checks outside of NIC-specific
    code
  sfc: move 'must restore' flags out of ef10-specific nic_data
  sfc: rework handling of (firmware) multicast chaining state
  sfc: move rx_rss_context_exclusive into struct efx_mcdi_filter_table
  sfc: make filter table probe caller responsible for adding VLANs
  sfc: make firmware-variant printing a nic_type function

Tom Zhao (1):
  sfc: make capability checking a nic_type function

 drivers/net/ethernet/sfc/ef10.c           | 214 +++++++++++++---------
 drivers/net/ethernet/sfc/ef10_sriov.c     |  27 ++-
 drivers/net/ethernet/sfc/mcdi.c           |  25 +--
 drivers/net/ethernet/sfc/mcdi.h           |  12 ++
 drivers/net/ethernet/sfc/mcdi_filters.c   |  79 ++++----
 drivers/net/ethernet/sfc/mcdi_filters.h   |  17 +-
 drivers/net/ethernet/sfc/mcdi_functions.c |   8 +-
 drivers/net/ethernet/sfc/mcdi_port.c      |   7 +-
 drivers/net/ethernet/sfc/net_driver.h     |  10 +
 drivers/net/ethernet/sfc/nic.h            |  11 --
 drivers/net/ethernet/sfc/ptp.c            |   7 +-
 drivers/net/ethernet/sfc/siena.c          |   7 +
 12 files changed, 238 insertions(+), 186 deletions(-)


             reply	other threads:[~2020-05-11 12:24 UTC|newest]

Thread overview: 14+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2020-05-11 12:23 Edward Cree [this message]
2020-05-11 12:28 ` [PATCH net-next 1/8] sfc: move vport_id to struct efx_nic Edward Cree
2020-05-11 12:28 ` [PATCH net-next 2/8] sfc: make capability checking a nic_type function Edward Cree
2020-05-11 22:36   ` Jakub Kicinski
2020-05-12 13:01     ` Edward Cree
2020-05-12  1:01   ` kbuild test robot
2020-05-12  1:01   ` [RFC PATCH] sfc: siena_check_caps() can be static kbuild test robot
2020-05-11 12:28 ` [PATCH net-next 3/8] sfc: use efx_has_cap for capability checks outside of NIC-specific code Edward Cree
2020-05-11 12:29 ` [PATCH net-next 4/8] sfc: move 'must restore' flags out of ef10-specific nic_data Edward Cree
2020-05-11 12:29 ` [PATCH net-next 5/8] sfc: rework handling of (firmware) multicast chaining state Edward Cree
2020-05-11 12:29 ` [PATCH net-next 6/8] sfc: move rx_rss_context_exclusive into struct efx_mcdi_filter_table Edward Cree
2020-05-11 12:29 ` [PATCH net-next 7/8] sfc: make filter table probe caller responsible for adding VLANs Edward Cree
2020-05-11 12:30 ` [PATCH net-next 8/8] sfc: make firmware-variant printing a nic_type function Edward Cree
2020-05-11 20:32 ` [PATCH net-next 0/8] sfc: remove nic_data usage in common code David Miller

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=8154dba6-b312-7dcf-7d49-cd6c6801ffc2@solarflare.com \
    --to=ecree@solarflare.com \
    --cc=davem@davemloft.net \
    --cc=linux-net-drivers@solarflare.com \
    --cc=netdev@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).