From: "Alvin Šipraga" <ALSI@bang-olufsen.dk>
To: Linus Walleij <linus.walleij@linaro.org>,
Andrew Lunn <andrew@lunn.ch>,
Vivien Didelot <vivien.didelot@gmail.com>,
Florian Fainelli <f.fainelli@gmail.com>,
Vladimir Oltean <olteanv@gmail.com>,
"David S . Miller" <davem@davemloft.net>,
Jakub Kicinski <kuba@kernel.org>
Cc: "netdev@vger.kernel.org" <netdev@vger.kernel.org>,
Mauri Sandberg <sandberg@mailfence.com>,
DENG Qingfang <dqfext@gmail.com>
Subject: Re: [PATCH net-next 6/6 v6] net: dsa: rtl8366: Drop and depromote pointless prints
Date: Sat, 25 Sep 2021 17:19:10 +0000 [thread overview]
Message-ID: <05c9283a-d7f7-b3ef-af3d-c750eecc7b98@bang-olufsen.dk> (raw)
In-Reply-To: <20210925132311.2040272-7-linus.walleij@linaro.org>
On 9/25/21 3:23 PM, Linus Walleij wrote:
> We don't need a message for every VLAN association, dbg
> is fine. The message about adding the DSA or CPU
> port to a VLAN is directly misleading, this is perfectly
> fine.
>
> Cc: Vladimir Oltean <olteanv@gmail.com>
> Cc: Mauri Sandberg <sandberg@mailfence.com>
> Cc: Alvin Šipraga <alsi@bang-olufsen.dk>
> Cc: DENG Qingfang <dqfext@gmail.com>
> Reviewed-by: Florian Fainelli <f.fainelli@gmail.com>
> Signed-off-by: Linus Walleij <linus.walleij@linaro.org>
> ---
Reviewed-by: Alvin Šipraga <alsi@bang-olufsen.dk>
> ChangeLog v5->v6:
> - No changes just resending with the rest of the
> patches.
> ChangeLog v4->v5:
> - Collect Florians review tag.
> ChangeLog v1->v4:
> - New patch to deal with confusing messages and too talkative
> DSA bridge.
> ---
> drivers/net/dsa/rtl8366.c | 11 ++++-------
> 1 file changed, 4 insertions(+), 7 deletions(-)
>
> diff --git a/drivers/net/dsa/rtl8366.c b/drivers/net/dsa/rtl8366.c
> index f815cd16ad48..bb6189aedcd4 100644
> --- a/drivers/net/dsa/rtl8366.c
> +++ b/drivers/net/dsa/rtl8366.c
> @@ -318,12 +318,9 @@ int rtl8366_vlan_add(struct dsa_switch *ds, int port,
> return ret;
> }
>
> - dev_info(smi->dev, "add VLAN %d on port %d, %s, %s\n",
> - vlan->vid, port, untagged ? "untagged" : "tagged",
> - pvid ? " PVID" : "no PVID");
> -
> - if (dsa_is_dsa_port(ds, port) || dsa_is_cpu_port(ds, port))
> - dev_err(smi->dev, "port is DSA or CPU port\n");
> + dev_dbg(smi->dev, "add VLAN %d on port %d, %s, %s\n",
> + vlan->vid, port, untagged ? "untagged" : "tagged",
> + pvid ? " PVID" : "no PVID");
s/" PVID"/"PVID"/
>
> member |= BIT(port);
>
> @@ -356,7 +353,7 @@ int rtl8366_vlan_del(struct dsa_switch *ds, int port,
> struct realtek_smi *smi = ds->priv;
> int ret, i;
>
> - dev_info(smi->dev, "del VLAN %04x on port %d\n", vlan->vid, port);
> + dev_dbg(smi->dev, "del VLAN %d on port %d\n", vlan->vid, port);
>
> for (i = 0; i < smi->num_vlan_mc; i++) {
> struct rtl8366_vlan_mc vlanmc;
>
next prev parent reply other threads:[~2021-09-25 17:19 UTC|newest]
Thread overview: 19+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-09-25 13:23 [PATCH net-next 0/6 v6] RTL8366(RB) cleanups part 1 Linus Walleij
2021-09-25 13:23 ` [PATCH net-next 1/6 v6] net: dsa: rtl8366rb: Support bridge offloading Linus Walleij
2021-09-25 18:30 ` Vladimir Oltean
2021-09-25 13:23 ` [PATCH net-next 2/6 v6] net: dsa: rtl8366: Drop custom VLAN set-up Linus Walleij
2021-09-25 13:23 ` [PATCH net-next 3/6 v6] net: dsa: rtl8366rb: Rewrite weird VLAN filering enablement Linus Walleij
2021-09-25 17:12 ` Alvin Šipraga
2021-09-25 18:38 ` Vladimir Oltean
2021-09-25 22:44 ` Linus Walleij
2021-09-25 13:23 ` [PATCH net-next 4/6 v6] net: dsa: rtl8366rb: Fix off-by-one bug Linus Walleij
2021-09-25 17:16 ` Alvin Šipraga
2021-09-25 18:44 ` Vladimir Oltean
2021-09-26 2:32 ` Florian Fainelli
2021-09-25 13:23 ` [PATCH net-next 5/6 v6] net: dsa: rtl8366: Fix a bug in deleting VLANs Linus Walleij
2021-09-25 17:18 ` Alvin Šipraga
2021-09-25 18:50 ` Vladimir Oltean
2021-09-25 13:23 ` [PATCH net-next 6/6 v6] net: dsa: rtl8366: Drop and depromote pointless prints Linus Walleij
2021-09-25 17:19 ` Alvin Šipraga [this message]
2021-09-25 18:56 ` Vladimir Oltean
2021-09-25 22:54 ` Linus Walleij
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=05c9283a-d7f7-b3ef-af3d-c750eecc7b98@bang-olufsen.dk \
--to=alsi@bang-olufsen.dk \
--cc=andrew@lunn.ch \
--cc=davem@davemloft.net \
--cc=dqfext@gmail.com \
--cc=f.fainelli@gmail.com \
--cc=kuba@kernel.org \
--cc=linus.walleij@linaro.org \
--cc=netdev@vger.kernel.org \
--cc=olteanv@gmail.com \
--cc=sandberg@mailfence.com \
--cc=vivien.didelot@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).