From: Vladimir Oltean <olteanv@gmail.com>
To: "Alvin Šipraga" <ALSI@bang-olufsen.dk>
Cc: Linus Walleij <linus.walleij@linaro.org>,
Andrew Lunn <andrew@lunn.ch>,
Vivien Didelot <vivien.didelot@gmail.com>,
Florian Fainelli <f.fainelli@gmail.com>,
"David S . Miller" <davem@davemloft.net>,
Jakub Kicinski <kuba@kernel.org>,
"netdev@vger.kernel.org" <netdev@vger.kernel.org>,
Mauri Sandberg <sandberg@mailfence.com>,
DENG Qingfang <dqfext@gmail.com>
Subject: Re: [PATCH net-next 3/6 v6] net: dsa: rtl8366rb: Rewrite weird VLAN filering enablement
Date: Sat, 25 Sep 2021 21:38:11 +0300 [thread overview]
Message-ID: <20210925183811.jsq2qps257jeqgmf@skbuf> (raw)
In-Reply-To: <a4c7ffae-b99a-00ee-6de3-8c7e40ecd286@bang-olufsen.dk>
On Sat, Sep 25, 2021 at 05:12:24PM +0000, Alvin Šipraga wrote:
> From the previous version of this patch I understood that CTRL1_REG is
> for controlling whether or not to accept untagged frames, and CTRL2 for
> accepting tagged frames that don't match the port member set. Is that
> correct?
It might not hurt to add comments which explain what these registers do.
> Do you know whether DSA _always_ wants ports to accept untagged frames,
> or only if the port has PVID set? I'm also asking for my own
> understanding. In the latter case I think you might have to set CTRL1 in
> rtl8366rb_vlan_filtering() (depending on whether the port has a PVID),
> as well as whenever a PVID is set or unset. Of course it depends on the
> switch semantics - maybe it ignores CTRL1(port) == 1 if the port has a
> PVID, in which case your previous version of the patch would be OK.
Documentation/networking/switchdev.rst says:
When the bridge has VLAN filtering enabled and a PVID is not configured on the
ingress port, untagged and 802.1p tagged packets must be dropped. When the bridge
has VLAN filtering enabled and a PVID exists on the ingress port, untagged and
priority-tagged packets must be accepted and forwarded according to the
bridge's port membership of the PVID VLAN. When the bridge has VLAN filtering
disabled, the presence/lack of a PVID should not influence the packet
forwarding decision.
Anyway, I suppose Linus can make that adjustment after the fact too, if
everything else is ok in the other patches.
next prev parent reply other threads:[~2021-09-25 18:38 UTC|newest]
Thread overview: 19+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-09-25 13:23 [PATCH net-next 0/6 v6] RTL8366(RB) cleanups part 1 Linus Walleij
2021-09-25 13:23 ` [PATCH net-next 1/6 v6] net: dsa: rtl8366rb: Support bridge offloading Linus Walleij
2021-09-25 18:30 ` Vladimir Oltean
2021-09-25 13:23 ` [PATCH net-next 2/6 v6] net: dsa: rtl8366: Drop custom VLAN set-up Linus Walleij
2021-09-25 13:23 ` [PATCH net-next 3/6 v6] net: dsa: rtl8366rb: Rewrite weird VLAN filering enablement Linus Walleij
2021-09-25 17:12 ` Alvin Šipraga
2021-09-25 18:38 ` Vladimir Oltean [this message]
2021-09-25 22:44 ` Linus Walleij
2021-09-25 13:23 ` [PATCH net-next 4/6 v6] net: dsa: rtl8366rb: Fix off-by-one bug Linus Walleij
2021-09-25 17:16 ` Alvin Šipraga
2021-09-25 18:44 ` Vladimir Oltean
2021-09-26 2:32 ` Florian Fainelli
2021-09-25 13:23 ` [PATCH net-next 5/6 v6] net: dsa: rtl8366: Fix a bug in deleting VLANs Linus Walleij
2021-09-25 17:18 ` Alvin Šipraga
2021-09-25 18:50 ` Vladimir Oltean
2021-09-25 13:23 ` [PATCH net-next 6/6 v6] net: dsa: rtl8366: Drop and depromote pointless prints Linus Walleij
2021-09-25 17:19 ` Alvin Šipraga
2021-09-25 18:56 ` Vladimir Oltean
2021-09-25 22:54 ` Linus Walleij
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20210925183811.jsq2qps257jeqgmf@skbuf \
--to=olteanv@gmail.com \
--cc=ALSI@bang-olufsen.dk \
--cc=andrew@lunn.ch \
--cc=davem@davemloft.net \
--cc=dqfext@gmail.com \
--cc=f.fainelli@gmail.com \
--cc=kuba@kernel.org \
--cc=linus.walleij@linaro.org \
--cc=netdev@vger.kernel.org \
--cc=sandberg@mailfence.com \
--cc=vivien.didelot@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).