netdev.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Christopher Talbot <chris@talbothome.com>
To: netdev@vger.kernel.org
Subject: [PATCH 2/9] Ensure Compatibility with Telus Canada
Date: Fri, 26 Mar 2021 06:50:04 -0400	[thread overview]
Message-ID: <082ccadaf9654e1580540e73cc8defc522d97b2d.camel@talbothome.com> (raw)


mmsd decodes a header that is not in the standard.
This patch allows this header to be decoded
---
 src/mmsutil.c | 16 ++++++++++++----
 1 file changed, 12 insertions(+), 4 deletions(-)

diff --git a/src/mmsutil.c b/src/mmsutil.c
index 5fcf358..9430bf1 100644
--- a/src/mmsutil.c
+++ b/src/mmsutil.c
@@ -732,10 +732,9 @@ static header_handler handler_for_type(enum
mms_header header)
                return extract_text;
        case MMS_HEADER_INVALID:
        case __MMS_HEADER_MAX:
+       default:
                return NULL;
        }
-
-       return NULL;
 }
 
 struct header_handler_entry {
@@ -781,8 +780,17 @@ static gboolean mms_parse_headers(struct
wsp_header_iter *iter,
 
                handler = handler_for_type(h);
                if (handler == NULL) {
-                       DBG("no handler for type %u", h);
-                       return FALSE;
+                       if(h == MMS_HEADER_INVALID) {
+                               DBG("no handler for type %u", h);
+                               return FALSE;
+                       } else if (h == __MMS_HEADER_MAX) {
+                               DBG("no handler for type %u", h);
+                               return FALSE;
+                       } else {
+                               /*  Telus has strange headers, so this
handles it */
+                               DBG("type isn't a part of the standard?
Skipping %u", h);
+                               continue;
+                       }
                }
 
                DBG("saw header of type %u", h);
-- 
2.30.0


             reply	other threads:[~2021-03-26 10:50 UTC|newest]

Thread overview: 2+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2021-03-26 10:50 Christopher Talbot [this message]
2021-04-10 14:13 [PATCH 0/9] Updates for mmsd Chris Talbot
2021-04-10 14:17 ` [PATCH 1/9] Fix mmsd to work with T-mobile Chris Talbot
2021-04-10 14:20   ` [PATCH 2/9] Ensure Compatibility with Telus Canada Chris Talbot

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=082ccadaf9654e1580540e73cc8defc522d97b2d.camel@talbothome.com \
    --to=chris@talbothome.com \
    --cc=netdev@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).