netdev.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Chris Talbot <chris@talbothome.com>
To: ofono@ofono.org, netdev@vger.kernel.org,
	debian-on-mobile-maintainers@alioth-lists.debian.net,
	librem-5-dev@lists.community.puri.sm
Subject: [PATCH 2/9] Ensure Compatibility with Telus Canada
Date: Sat, 10 Apr 2021 10:20:19 -0400	[thread overview]
Message-ID: <df512b811ee2df6b8f55dd2a9fb0178e6e5c490f.camel@talbothome.com> (raw)
In-Reply-To: <b23ba0656ea0d58fdbd8c83072e017f63629f934.camel@talbothome.com>

Telus Canada makes mmsd decode a header that is not in the standard.
This patch allows this header to be decoded and allows for MMS support
in Telus Canada.
---
 src/mmsutil.c | 16 ++++++++++++----
 1 file changed, 12 insertions(+), 4 deletions(-)

diff --git a/src/mmsutil.c b/src/mmsutil.c
index 5fcf358..9430bf1 100644
--- a/src/mmsutil.c
+++ b/src/mmsutil.c
@@ -732,10 +732,9 @@ static header_handler handler_for_type(enum
mms_header header)
 		return extract_text;
 	case MMS_HEADER_INVALID:
 	case __MMS_HEADER_MAX:
+	default:
 		return NULL;
 	}
-
-	return NULL;
 }
 
 struct header_handler_entry {
@@ -781,8 +780,17 @@ static gboolean mms_parse_headers(struct
wsp_header_iter *iter,
 
 		handler = handler_for_type(h);
 		if (handler == NULL) {
-			DBG("no handler for type %u", h);
-			return FALSE;
+			if(h == MMS_HEADER_INVALID) {
+				DBG("no handler for type %u", h);
+				return FALSE;
+			} else if (h == __MMS_HEADER_MAX) {
+				DBG("no handler for type %u", h);
+				return FALSE;
+			} else {
+				/*  Telus has strange headers, so this
handles it */
+				DBG("type isn't a part of the
standard? Skipping %u", h);
+				continue;
+			}
 		}
 
 		DBG("saw header of type %u", h);
-- 
2.30.2


  reply	other threads:[~2021-04-10 14:20 UTC|newest]

Thread overview: 20+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2021-04-10 14:13 [PATCH 0/9] Updates for mmsd Chris Talbot
2021-04-10 14:17 ` [PATCH 1/9] Fix mmsd to work with T-mobile Chris Talbot
2021-04-10 14:20   ` Chris Talbot [this message]
2021-04-10 14:20     ` [PATCH 3/9] Ensure Compatibility with AT&T Chris Talbot
2021-04-10 14:21       ` [PATCH 4/9] Fix issue if there is an empty string in encoded text Chris Talbot
2021-04-10 14:22         ` [PATCH 5/9] Allow for a user configurable maximum attachment size Chris Talbot
2021-04-10 14:22           ` [PATCH 6/9] Update README Chris Talbot
2021-04-10 14:23             ` [PATCH 7/9] Fix Draft and Sent Bugs Chris Talbot
2021-04-10 14:23               ` [PATCH 8/9] Allow Maintainer mode to compile without -WError Chris Talbot
2021-04-10 14:24                 ` [PATCH 9/9] Enable support for Modem Manager Chris Talbot
2021-04-14 18:21 ` Forking on MMSD Chris Talbot
2021-04-14 18:30   ` [Debian-on-mobile-maintainers] " Guido Günther
2021-04-14 18:46     ` Chris Talbot
2021-04-15  9:10       ` Guido Günther
2021-04-14 18:39   ` Marius Gripsgard
2021-04-14 22:09     ` Bug#985893: " Wookey
2021-04-15  0:12       ` Chris Talbot
2021-04-14 19:29   ` Pavel Machek
2021-04-14 21:11     ` Bug#985893: " Paul Wise
  -- strict thread matches above, loose matches on Subject: below --
2021-03-26 10:50 [PATCH 2/9] Ensure Compatibility with Telus Canada Christopher Talbot

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=df512b811ee2df6b8f55dd2a9fb0178e6e5c490f.camel@talbothome.com \
    --to=chris@talbothome.com \
    --cc=debian-on-mobile-maintainers@alioth-lists.debian.net \
    --cc=librem-5-dev@lists.community.puri.sm \
    --cc=netdev@vger.kernel.org \
    --cc=ofono@ofono.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).