From: James Chapman <jchapman@katalix.com>
To: Tom Parkin <tparkin@katalix.com>, netdev@vger.kernel.org
Subject: Re: [PATCH v2 net-next 00/10] l2tp: cleanup checkpatch.pl warnings
Date: Wed, 22 Jul 2020 19:31:28 +0100 [thread overview]
Message-ID: <0896e429-d7fe-8205-aec3-83b4b658979e@katalix.com> (raw)
In-Reply-To: <20200722163214.7920-1-tparkin@katalix.com>
On 22/07/2020 17:32, Tom Parkin wrote:
> l2tp hasn't been kept up to date with the static analysis checks offered
> by checkpatch.pl.
>
> This series addresses a range of minor issues which don't involve large
> changes to code structure. The changes include:
>
> * tweaks to use of whitespace, comment style, line breaks,
> and indentation
>
> * two minor modifications to code to use a function or macro suggested
> by checkpatch
>
> v1 -> v2
>
> * combine related patches (patches fixing whitespace issues, patches
> addressing comment style)
>
> * respin the single large patchset into a multiple smaller series for
> easier review
>
> Tom Parkin (10):
> l2tp: cleanup whitespace use
> l2tp: cleanup comments
> l2tp: cleanup difficult-to-read line breaks
> l2tp: cleanup wonky alignment of line-broken function calls
> l2tp: cleanup suspect code indent
> l2tp: add identifier name in function pointer prototype
> l2tp: prefer using BIT macro
> l2tp: prefer seq_puts for unformatted output
> l2tp: line-break long function prototypes
> l2tp: avoid precidence issues in L2TP_SKB_CB macro
>
> net/l2tp/l2tp_core.c | 69 +++++++++++++++++-----------------
> net/l2tp/l2tp_core.h | 82 +++++++++++++++++------------------------
> net/l2tp/l2tp_debugfs.c | 11 ++----
> net/l2tp/l2tp_eth.c | 19 ++++------
> net/l2tp/l2tp_ip.c | 17 +++++----
> net/l2tp/l2tp_ip6.c | 29 +++++++--------
> net/l2tp/l2tp_netlink.c | 75 ++++++++++++++++---------------------
> net/l2tp/l2tp_ppp.c | 20 +++++-----
> 8 files changed, 145 insertions(+), 177 deletions(-)
>
Reviewed-by: James Chapman <jchapman@katalix.com>
next prev parent reply other threads:[~2020-07-22 18:31 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-07-22 16:32 [PATCH v2 net-next 00/10] l2tp: cleanup checkpatch.pl warnings Tom Parkin
2020-07-22 16:32 ` [PATCH 01/10] l2tp: cleanup whitespace use Tom Parkin
2020-07-22 16:32 ` [PATCH 02/10] l2tp: cleanup comments Tom Parkin
2020-07-22 16:32 ` [PATCH 03/10] l2tp: cleanup difficult-to-read line breaks Tom Parkin
2020-07-22 16:32 ` [PATCH 04/10] l2tp: cleanup wonky alignment of line-broken function calls Tom Parkin
2020-07-22 16:32 ` [PATCH 05/10] l2tp: cleanup suspect code indent Tom Parkin
2020-07-22 16:32 ` [PATCH 06/10] l2tp: add identifier name in function pointer prototype Tom Parkin
2020-07-22 16:32 ` [PATCH 07/10] l2tp: prefer using BIT macro Tom Parkin
2020-07-22 16:32 ` [PATCH 08/10] l2tp: prefer seq_puts for unformatted output Tom Parkin
2020-07-22 16:32 ` [PATCH 09/10] l2tp: line-break long function prototypes Tom Parkin
2020-07-22 16:32 ` [PATCH 10/10] l2tp: avoid precidence issues in L2TP_SKB_CB macro Tom Parkin
2020-07-22 18:31 ` James Chapman [this message]
2020-07-23 1:08 ` [PATCH v2 net-next 00/10] l2tp: cleanup checkpatch.pl warnings David Miller
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=0896e429-d7fe-8205-aec3-83b4b658979e@katalix.com \
--to=jchapman@katalix.com \
--cc=netdev@vger.kernel.org \
--cc=tparkin@katalix.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).