From: Tom Parkin <tparkin@katalix.com>
To: netdev@vger.kernel.org
Cc: jchapman@katalix.com, Tom Parkin <tparkin@katalix.com>
Subject: [PATCH 08/10] l2tp: prefer seq_puts for unformatted output
Date: Wed, 22 Jul 2020 17:32:12 +0100 [thread overview]
Message-ID: <20200722163214.7920-9-tparkin@katalix.com> (raw)
In-Reply-To: <20200722163214.7920-1-tparkin@katalix.com>
checkpatch warns about use of seq_printf where seq_puts would do.
Modify l2tp_debugfs accordingly.
Signed-off-by: Tom Parkin <tparkin@katalix.com>
---
net/l2tp/l2tp_debugfs.c | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/net/l2tp/l2tp_debugfs.c b/net/l2tp/l2tp_debugfs.c
index bea89c383b7d..ebe03bbb5948 100644
--- a/net/l2tp/l2tp_debugfs.c
+++ b/net/l2tp/l2tp_debugfs.c
@@ -199,7 +199,7 @@ static void l2tp_dfs_seq_session_show(struct seq_file *m, void *v)
seq_printf(m, "%02x%02x%02x%02x",
session->cookie[4], session->cookie[5],
session->cookie[6], session->cookie[7]);
- seq_printf(m, "\n");
+ seq_puts(m, "\n");
}
if (session->peer_cookie_len) {
seq_printf(m, " peer cookie %02x%02x%02x%02x",
@@ -209,7 +209,7 @@ static void l2tp_dfs_seq_session_show(struct seq_file *m, void *v)
seq_printf(m, "%02x%02x%02x%02x",
session->peer_cookie[4], session->peer_cookie[5],
session->peer_cookie[6], session->peer_cookie[7]);
- seq_printf(m, "\n");
+ seq_puts(m, "\n");
}
seq_printf(m, " %hu/%hu tx %ld/%ld/%ld rx %ld/%ld/%ld\n",
--
2.17.1
next prev parent reply other threads:[~2020-07-22 16:32 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-07-22 16:32 [PATCH v2 net-next 00/10] l2tp: cleanup checkpatch.pl warnings Tom Parkin
2020-07-22 16:32 ` [PATCH 01/10] l2tp: cleanup whitespace use Tom Parkin
2020-07-22 16:32 ` [PATCH 02/10] l2tp: cleanup comments Tom Parkin
2020-07-22 16:32 ` [PATCH 03/10] l2tp: cleanup difficult-to-read line breaks Tom Parkin
2020-07-22 16:32 ` [PATCH 04/10] l2tp: cleanup wonky alignment of line-broken function calls Tom Parkin
2020-07-22 16:32 ` [PATCH 05/10] l2tp: cleanup suspect code indent Tom Parkin
2020-07-22 16:32 ` [PATCH 06/10] l2tp: add identifier name in function pointer prototype Tom Parkin
2020-07-22 16:32 ` [PATCH 07/10] l2tp: prefer using BIT macro Tom Parkin
2020-07-22 16:32 ` Tom Parkin [this message]
2020-07-22 16:32 ` [PATCH 09/10] l2tp: line-break long function prototypes Tom Parkin
2020-07-22 16:32 ` [PATCH 10/10] l2tp: avoid precidence issues in L2TP_SKB_CB macro Tom Parkin
2020-07-22 18:31 ` [PATCH v2 net-next 00/10] l2tp: cleanup checkpatch.pl warnings James Chapman
2020-07-23 1:08 ` David Miller
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20200722163214.7920-9-tparkin@katalix.com \
--to=tparkin@katalix.com \
--cc=jchapman@katalix.com \
--cc=netdev@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).