From: Denys Fedoryshchenko <denys@visp.net.lb>
To: David Miller <davem@davemloft.net>
Cc: eric.dumazet@gmail.com, amwang@redhat.com, david.ward@ll.mit.edu,
hayeswang@realtek.com, romieu@fr.zoreil.com,
netdev@vger.kernel.org
Subject: Re: [PATCH] net/802/mrp: fix lockdep splat
Date: Tue, 14 May 2013 23:01:45 +0300 [thread overview]
Message-ID: <0a30a716234b9f33d1623d778fd4292e@visp.net.lb> (raw)
In-Reply-To: <20130514.120754.1745967383330029903.davem@davemloft.net>
On 2013-05-14 22:07, David Miller wrote:
> From: Denys Fedoryshchenko <denys@visp.net.lb>
> Date: Mon, 13 May 2013 15:53:30 +0300
>
> Thank you for superfast answer :)
> It is changed a bit, but not disappeared. Relevant part from new
> dmesg:
>
> Can you double check that you really had Eric's patch applied?
> lockdep appears to be complaining about the same thing in your
> log dump, as if the patch was not really applied.
>
> It's saying that app->lock can be taken from the join timer in
> softirq, but mrp_uninit_applicant() takes it without disabling
> softirqs.
>
> Eric's patch explicitly fixes this, by making sure that spin_lock_bh()
> is used there.
I will reapply patch on clean kernel and try again.
---
Denys Fedoryshchenko, Network Engineer, Virtual ISP S.A.L.
next prev parent reply other threads:[~2013-05-14 20:01 UTC|newest]
Thread overview: 17+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-05-13 11:59 r8169 not working under latest kernels Denys Fedoryshchenko
2013-05-13 12:24 ` [PATCH] net/802/mrp: fix lockdep splat Eric Dumazet
2013-05-13 12:53 ` Denys Fedoryshchenko
2013-05-14 19:07 ` David Miller
2013-05-14 19:21 ` Eric Dumazet
2013-05-14 19:40 ` Eric Dumazet
2013-05-14 20:03 ` David Miller
2013-05-15 14:50 ` Denys Fedoryshchenko
2013-05-15 15:22 ` Eric Dumazet
2013-05-15 16:34 ` Ward, David - 0663 - MITLL
2013-05-15 16:41 ` Ward, David - 0663 - MITLL
2013-05-14 20:01 ` Denys Fedoryshchenko [this message]
2013-05-14 1:12 ` Cong Wang
2013-05-14 1:30 ` Eric Dumazet
2013-05-15 20:00 ` r8169 not working under latest kernels Denys Fedoryshchenko
2013-05-16 22:57 ` Francois Romieu
2013-05-17 8:15 ` Denys Fedoryshchenko
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=0a30a716234b9f33d1623d778fd4292e@visp.net.lb \
--to=denys@visp.net.lb \
--cc=amwang@redhat.com \
--cc=davem@davemloft.net \
--cc=david.ward@ll.mit.edu \
--cc=eric.dumazet@gmail.com \
--cc=hayeswang@realtek.com \
--cc=netdev@vger.kernel.org \
--cc=romieu@fr.zoreil.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).