netdev.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: "Ward, David - 0663 - MITLL" <david.ward@ll.mit.edu>
To: Eric Dumazet <eric.dumazet@gmail.com>
Cc: Denys Fedoryshchenko <denys@visp.net.lb>,
	David Miller <davem@davemloft.net>,
	"amwang@redhat.com" <amwang@redhat.com>,
	"hayeswang@realtek.com" <hayeswang@realtek.com>,
	"romieu@fr.zoreil.com" <romieu@fr.zoreil.com>,
	"netdev@vger.kernel.org" <netdev@vger.kernel.org>
Subject: Re: [PATCH] net/802/mrp: fix lockdep splat
Date: Wed, 15 May 2013 12:34:16 -0400	[thread overview]
Message-ID: <5193B908.4030407@ll.mit.edu> (raw)
In-Reply-To: <1368631325.4519.30.camel@edumazet-glaptop>

[-- Attachment #1: Type: text/plain, Size: 802 bytes --]

On 05/15/2013 11:22 AM, Eric Dumazet wrote:
> Re: [PATCH] net/802/mrp: fix lockdep splat
>
> On Wed, 2013-05-15 at 17:50 +0300, Denys Fedoryshchenko wrote:
> > On 2013-05-14 22:40, Eric Dumazet wrote:
> > >
> > > I definitely could trigger the bug easily without my patch :
> >
> >
> > >
> > > And with the patch, there is no lockdep splat anymore.
> > >
> > > Tested-by: Eric Dumazet <edumazet@google.com>
> >
> > Yes, it seems after depclean i cannot reproduce anymore this bug. My
> > bad, seems i should recompile kernel completely next time.
> >
>
> Thanks for testing again, I was quite mystified by your original
> results ;)
>

FYI - I believe GARP (net/802/garp.c) needs the same fix.  Thechange 
that introduced this issue was originally copied from there.

David


[-- Attachment #2: S/MIME Cryptographic Signature --]
[-- Type: application/pkcs7-signature, Size: 4571 bytes --]

  reply	other threads:[~2013-05-15 16:35 UTC|newest]

Thread overview: 17+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2013-05-13 11:59 r8169 not working under latest kernels Denys Fedoryshchenko
2013-05-13 12:24 ` [PATCH] net/802/mrp: fix lockdep splat Eric Dumazet
2013-05-13 12:53   ` Denys Fedoryshchenko
2013-05-14 19:07     ` David Miller
2013-05-14 19:21       ` Eric Dumazet
2013-05-14 19:40         ` Eric Dumazet
2013-05-14 20:03           ` David Miller
2013-05-15 14:50           ` Denys Fedoryshchenko
2013-05-15 15:22             ` Eric Dumazet
2013-05-15 16:34               ` Ward, David - 0663 - MITLL [this message]
2013-05-15 16:41                 ` Ward, David - 0663 - MITLL
2013-05-14 20:01       ` Denys Fedoryshchenko
2013-05-14  1:12   ` Cong Wang
2013-05-14  1:30     ` Eric Dumazet
2013-05-15 20:00 ` r8169 not working under latest kernels Denys Fedoryshchenko
2013-05-16 22:57   ` Francois Romieu
2013-05-17  8:15     ` Denys Fedoryshchenko

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=5193B908.4030407@ll.mit.edu \
    --to=david.ward@ll.mit.edu \
    --cc=amwang@redhat.com \
    --cc=davem@davemloft.net \
    --cc=denys@visp.net.lb \
    --cc=eric.dumazet@gmail.com \
    --cc=hayeswang@realtek.com \
    --cc=netdev@vger.kernel.org \
    --cc=romieu@fr.zoreil.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).