Netdev Archive on lore.kernel.org
 help / color / Atom feed
* [PATCH net-next] net/mlx5e: allow TSO on VXLAN over VLAN topologies
@ 2020-01-09 11:07 Davide Caratti
  2020-01-09 18:52 ` David Miller
  0 siblings, 1 reply; 3+ messages in thread
From: Davide Caratti @ 2020-01-09 11:07 UTC (permalink / raw)
  To: Saeed Mahameed; +Cc: David S. Miller, netdev

since mlx5 hardware can segment correctly TSO packets on VXLAN over VLAN
topologies, CPU usage can improve significantly if we enable tunnel
offloads in dev->vlan_features, like it was done in the past with other
NIC drivers (e.g. mlx4, be2net and ixgbe).

Signed-off-by: Davide Caratti <dcaratti@redhat.com>
---
 drivers/net/ethernet/mellanox/mlx5/core/en_main.c | 2 ++
 1 file changed, 2 insertions(+)

diff --git a/drivers/net/ethernet/mellanox/mlx5/core/en_main.c b/drivers/net/ethernet/mellanox/mlx5/core/en_main.c
index 78737fd42616..87267c18ff8c 100644
--- a/drivers/net/ethernet/mellanox/mlx5/core/en_main.c
+++ b/drivers/net/ethernet/mellanox/mlx5/core/en_main.c
@@ -4878,6 +4878,8 @@ static void mlx5e_build_nic_netdev(struct net_device *netdev)
 		netdev->hw_enc_features |= NETIF_F_GSO_UDP_TUNNEL |
 					   NETIF_F_GSO_UDP_TUNNEL_CSUM;
 		netdev->gso_partial_features = NETIF_F_GSO_UDP_TUNNEL_CSUM;
+		netdev->vlan_features |= NETIF_F_GSO_UDP_TUNNEL |
+					 NETIF_F_GSO_UDP_TUNNEL_CSUM;
 	}
 
 	if (mlx5e_tunnel_proto_supported(mdev, IPPROTO_GRE)) {
-- 
2.24.1


^ permalink raw reply	[flat|nested] 3+ messages in thread

* Re: [PATCH net-next] net/mlx5e: allow TSO on VXLAN over VLAN topologies
  2020-01-09 11:07 [PATCH net-next] net/mlx5e: allow TSO on VXLAN over VLAN topologies Davide Caratti
@ 2020-01-09 18:52 ` David Miller
  2020-01-14 20:33   ` Saeed Mahameed
  0 siblings, 1 reply; 3+ messages in thread
From: David Miller @ 2020-01-09 18:52 UTC (permalink / raw)
  To: dcaratti; +Cc: saeedm, netdev

From: Davide Caratti <dcaratti@redhat.com>
Date: Thu,  9 Jan 2020 12:07:59 +0100

> since mlx5 hardware can segment correctly TSO packets on VXLAN over VLAN
> topologies, CPU usage can improve significantly if we enable tunnel
> offloads in dev->vlan_features, like it was done in the past with other
> NIC drivers (e.g. mlx4, be2net and ixgbe).
> 
> Signed-off-by: Davide Caratti <dcaratti@redhat.com>

Saeed, I am assuming you will review and integrate this.

Thank you.

^ permalink raw reply	[flat|nested] 3+ messages in thread

* Re: [PATCH net-next] net/mlx5e: allow TSO on VXLAN over VLAN topologies
  2020-01-09 18:52 ` David Miller
@ 2020-01-14 20:33   ` Saeed Mahameed
  0 siblings, 0 replies; 3+ messages in thread
From: Saeed Mahameed @ 2020-01-14 20:33 UTC (permalink / raw)
  To: dcaratti, davem; +Cc: netdev

On Thu, 2020-01-09 at 10:52 -0800, David Miller wrote:
> From: Davide Caratti <dcaratti@redhat.com>
> Date: Thu,  9 Jan 2020 12:07:59 +0100
> 
> > since mlx5 hardware can segment correctly TSO packets on VXLAN over
> VLAN
> > topologies, CPU usage can improve significantly if we enable tunnel
> > offloads in dev->vlan_features, like it was done in the past with
> other
> > NIC drivers (e.g. mlx4, be2net and ixgbe).
> > 
> > Signed-off-by: Davide Caratti <dcaratti@redhat.com>
> 
> Saeed, I am assuming you will review and integrate this.
> 
> Thank you.

LGTM, applied to net-next-mlx5, will run some tests and provide
feedback if any issues will surface, while i don't expect any.

Will submit to net-next in one of my upcoming net-next pull requests.

Thanks,
Saeed.

^ permalink raw reply	[flat|nested] 3+ messages in thread

end of thread, back to index

Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2020-01-09 11:07 [PATCH net-next] net/mlx5e: allow TSO on VXLAN over VLAN topologies Davide Caratti
2020-01-09 18:52 ` David Miller
2020-01-14 20:33   ` Saeed Mahameed

Netdev Archive on lore.kernel.org

Archives are clonable:
	git clone --mirror https://lore.kernel.org/netdev/0 netdev/git/0.git
	git clone --mirror https://lore.kernel.org/netdev/1 netdev/git/1.git

	# If you have public-inbox 1.1+ installed, you may
	# initialize and index your mirror using the following commands:
	public-inbox-init -V2 netdev netdev/ https://lore.kernel.org/netdev \
		netdev@vger.kernel.org
	public-inbox-index netdev

Example config snippet for mirrors

Newsgroup available over NNTP:
	nntp://nntp.lore.kernel.org/org.kernel.vger.netdev


AGPL code for this site: git clone https://public-inbox.org/public-inbox.git