* [PATCH 0/2] net/phy/mdio-mscc-miim: Adjustments for mscc_miim_probe() @ 2019-09-20 19:00 Markus Elfring 2019-09-20 19:02 ` [PATCH 1/2] net/phy/mdio-mscc-miim: Use devm_platform_ioremap_resource() in mscc_miim_probe() Markus Elfring 2019-09-20 19:03 ` [PATCH 2/2] net/phy/mdio-mscc-miim: " Markus Elfring 0 siblings, 2 replies; 12+ messages in thread From: Markus Elfring @ 2019-09-20 19:00 UTC (permalink / raw) To: netdev, Alexandre Belloni, Andrew Lunn, Florian Fainelli, David S. Miller, Heiner Kallweit Cc: LKML, kernel-janitors From: Markus Elfring <elfring@users.sourceforge.net> Date: Fri, 20 Sep 2019 20:52:25 +0200 Two update suggestions were taken into account from static source code analysis. Markus Elfring (2): Use devm_platform_ioremap_resource() Move the setting of mii_bus structure members drivers/net/phy/mdio-mscc-miim.c | 31 +++++++++++-------------------- 1 file changed, 11 insertions(+), 20 deletions(-) -- 2.23.0 ^ permalink raw reply [flat|nested] 12+ messages in thread
* [PATCH 1/2] net/phy/mdio-mscc-miim: Use devm_platform_ioremap_resource() in mscc_miim_probe() 2019-09-20 19:00 [PATCH 0/2] net/phy/mdio-mscc-miim: Adjustments for mscc_miim_probe() Markus Elfring @ 2019-09-20 19:02 ` Markus Elfring 2019-09-20 19:09 ` Andrew Lunn 2019-09-20 19:03 ` [PATCH 2/2] net/phy/mdio-mscc-miim: " Markus Elfring 1 sibling, 1 reply; 12+ messages in thread From: Markus Elfring @ 2019-09-20 19:02 UTC (permalink / raw) To: netdev, Alexandre Belloni, Andrew Lunn, Florian Fainelli, David S. Miller, Heiner Kallweit Cc: LKML, kernel-janitors From: Markus Elfring <elfring@users.sourceforge.net> Date: Fri, 20 Sep 2019 20:20:34 +0200 Simplify this function implementation by using a known wrapper function. This issue was detected by using the Coccinelle software. Signed-off-by: Markus Elfring <elfring@users.sourceforge.net> --- drivers/net/phy/mdio-mscc-miim.c | 18 +++++------------- 1 file changed, 5 insertions(+), 13 deletions(-) diff --git a/drivers/net/phy/mdio-mscc-miim.c b/drivers/net/phy/mdio-mscc-miim.c index badbc99bedd3..b36fe81b6e6d 100644 --- a/drivers/net/phy/mdio-mscc-miim.c +++ b/drivers/net/phy/mdio-mscc-miim.c @@ -115,15 +115,10 @@ static int mscc_miim_reset(struct mii_bus *bus) static int mscc_miim_probe(struct platform_device *pdev) { - struct resource *res; struct mii_bus *bus; struct mscc_miim_dev *dev; int ret; - res = platform_get_resource(pdev, IORESOURCE_MEM, 0); - if (!res) - return -ENODEV; - bus = devm_mdiobus_alloc_size(&pdev->dev, sizeof(*dev)); if (!bus) return -ENOMEM; @@ -136,19 +131,16 @@ static int mscc_miim_probe(struct platform_device *pdev) bus->parent = &pdev->dev; dev = bus->priv; - dev->regs = devm_ioremap_resource(&pdev->dev, res); + dev->regs = devm_platform_ioremap_resource(pdev, 0); if (IS_ERR(dev->regs)) { dev_err(&pdev->dev, "Unable to map MIIM registers\n"); return PTR_ERR(dev->regs); } - res = platform_get_resource(pdev, IORESOURCE_MEM, 1); - if (res) { - dev->phy_regs = devm_ioremap_resource(&pdev->dev, res); - if (IS_ERR(dev->phy_regs)) { - dev_err(&pdev->dev, "Unable to map internal phy registers\n"); - return PTR_ERR(dev->phy_regs); - } + dev->phy_regs = devm_platform_ioremap_resource(pdev, 1); + if (IS_ERR(dev->phy_regs)) { + dev_err(&pdev->dev, "Unable to map internal phy registers\n"); + return PTR_ERR(dev->phy_regs); } ret = of_mdiobus_register(bus, pdev->dev.of_node); -- 2.23.0 ^ permalink raw reply related [flat|nested] 12+ messages in thread
* Re: [PATCH 1/2] net/phy/mdio-mscc-miim: Use devm_platform_ioremap_resource() in mscc_miim_probe() 2019-09-20 19:02 ` [PATCH 1/2] net/phy/mdio-mscc-miim: Use devm_platform_ioremap_resource() in mscc_miim_probe() Markus Elfring @ 2019-09-20 19:09 ` Andrew Lunn 2019-09-26 15:29 ` [1/2] " Markus Elfring 0 siblings, 1 reply; 12+ messages in thread From: Andrew Lunn @ 2019-09-20 19:09 UTC (permalink / raw) To: Markus Elfring Cc: netdev, Alexandre Belloni, Florian Fainelli, David S. Miller, Heiner Kallweit, LKML, kernel-janitors On Fri, Sep 20, 2019 at 09:02:40PM +0200, Markus Elfring wrote: > From: Markus Elfring <elfring@users.sourceforge.net> > Date: Fri, 20 Sep 2019 20:20:34 +0200 > > Simplify this function implementation by using a known wrapper function. > > This issue was detected by using the Coccinelle software. > > Signed-off-by: Markus Elfring <elfring@users.sourceforge.net> Reviewed-by: Andrew Lunn <andrew@lunn.ch> Andrew ^ permalink raw reply [flat|nested] 12+ messages in thread
* Re: [1/2] net/phy/mdio-mscc-miim: Use devm_platform_ioremap_resource() in mscc_miim_probe() 2019-09-20 19:09 ` Andrew Lunn @ 2019-09-26 15:29 ` Markus Elfring 2019-09-26 16:18 ` Alexandre Belloni 0 siblings, 1 reply; 12+ messages in thread From: Markus Elfring @ 2019-09-26 15:29 UTC (permalink / raw) To: Andrew Lunn, netdev Cc: Alexandre Belloni, Florian Fainelli, David S. Miller, Heiner Kallweit, LKML, kernel-janitors >> Simplify this function implementation by using a known wrapper function. … > Reviewed-by: Andrew Lunn <andrew@lunn.ch> Does this feedback indicate also an agreement for the detail if the mapping of internal phy registers would be a required operation? (Would such a resource allocation eventually be optional?) https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git/tree/drivers/net/phy/mdio-mscc-miim.c?id=f41def397161053eb0d3ed6861ef65985efbf293#n145 https://elixir.bootlin.com/linux/v5.3.1/source/drivers/net/phy/mdio-mscc-miim.c#L145 Regards, Markus ^ permalink raw reply [flat|nested] 12+ messages in thread
* Re: [1/2] net/phy/mdio-mscc-miim: Use devm_platform_ioremap_resource() in mscc_miim_probe() 2019-09-26 15:29 ` [1/2] " Markus Elfring @ 2019-09-26 16:18 ` Alexandre Belloni 2019-09-26 18:52 ` Markus Elfring 0 siblings, 1 reply; 12+ messages in thread From: Alexandre Belloni @ 2019-09-26 16:18 UTC (permalink / raw) To: Markus Elfring Cc: Andrew Lunn, netdev, Florian Fainelli, David S. Miller, Heiner Kallweit, LKML, kernel-janitors On 26/09/2019 17:29:02+0200, Markus Elfring wrote: > >> Simplify this function implementation by using a known wrapper function. > … > > Reviewed-by: Andrew Lunn <andrew@lunn.ch> > > Does this feedback indicate also an agreement for the detail > if the mapping of internal phy registers would be a required operation? > (Would such a resource allocation eventually be optional?) It is optional. -- Alexandre Belloni, Bootlin Embedded Linux and Kernel engineering https://bootlin.com ^ permalink raw reply [flat|nested] 12+ messages in thread
* Re: [1/2] net/phy/mdio-mscc-miim: Use devm_platform_ioremap_resource() in mscc_miim_probe() 2019-09-26 16:18 ` Alexandre Belloni @ 2019-09-26 18:52 ` Markus Elfring 2019-09-26 19:32 ` Alexandre Belloni 0 siblings, 1 reply; 12+ messages in thread From: Markus Elfring @ 2019-09-26 18:52 UTC (permalink / raw) To: Alexandre Belloni, Andrew Lunn, netdev Cc: Florian Fainelli, David S. Miller, Heiner Kallweit, LKML, kernel-janitors >> Does this feedback indicate also an agreement for the detail >> if the mapping of internal phy registers would be a required operation? >> (Would such a resource allocation eventually be optional?) > > It is optional. Would you like to integrate an other patch variant then? Regards, Markus ^ permalink raw reply [flat|nested] 12+ messages in thread
* Re: [1/2] net/phy/mdio-mscc-miim: Use devm_platform_ioremap_resource() in mscc_miim_probe() 2019-09-26 18:52 ` Markus Elfring @ 2019-09-26 19:32 ` Alexandre Belloni 2019-09-27 8:14 ` [PATCH v2 0/2] net: phy: mscc-miim: Adjustments for mscc_miim_probe() Markus Elfring 0 siblings, 1 reply; 12+ messages in thread From: Alexandre Belloni @ 2019-09-26 19:32 UTC (permalink / raw) To: Markus Elfring Cc: Andrew Lunn, netdev, Florian Fainelli, David S. Miller, Heiner Kallweit, LKML, kernel-janitors On 26/09/2019 20:52:38+0200, Markus Elfring wrote: > >> Does this feedback indicate also an agreement for the detail > >> if the mapping of internal phy registers would be a required operation? > >> (Would such a resource allocation eventually be optional?) > > > > It is optional. > > Would you like to integrate an other patch variant then? > You have to ensure it stays optional. Also, adjust the subject so it uses the correct prefix. -- Alexandre Belloni, Bootlin Embedded Linux and Kernel engineering https://bootlin.com ^ permalink raw reply [flat|nested] 12+ messages in thread
* [PATCH v2 0/2] net: phy: mscc-miim: Adjustments for mscc_miim_probe() 2019-09-26 19:32 ` Alexandre Belloni @ 2019-09-27 8:14 ` Markus Elfring 2019-09-27 8:16 ` [PATCH v2 1/2] net: phy: mscc-miim: Use devm_platform_ioremap_resource() in mscc_miim_probe() Markus Elfring 2019-09-27 8:18 ` [PATCH v2 2/2] net: phy: mscc-miim: Move the setting of mii_bus structure members " Markus Elfring 0 siblings, 2 replies; 12+ messages in thread From: Markus Elfring @ 2019-09-27 8:14 UTC (permalink / raw) To: netdev, Alexandre Belloni, Andrew Lunn, Florian Fainelli, David S. Miller, Heiner Kallweit Cc: LKML, kernel-janitors From: Markus Elfring <elfring@users.sourceforge.net> Date: Fri, 27 Sep 2019 09:48:09 +0200 Two update suggestions were taken into account from static source code analysis. Markus Elfring (2): Use devm_platform_ioremap_resource() Move the setting of mii_bus structure members drivers/net/phy/mdio-mscc-miim.c | 19 +++++++------------ 1 file changed, 7 insertions(+), 12 deletions(-) -- 2.23.0 ^ permalink raw reply [flat|nested] 12+ messages in thread
* [PATCH v2 1/2] net: phy: mscc-miim: Use devm_platform_ioremap_resource() in mscc_miim_probe() 2019-09-27 8:14 ` [PATCH v2 0/2] net: phy: mscc-miim: Adjustments for mscc_miim_probe() Markus Elfring @ 2019-09-27 8:16 ` Markus Elfring 2019-09-27 8:18 ` [PATCH v2 2/2] net: phy: mscc-miim: Move the setting of mii_bus structure members " Markus Elfring 1 sibling, 0 replies; 12+ messages in thread From: Markus Elfring @ 2019-09-27 8:16 UTC (permalink / raw) To: netdev, Alexandre Belloni, Andrew Lunn, Florian Fainelli, David S. Miller, Heiner Kallweit Cc: LKML, kernel-janitors From: Markus Elfring <elfring@users.sourceforge.net> Date: Fri, 27 Sep 2019 09:24:03 +0200 Simplify this function implementation a bit by using a known wrapper function. This issue was detected by using the Coccinelle software. Signed-off-by: Markus Elfring <elfring@users.sourceforge.net> --- v2: Alexandre Belloni pointed the need for adjustments out. https://lore.kernel.org/r/20190926193239.GC6825@piout.net/ * The mapping of internal phy registers should be treated as optional. * An other prefix would be preferred in the commit subject. drivers/net/phy/mdio-mscc-miim.c | 6 +----- 1 file changed, 1 insertion(+), 5 deletions(-) diff --git a/drivers/net/phy/mdio-mscc-miim.c b/drivers/net/phy/mdio-mscc-miim.c index badbc99bedd3..aabb13982251 100644 --- a/drivers/net/phy/mdio-mscc-miim.c +++ b/drivers/net/phy/mdio-mscc-miim.c @@ -120,10 +120,6 @@ static int mscc_miim_probe(struct platform_device *pdev) struct mscc_miim_dev *dev; int ret; - res = platform_get_resource(pdev, IORESOURCE_MEM, 0); - if (!res) - return -ENODEV; - bus = devm_mdiobus_alloc_size(&pdev->dev, sizeof(*dev)); if (!bus) return -ENOMEM; @@ -136,7 +132,7 @@ static int mscc_miim_probe(struct platform_device *pdev) bus->parent = &pdev->dev; dev = bus->priv; - dev->regs = devm_ioremap_resource(&pdev->dev, res); + dev->regs = devm_platform_ioremap_resource(pdev, 0); if (IS_ERR(dev->regs)) { dev_err(&pdev->dev, "Unable to map MIIM registers\n"); return PTR_ERR(dev->regs); -- 2.23.0 ^ permalink raw reply related [flat|nested] 12+ messages in thread
* [PATCH v2 2/2] net: phy: mscc-miim: Move the setting of mii_bus structure members in mscc_miim_probe() 2019-09-27 8:14 ` [PATCH v2 0/2] net: phy: mscc-miim: Adjustments for mscc_miim_probe() Markus Elfring 2019-09-27 8:16 ` [PATCH v2 1/2] net: phy: mscc-miim: Use devm_platform_ioremap_resource() in mscc_miim_probe() Markus Elfring @ 2019-09-27 8:18 ` Markus Elfring 1 sibling, 0 replies; 12+ messages in thread From: Markus Elfring @ 2019-09-27 8:18 UTC (permalink / raw) To: netdev, Alexandre Belloni, Andrew Lunn, Florian Fainelli, David S. Miller, Heiner Kallweit Cc: LKML, kernel-janitors From: Markus Elfring <elfring@users.sourceforge.net> Date: Fri, 27 Sep 2019 09:30:14 +0200 Move the modification of some members in the data structure “mii_bus” for the local variable “bus” directly before the call of the function “of_mdiobus_register” so that this change will be performed only after previous resource allocations succeeded. Signed-off-by: Markus Elfring <elfring@users.sourceforge.net> --- v2: This suggestion was repeated based on the change for the previous update step. drivers/net/phy/mdio-mscc-miim.c | 13 ++++++------- 1 file changed, 6 insertions(+), 7 deletions(-) diff --git a/drivers/net/phy/mdio-mscc-miim.c b/drivers/net/phy/mdio-mscc-miim.c index aabb13982251..a270f83bb207 100644 --- a/drivers/net/phy/mdio-mscc-miim.c +++ b/drivers/net/phy/mdio-mscc-miim.c @@ -124,13 +124,6 @@ static int mscc_miim_probe(struct platform_device *pdev) if (!bus) return -ENOMEM; - bus->name = "mscc_miim"; - bus->read = mscc_miim_read; - bus->write = mscc_miim_write; - bus->reset = mscc_miim_reset; - snprintf(bus->id, MII_BUS_ID_SIZE, "%s-mii", dev_name(&pdev->dev)); - bus->parent = &pdev->dev; - dev = bus->priv; dev->regs = devm_platform_ioremap_resource(pdev, 0); if (IS_ERR(dev->regs)) { @@ -147,6 +140,12 @@ static int mscc_miim_probe(struct platform_device *pdev) } } + bus->name = "mscc_miim"; + bus->read = mscc_miim_read; + bus->write = mscc_miim_write; + bus->reset = mscc_miim_reset; + snprintf(bus->id, MII_BUS_ID_SIZE, "%s-mii", dev_name(&pdev->dev)); + bus->parent = &pdev->dev; ret = of_mdiobus_register(bus, pdev->dev.of_node); if (ret < 0) { dev_err(&pdev->dev, "Cannot register MDIO bus (%d)\n", ret); -- 2.23.0 ^ permalink raw reply related [flat|nested] 12+ messages in thread
* [PATCH 2/2] net/phy/mdio-mscc-miim: Move the setting of mii_bus structure members in mscc_miim_probe() 2019-09-20 19:00 [PATCH 0/2] net/phy/mdio-mscc-miim: Adjustments for mscc_miim_probe() Markus Elfring 2019-09-20 19:02 ` [PATCH 1/2] net/phy/mdio-mscc-miim: Use devm_platform_ioremap_resource() in mscc_miim_probe() Markus Elfring @ 2019-09-20 19:03 ` Markus Elfring 2019-09-20 19:13 ` Andrew Lunn 1 sibling, 1 reply; 12+ messages in thread From: Markus Elfring @ 2019-09-20 19:03 UTC (permalink / raw) To: netdev, Alexandre Belloni, Andrew Lunn, Florian Fainelli, David S. Miller, Heiner Kallweit Cc: LKML, kernel-janitors From: Markus Elfring <elfring@users.sourceforge.net> Date: Fri, 20 Sep 2019 20:42:42 +0200 Move the modification of some members in the data structure “mii_bus” for the local variable “bus” directly before the call of the function “of_mdiobus_register” so that this change will be performed only after previous resource allocations succeeded. Signed-off-by: Markus Elfring <elfring@users.sourceforge.net> --- drivers/net/phy/mdio-mscc-miim.c | 13 ++++++------- 1 file changed, 6 insertions(+), 7 deletions(-) diff --git a/drivers/net/phy/mdio-mscc-miim.c b/drivers/net/phy/mdio-mscc-miim.c index b36fe81b6e6d..c46e0c78402e 100644 --- a/drivers/net/phy/mdio-mscc-miim.c +++ b/drivers/net/phy/mdio-mscc-miim.c @@ -123,13 +123,6 @@ static int mscc_miim_probe(struct platform_device *pdev) if (!bus) return -ENOMEM; - bus->name = "mscc_miim"; - bus->read = mscc_miim_read; - bus->write = mscc_miim_write; - bus->reset = mscc_miim_reset; - snprintf(bus->id, MII_BUS_ID_SIZE, "%s-mii", dev_name(&pdev->dev)); - bus->parent = &pdev->dev; - dev = bus->priv; dev->regs = devm_platform_ioremap_resource(pdev, 0); if (IS_ERR(dev->regs)) { @@ -143,6 +136,12 @@ static int mscc_miim_probe(struct platform_device *pdev) return PTR_ERR(dev->phy_regs); } + bus->name = "mscc_miim"; + bus->read = mscc_miim_read; + bus->write = mscc_miim_write; + bus->reset = mscc_miim_reset; + snprintf(bus->id, MII_BUS_ID_SIZE, "%s-mii", dev_name(&pdev->dev)); + bus->parent = &pdev->dev; ret = of_mdiobus_register(bus, pdev->dev.of_node); if (ret < 0) { dev_err(&pdev->dev, "Cannot register MDIO bus (%d)\n", ret); -- 2.23.0 ^ permalink raw reply related [flat|nested] 12+ messages in thread
* Re: [PATCH 2/2] net/phy/mdio-mscc-miim: Move the setting of mii_bus structure members in mscc_miim_probe() 2019-09-20 19:03 ` [PATCH 2/2] net/phy/mdio-mscc-miim: " Markus Elfring @ 2019-09-20 19:13 ` Andrew Lunn 0 siblings, 0 replies; 12+ messages in thread From: Andrew Lunn @ 2019-09-20 19:13 UTC (permalink / raw) To: Markus Elfring Cc: netdev, Alexandre Belloni, Florian Fainelli, David S. Miller, Heiner Kallweit, LKML, kernel-janitors On Fri, Sep 20, 2019 at 09:03:57PM +0200, Markus Elfring wrote: > From: Markus Elfring <elfring@users.sourceforge.net> > Date: Fri, 20 Sep 2019 20:42:42 +0200 > > Move the modification of some members in the data structure “mii_bus” > for the local variable “bus” directly before the call of > the function “of_mdiobus_register” so that this change will be performed > only after previous resource allocations succeeded. Hi Markus I'm not sure it is worth making this change. The resource allocations succeeds 99.9999% of the time. It is a chunk of MMIO, not some gpio, or i2c device which might give us EPROBE_DEFERRED. So we are not wasting anything in reality. Andrew ^ permalink raw reply [flat|nested] 12+ messages in thread
end of thread, other threads:[~2019-09-27 8:18 UTC | newest] Thread overview: 12+ messages (download: mbox.gz / follow: Atom feed) -- links below jump to the message on this page -- 2019-09-20 19:00 [PATCH 0/2] net/phy/mdio-mscc-miim: Adjustments for mscc_miim_probe() Markus Elfring 2019-09-20 19:02 ` [PATCH 1/2] net/phy/mdio-mscc-miim: Use devm_platform_ioremap_resource() in mscc_miim_probe() Markus Elfring 2019-09-20 19:09 ` Andrew Lunn 2019-09-26 15:29 ` [1/2] " Markus Elfring 2019-09-26 16:18 ` Alexandre Belloni 2019-09-26 18:52 ` Markus Elfring 2019-09-26 19:32 ` Alexandre Belloni 2019-09-27 8:14 ` [PATCH v2 0/2] net: phy: mscc-miim: Adjustments for mscc_miim_probe() Markus Elfring 2019-09-27 8:16 ` [PATCH v2 1/2] net: phy: mscc-miim: Use devm_platform_ioremap_resource() in mscc_miim_probe() Markus Elfring 2019-09-27 8:18 ` [PATCH v2 2/2] net: phy: mscc-miim: Move the setting of mii_bus structure members " Markus Elfring 2019-09-20 19:03 ` [PATCH 2/2] net/phy/mdio-mscc-miim: " Markus Elfring 2019-09-20 19:13 ` Andrew Lunn
This is a public inbox, see mirroring instructions for how to clone and mirror all data and code used for this inbox; as well as URLs for NNTP newsgroup(s).