* [PATCH net-next 08/14] tg3: Remove 5720, 5750, and 5750M
@ 2010-08-02 21:26 Matt Carlson
2011-09-06 15:03 ` re add support for bcm5750 Florian Mickler
0 siblings, 1 reply; 6+ messages in thread
From: Matt Carlson @ 2010-08-02 21:26 UTC (permalink / raw)
To: davem; +Cc: netdev, andy, mcarlson
These devices were never released to the public.
Reviewed-by: Benjamin Li <benli@broadcom.com>
Reviewed-by: Michael Chan <mchan@broadcom.com>
Signed-off-by: Matt Carlson <mcarlson@broadcom.com>
---
drivers/net/tg3.c | 3 ---
include/linux/pci_ids.h | 3 ---
2 files changed, 0 insertions(+), 6 deletions(-)
diff --git a/drivers/net/tg3.c b/drivers/net/tg3.c
index a52f52f..32e3a3d 100644
--- a/drivers/net/tg3.c
+++ b/drivers/net/tg3.c
@@ -221,12 +221,9 @@ static DEFINE_PCI_DEVICE_TABLE(tg3_pci_tbl) = {
{PCI_DEVICE(PCI_VENDOR_ID_BROADCOM, PCI_DEVICE_ID_TIGON3_5901_2)},
{PCI_DEVICE(PCI_VENDOR_ID_BROADCOM, PCI_DEVICE_ID_TIGON3_5704S_2)},
{PCI_DEVICE(PCI_VENDOR_ID_BROADCOM, PCI_DEVICE_ID_TIGON3_5705F)},
- {PCI_DEVICE(PCI_VENDOR_ID_BROADCOM, PCI_DEVICE_ID_TIGON3_5720)},
{PCI_DEVICE(PCI_VENDOR_ID_BROADCOM, PCI_DEVICE_ID_TIGON3_5721)},
{PCI_DEVICE(PCI_VENDOR_ID_BROADCOM, PCI_DEVICE_ID_TIGON3_5722)},
- {PCI_DEVICE(PCI_VENDOR_ID_BROADCOM, PCI_DEVICE_ID_TIGON3_5750)},
{PCI_DEVICE(PCI_VENDOR_ID_BROADCOM, PCI_DEVICE_ID_TIGON3_5751)},
- {PCI_DEVICE(PCI_VENDOR_ID_BROADCOM, PCI_DEVICE_ID_TIGON3_5750M)},
{PCI_DEVICE(PCI_VENDOR_ID_BROADCOM, PCI_DEVICE_ID_TIGON3_5751M)},
{PCI_DEVICE(PCI_VENDOR_ID_BROADCOM, PCI_DEVICE_ID_TIGON3_5751F)},
{PCI_DEVICE(PCI_VENDOR_ID_BROADCOM, PCI_DEVICE_ID_TIGON3_5752)},
diff --git a/include/linux/pci_ids.h b/include/linux/pci_ids.h
index ae66851..9ac60da 100644
--- a/include/linux/pci_ids.h
+++ b/include/linux/pci_ids.h
@@ -2053,7 +2053,6 @@
#define PCI_DEVICE_ID_NX2_57711E 0x1650
#define PCI_DEVICE_ID_TIGON3_5705 0x1653
#define PCI_DEVICE_ID_TIGON3_5705_2 0x1654
-#define PCI_DEVICE_ID_TIGON3_5720 0x1658
#define PCI_DEVICE_ID_TIGON3_5721 0x1659
#define PCI_DEVICE_ID_TIGON3_5722 0x165a
#define PCI_DEVICE_ID_TIGON3_5723 0x165b
@@ -2067,13 +2066,11 @@
#define PCI_DEVICE_ID_TIGON3_5754M 0x1672
#define PCI_DEVICE_ID_TIGON3_5755M 0x1673
#define PCI_DEVICE_ID_TIGON3_5756 0x1674
-#define PCI_DEVICE_ID_TIGON3_5750 0x1676
#define PCI_DEVICE_ID_TIGON3_5751 0x1677
#define PCI_DEVICE_ID_TIGON3_5715 0x1678
#define PCI_DEVICE_ID_TIGON3_5715S 0x1679
#define PCI_DEVICE_ID_TIGON3_5754 0x167a
#define PCI_DEVICE_ID_TIGON3_5755 0x167b
-#define PCI_DEVICE_ID_TIGON3_5750M 0x167c
#define PCI_DEVICE_ID_TIGON3_5751M 0x167d
#define PCI_DEVICE_ID_TIGON3_5751F 0x167e
#define PCI_DEVICE_ID_TIGON3_5787F 0x167f
--
1.7.1
^ permalink raw reply related [flat|nested] 6+ messages in thread
* re add support for bcm5750
2010-08-02 21:26 [PATCH net-next 08/14] tg3: Remove 5720, 5750, and 5750M Matt Carlson
@ 2011-09-06 15:03 ` Florian Mickler
2011-09-07 1:25 ` Matt Carlson
0 siblings, 1 reply; 6+ messages in thread
From: Florian Mickler @ 2011-09-06 15:03 UTC (permalink / raw)
To: mcarlson; +Cc: netdev, linux-kernel, benli, mchan, davem, Francesco Piccinno
Hi,
in https://bugzilla.kernel.org/show_bug.cgi?id=42132 Francesco wrote:
> I have a notebook (HP TC4400) which has a BCM5750 ethernet card inside. The
> ouput of lspci is:
>
> 08:00.0 Ethernet controller [0200]: Broadcom Corporation NetXtreme BCM5750M
> Gigabit Ethernet [14e4:167c]
>
> Commit 67b284d476bcb3d100e946da23d6cf9acfd0465c removed the support for this
> device. I wish to have the support for this network card back again. Thanks!
Regards,
Flo
^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: re add support for bcm5750
2011-09-06 15:03 ` re add support for bcm5750 Florian Mickler
@ 2011-09-07 1:25 ` Matt Carlson
2011-09-07 18:36 ` Florian Mickler
0 siblings, 1 reply; 6+ messages in thread
From: Matt Carlson @ 2011-09-07 1:25 UTC (permalink / raw)
To: Florian Mickler
Cc: Matthew Carlson, netdev, linux-kernel, Benjamin Li, Michael Chan,
davem, Francesco Piccinno
On Tue, Sep 06, 2011 at 08:03:43AM -0700, Florian Mickler wrote:
> Hi,
>
> in https://bugzilla.kernel.org/show_bug.cgi?id=42132 Francesco wrote:
>
> > I have a notebook (HP TC4400) which has a BCM5750 ethernet card inside. The
> > ouput of lspci is:
> >
> > 08:00.0 Ethernet controller [0200]: Broadcom Corporation NetXtreme BCM5750M
> > Gigabit Ethernet [14e4:167c]
> >
> > Commit 67b284d476bcb3d100e946da23d6cf9acfd0465c removed the support for this
> > device. I wish to have the support for this network card back again. Thanks!
Hi Florian. Are you experiencing the same problem? We found that
Francesco's problem was that the firmware of his device was missing. Do
you see :
eth0: No firmware running
messages?
^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: re add support for bcm5750
2011-09-07 1:25 ` Matt Carlson
@ 2011-09-07 18:36 ` Florian Mickler
2011-09-16 13:39 ` Francesco Piccinno
0 siblings, 1 reply; 6+ messages in thread
From: Florian Mickler @ 2011-09-07 18:36 UTC (permalink / raw)
To: Matt Carlson
Cc: netdev, linux-kernel, Benjamin Li, Michael Chan, davem,
Francesco Piccinno
On Tue, 6 Sep 2011 18:25:15 -0700
"Matt Carlson" <mcarlson@broadcom.com> wrote:
> On Tue, Sep 06, 2011 at 08:03:43AM -0700, Florian Mickler wrote:
> > Hi,
> >
> > in https://bugzilla.kernel.org/show_bug.cgi?id=42132 Francesco wrote:
> >
> > > I have a notebook (HP TC4400) which has a BCM5750 ethernet card inside. The
> > > ouput of lspci is:
> > >
> > > 08:00.0 Ethernet controller [0200]: Broadcom Corporation NetXtreme BCM5750M
> > > Gigabit Ethernet [14e4:167c]
> > >
> > > Commit 67b284d476bcb3d100e946da23d6cf9acfd0465c removed the support for this
> > > device. I wish to have the support for this network card back again. Thanks!
>
> Hi Florian. Are you experiencing the same problem? We found that
> Francesco's problem was that the firmware of his device was missing. Do
> you see :
>
> eth0: No firmware running
>
> messages?
>
Hi Matt!
No, I was just browsing the regression list and found this entry but
couldn't associate any action with it.
This clears that up, thanks for the information and I will close this
bug.
Regards,
Flo
^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: re add support for bcm5750
2011-09-07 18:36 ` Florian Mickler
@ 2011-09-16 13:39 ` Francesco Piccinno
2011-09-16 16:28 ` Matt Carlson
0 siblings, 1 reply; 6+ messages in thread
From: Francesco Piccinno @ 2011-09-16 13:39 UTC (permalink / raw)
To: Florian Mickler
Cc: Matt Carlson, netdev, linux-kernel, Benjamin Li, Michael Chan, davem
I have contacted Broadcom asking for support and apparently there is
no way to fix the problem. Now I have a couple of questions: the use
of tg3 driver without a firmware expose the NIC to some risks or not?
And is there any chance to have the PCI IDs added back to tg3 module?
I do not want to modify and recompile the module at every version
bump.
Thanks for the support :)
--
Best regards,
Francesco Piccinno
On Wed, Sep 7, 2011 at 8:36 PM, Florian Mickler <florian@mickler.org> wrote:
> On Tue, 6 Sep 2011 18:25:15 -0700
> "Matt Carlson" <mcarlson@broadcom.com> wrote:
>
>> On Tue, Sep 06, 2011 at 08:03:43AM -0700, Florian Mickler wrote:
>> > Hi,
>> >
>> > in https://bugzilla.kernel.org/show_bug.cgi?id=42132 Francesco wrote:
>> >
>> > > I have a notebook (HP TC4400) which has a BCM5750 ethernet card inside. The
>> > > ouput of lspci is:
>> > >
>> > > 08:00.0 Ethernet controller [0200]: Broadcom Corporation NetXtreme BCM5750M
>> > > Gigabit Ethernet [14e4:167c]
>> > >
>> > > Commit 67b284d476bcb3d100e946da23d6cf9acfd0465c removed the support for this
>> > > device. I wish to have the support for this network card back again. Thanks!
>>
>> Hi Florian. Are you experiencing the same problem? We found that
>> Francesco's problem was that the firmware of his device was missing. Do
>> you see :
>>
>> eth0: No firmware running
>>
>> messages?
>>
>
> Hi Matt!
> No, I was just browsing the regression list and found this entry but
> couldn't associate any action with it.
>
> This clears that up, thanks for the information and I will close this
> bug.
>
> Regards,
> Flo
>
^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: re add support for bcm5750
2011-09-16 13:39 ` Francesco Piccinno
@ 2011-09-16 16:28 ` Matt Carlson
0 siblings, 0 replies; 6+ messages in thread
From: Matt Carlson @ 2011-09-16 16:28 UTC (permalink / raw)
To: Francesco Piccinno
Cc: Florian Mickler, Matthew Carlson, netdev, linux-kernel,
Benjamin Li, Michael Chan, davem
On Fri, Sep 16, 2011 at 06:39:30AM -0700, Francesco Piccinno wrote:
> I have contacted Broadcom asking for support and apparently there is
> no way to fix the problem. Now I have a couple of questions: the use
> of tg3 driver without a firmware expose the NIC to some risks or not?
> And is there any chance to have the PCI IDs added back to tg3 module?
> I do not want to modify and recompile the module at every version
> bump.
>
> Thanks for the support :)
That's the plan. It's on my TODO list to add support back in.
> --
> Best regards,
> Francesco Piccinno
>
>
>
> On Wed, Sep 7, 2011 at 8:36 PM, Florian Mickler <florian@mickler.org> wrote:
> > On Tue, 6 Sep 2011 18:25:15 -0700
> > "Matt Carlson" <mcarlson@broadcom.com> wrote:
> >
> >> On Tue, Sep 06, 2011 at 08:03:43AM -0700, Florian Mickler wrote:
> >> > Hi,
> >> >
> >> > in https://bugzilla.kernel.org/show_bug.cgi?id=42132 Francesco wrote:
> >> >
> >> > > I have a notebook (HP TC4400) which has a BCM5750 ethernet card inside. The
> >> > > ouput of lspci is:
> >> > >
> >> > > 08:00.0 Ethernet controller [0200]: Broadcom Corporation NetXtreme BCM5750M
> >> > > Gigabit Ethernet [14e4:167c]
> >> > >
> >> > > Commit 67b284d476bcb3d100e946da23d6cf9acfd0465c removed the support for this
> >> > > device. I wish to have the support for this network card back again. Thanks!
> >>
> >> Hi Florian. ??Are you experiencing the same problem? ??We found that
> >> Francesco's problem was that the firmware of his device was missing. ??Do
> >> you see :
> >>
> >> eth0: No firmware running
> >>
> >> messages?
> >>
> >
> > Hi Matt!
> > No, I was just browsing the regression list and found this entry but
> > couldn't associate any action with it.
> >
> > This clears that up, thanks for the information and I will close this
> > bug.
> >
> > Regards,
> > Flo
> >
>
^ permalink raw reply [flat|nested] 6+ messages in thread
end of thread, other threads:[~2011-09-16 16:28 UTC | newest]
Thread overview: 6+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2010-08-02 21:26 [PATCH net-next 08/14] tg3: Remove 5720, 5750, and 5750M Matt Carlson
2011-09-06 15:03 ` re add support for bcm5750 Florian Mickler
2011-09-07 1:25 ` Matt Carlson
2011-09-07 18:36 ` Florian Mickler
2011-09-16 13:39 ` Francesco Piccinno
2011-09-16 16:28 ` Matt Carlson
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).