From: Jason Wang <jasowang@redhat.com>
To: "Michael S. Tsirkin" <mst@redhat.com>
Cc: linux-kernel@vger.kernel.org, kvm@vger.kernel.org,
virtualization@lists.linux-foundation.org,
netdev@vger.kernel.org, jgg@mellanox.com,
maxime.coquelin@redhat.com, cunming.liang@intel.com,
zhihong.wang@intel.com, rob.miller@broadcom.com,
xiao.w.wang@intel.com, lingshan.zhu@intel.com,
eperezma@redhat.com, lulu@redhat.com, parav@mellanox.com,
kevin.tian@intel.com, stefanha@redhat.com, rdunlap@infradead.org,
hch@infradead.org, aadam@redhat.com, jiri@mellanox.com,
shahafs@mellanox.com, hanand@xilinx.com, mhabets@solarflare.com,
gdawar@xilinx.com, saugatm@xilinx.com, vmireyno@marvell.com,
zhangweining@ruijie.com.cn
Subject: Re: [PATCH V9 1/9] vhost: refine vhost and vringh kconfig
Date: Wed, 1 Apr 2020 22:43:56 +0800 [thread overview]
Message-ID: <12f0ff8f-cdf2-9aac-883c-48c39138b7ea@redhat.com> (raw)
In-Reply-To: <20200401103659-mutt-send-email-mst@kernel.org>
On 2020/4/1 下午10:39, Michael S. Tsirkin wrote:
>> >From 9b3a5d23b8bf6b0a11e65e688335d782f8e6aa5c Mon Sep 17 00:00:00 2001
>> From: Jason Wang<jasowang@redhat.com>
>> Date: Wed, 1 Apr 2020 22:17:27 +0800
>> Subject: [PATCH] vhost: let CONFIG_VHOST to be selected by drivers
>>
>> The defconfig on some archs enable vhost_net or vhost_vsock by
>> default. So instead of adding CONFIG_VHOST=m to all of those files,
>> simply letting CONFIG_VHOST to be selected by all of the vhost
>> drivers. This fixes the build on the archs with CONFIG_VHOST_NET=m in
>> their defconfig.
>>
>> Signed-off-by: Jason Wang<jasowang@redhat.com>
>> ---
>> drivers/vhost/Kconfig | 15 +++++++++++----
>> 1 file changed, 11 insertions(+), 4 deletions(-)
>>
>> diff --git a/drivers/vhost/Kconfig b/drivers/vhost/Kconfig
>> index 2523a1d4290a..362b832f5338 100644
>> --- a/drivers/vhost/Kconfig
>> +++ b/drivers/vhost/Kconfig
>> @@ -11,19 +11,23 @@ config VHOST_RING
>> This option is selected by any driver which needs to access
>> the host side of a virtio ring.
>>
>> -menuconfig VHOST
>> - tristate "Host kernel accelerator for virtio (VHOST)"
>> - depends on EVENTFD
>> +config VHOST
>> + tristate
>> select VHOST_IOTLB
>> help
>> This option is selected by any driver which needs to access
>> the core of vhost.
>>
>> -if VHOST
>> +menuconfig VHOST_MENU
>> + bool "VHOST drivers"
>> + default y
>> +
>> +if VHOST_MENU
> In fact this is similar to VIRTIO, and I wonder whether VIRTIO has also
> been broken by
> commit 7b95fec6d2ffa53f4a8d637b0f223644d458ea4e
> Author: Vincent Legoll<vincent.legoll@gmail.com>
> Date: Sun Jan 7 12:33:56 2018 +0100
>
> virtio: make VIRTIO a menuconfig to ease disabling it all
>
> I see lots of defconfigs set VIRTIO_PCI but not VIRTIO_MENU ...
Probably not since VIRTIO_MENU has "default y"
E.g for powerpc, I got:
# make ARCH=powerpc defconfig
*** Default configuration is based on 'ppc64_defconfig'
#
# No change to .config
#
# grep CONFIG_VIRTIO .config
CONFIG_VIRTIO_BLK=m
CONFIG_VIRTIO_NET=m
CONFIG_VIRTIO_CONSOLE=m
CONFIG_VIRTIO=m
CONFIG_VIRTIO_MENU=y
CONFIG_VIRTIO_PCI=m
CONFIG_VIRTIO_PCI_LEGACY=y
# CONFIG_VIRTIO_VDPA is not set
CONFIG_VIRTIO_BALLOON=m
# CONFIG_VIRTIO_INPUT is not set
# CONFIG_VIRTIO_MMIO is not set
# CONFIG_VIRTIO_FS is not set
Thanks
next prev parent reply other threads:[~2020-04-01 14:44 UTC|newest]
Thread overview: 49+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-03-26 14:01 [PATCH V9 0/9] vDPA support Jason Wang
2020-03-26 14:01 ` [PATCH V9 1/9] vhost: refine vhost and vringh kconfig Jason Wang
2020-04-01 11:21 ` Christian Borntraeger
2020-04-01 12:50 ` Jason Wang
2020-04-01 12:56 ` Christian Borntraeger
2020-04-01 13:02 ` Christian Borntraeger
2020-04-01 14:01 ` Michael S. Tsirkin
2020-04-01 14:13 ` Jason Wang
2020-04-01 14:18 ` Michael S. Tsirkin
2020-04-01 14:36 ` Jason Wang
2020-04-01 14:27 ` Michael S. Tsirkin
2020-04-01 14:50 ` Jason Wang
2020-04-01 15:57 ` Michael S. Tsirkin
2020-04-01 18:53 ` Christian Borntraeger
2020-04-01 13:22 ` Michael S. Tsirkin
2020-04-01 14:08 ` Jason Wang
2020-04-01 14:13 ` Michael S. Tsirkin
2020-04-01 14:29 ` Jason Wang
2020-04-01 14:35 ` Michael S. Tsirkin
2020-04-01 14:39 ` Jason Wang
2020-04-01 14:39 ` Michael S. Tsirkin
2020-04-01 14:43 ` Jason Wang [this message]
2020-04-01 16:05 ` Michael S. Tsirkin
2020-04-01 16:08 ` Michael S. Tsirkin
2020-04-02 3:22 ` Jason Wang
2020-04-02 14:03 ` Michael S. Tsirkin
2020-04-02 14:23 ` Jason Wang
2020-04-02 14:38 ` Michael S. Tsirkin
2020-04-02 14:56 ` Jason Wang
2020-03-26 14:01 ` [PATCH V9 2/9] vhost: allow per device message handler Jason Wang
2020-03-26 14:01 ` [PATCH V9 3/9] vhost: factor out IOTLB Jason Wang
2020-03-26 14:01 ` [PATCH V9 4/9] vringh: IOTLB support Jason Wang
2020-03-26 14:01 ` [PATCH V9 5/9] vDPA: introduce vDPA bus Jason Wang
2020-03-26 14:01 ` [PATCH V9 6/9] virtio: introduce a vDPA based transport Jason Wang
2020-03-26 14:01 ` [PATCH V9 7/9] vhost: introduce vDPA-based backend Jason Wang
2021-11-01 14:11 ` Jason Gunthorpe
2021-11-02 3:52 ` Jason Wang
2021-11-02 15:56 ` Jason Gunthorpe
2021-11-03 7:34 ` Jason Wang
2020-03-26 14:01 ` [PATCH V9 8/9] vdpasim: vDPA device simulator Jason Wang
2020-04-10 7:45 ` Geert Uytterhoeven
2020-04-10 8:23 ` Jason Wang
2020-03-26 14:01 ` [PATCH V9 9/9] virtio: Intel IFC VF driver for VDPA Jason Wang
2020-04-09 10:41 ` Arnd Bergmann
2020-04-09 12:43 ` Jason Wang
2020-04-09 12:49 ` Zhu, Lingshan
2020-04-09 20:25 ` Michael S. Tsirkin
2020-04-10 3:15 ` Zhu, Lingshan
2020-03-29 11:07 ` [PATCH V9 0/9] vDPA support Michael S. Tsirkin
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=12f0ff8f-cdf2-9aac-883c-48c39138b7ea@redhat.com \
--to=jasowang@redhat.com \
--cc=aadam@redhat.com \
--cc=cunming.liang@intel.com \
--cc=eperezma@redhat.com \
--cc=gdawar@xilinx.com \
--cc=hanand@xilinx.com \
--cc=hch@infradead.org \
--cc=jgg@mellanox.com \
--cc=jiri@mellanox.com \
--cc=kevin.tian@intel.com \
--cc=kvm@vger.kernel.org \
--cc=lingshan.zhu@intel.com \
--cc=linux-kernel@vger.kernel.org \
--cc=lulu@redhat.com \
--cc=maxime.coquelin@redhat.com \
--cc=mhabets@solarflare.com \
--cc=mst@redhat.com \
--cc=netdev@vger.kernel.org \
--cc=parav@mellanox.com \
--cc=rdunlap@infradead.org \
--cc=rob.miller@broadcom.com \
--cc=saugatm@xilinx.com \
--cc=shahafs@mellanox.com \
--cc=stefanha@redhat.com \
--cc=virtualization@lists.linux-foundation.org \
--cc=vmireyno@marvell.com \
--cc=xiao.w.wang@intel.com \
--cc=zhangweining@ruijie.com.cn \
--cc=zhihong.wang@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).