From: Ben Hutchings <ben@decadent.org.uk>
To: Hayes Wang <hayeswang@realtek.com>
Cc: dwmw2@infradead.org, romieu@fr.zoreil.com, netdev@vger.kernel.org
Subject: Re: [linux-firmware v2 1/2] rtl_nic: update firmware for RTL8111E-VL
Date: Wed, 10 Aug 2011 13:54:20 +0100 [thread overview]
Message-ID: <1312980860.2591.1267.camel@deadeye> (raw)
In-Reply-To: <1312978979-1808-1-git-send-email-hayeswang@realtek.com>
[-- Attachment #1: Type: text/plain, Size: 925 bytes --]
On Wed, 2011-08-10 at 20:22 +0800, Hayes Wang wrote:
> Updated firmware with stability fixes.
> Version: rtl8168e-3_0.0.1.
>
> Signed-off-by: Hayes Wang <hayeswang@realtek.com>
> ---
> WHENCE | 2 +-
> rtl_nic/rtl8168e-3.fw | Bin 2804 -> 3264 bytes
> 2 files changed, 1 insertions(+), 1 deletions(-)
>
> diff --git a/WHENCE b/WHENCE
> index 4b88f1f..a463417 100644
> --- a/WHENCE
> +++ b/WHENCE
> @@ -1626,7 +1626,7 @@ File: rtl_nic/rtl8168d-2.fw
> File: rtl_nic/rtl8105e-1.fw
> File: rtl_nic/rtl8168e-1.fw
> File: rtl_nic/rtl8168e-2.fw
> -File: rtl_nic/rtl8168e-3.fw
> +File: rtl_nic/rtl8168e-3.fw (Version: rtl8168e-3_0.0.1)
[...]
Please don't write the version in yet another way. It should be:
File: rtl_nic/rtl8168e-3.fw
Version: 0.0.1
Or, if you insist on duplicating the name in the version:
File: rtl_nic/rtl8168e-3.fw
Version: rtl8168e-3_0.0.1
Ben.
[-- Attachment #2: This is a digitally signed message part --]
[-- Type: application/pgp-signature, Size: 828 bytes --]
next prev parent reply other threads:[~2011-08-10 12:54 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-08-10 12:22 [linux-firmware v2 1/2] rtl_nic: update firmware for RTL8111E-VL Hayes Wang
2011-08-10 12:22 ` [linux-firmware v2 2/2] rtl_nic: add new firmware for RTL8111F Hayes Wang
2011-08-10 12:54 ` Ben Hutchings [this message]
2011-08-11 3:41 ` [linux-firmware v2 1/2] rtl_nic: update firmware forRTL8111E-VL hayeswang
2011-08-11 12:46 ` Ben Hutchings
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1312980860.2591.1267.camel@deadeye \
--to=ben@decadent.org.uk \
--cc=dwmw2@infradead.org \
--cc=hayeswang@realtek.com \
--cc=netdev@vger.kernel.org \
--cc=romieu@fr.zoreil.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).