From: Ben Hutchings <ben@decadent.org.uk>
To: hayeswang <hayeswang@realtek.com>
Cc: dwmw2@infradead.org, romieu@fr.zoreil.com, netdev@vger.kernel.org
Subject: RE: [linux-firmware v2 1/2] rtl_nic: update firmware forRTL8111E-VL
Date: Thu, 11 Aug 2011 13:46:18 +0100 [thread overview]
Message-ID: <1313066778.2591.1280.camel@deadeye> (raw)
In-Reply-To: <9DEF5678E5044F80AEBAD3FE738EA980@realtek.com.tw>
[-- Attachment #1: Type: text/plain, Size: 984 bytes --]
On Thu, 2011-08-11 at 11:41 +0800, hayeswang wrote:
>
> > -----Original Message-----
> > From: Ben Hutchings [mailto:ben@decadent.org.uk]
> > > +File: rtl_nic/rtl8168e-3.fw (Version: rtl8168e-3_0.0.1)
> > [...]
> >
> > Please don't write the version in yet another way. It should be:
> >
>
> I just think if someone replaces the firmware with another one, I could check
> the firmware through the information without checking the ram data.
> For example, someone renames the rtl8168f-1.fw to rtl8168e-3.fw and replaces the
> original rtl8168e-3.fw. Through ethtool to show the version of the firmware, I
> could know the firmware is invalid. If the version only contain the value 0.0.1,
> I must compare the binary file to find out the result.
[...]
You're talking about the version string inside the firmware file. I see
the value of including the name there. However, in the WHENCE file it
is redundant.
But I really don't care that much.
Ben.
[-- Attachment #2: This is a digitally signed message part --]
[-- Type: application/pgp-signature, Size: 828 bytes --]
prev parent reply other threads:[~2011-08-11 12:46 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-08-10 12:22 [linux-firmware v2 1/2] rtl_nic: update firmware for RTL8111E-VL Hayes Wang
2011-08-10 12:22 ` [linux-firmware v2 2/2] rtl_nic: add new firmware for RTL8111F Hayes Wang
2011-08-10 12:54 ` [linux-firmware v2 1/2] rtl_nic: update firmware for RTL8111E-VL Ben Hutchings
2011-08-11 3:41 ` [linux-firmware v2 1/2] rtl_nic: update firmware forRTL8111E-VL hayeswang
2011-08-11 12:46 ` Ben Hutchings [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1313066778.2591.1280.camel@deadeye \
--to=ben@decadent.org.uk \
--cc=dwmw2@infradead.org \
--cc=hayeswang@realtek.com \
--cc=netdev@vger.kernel.org \
--cc=romieu@fr.zoreil.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).