From: "Michael Chan" <mchan@broadcom.com>
To: "David Miller" <davem@davemloft.net>
Cc: "netdev@vger.kernel.org" <netdev@vger.kernel.org>,
"Dmitry Kravkov" <dmitry@broadcom.com>,
"Eilon Greenstein" <eilong@broadcom.com>
Subject: Re: [PATCH net-next] bnx2x: Disable LRO on FCoE or iSCSI boot device
Date: Wed, 19 Oct 2011 13:12:52 -0700 [thread overview]
Message-ID: <1319055172.7658.33.camel@HP1> (raw)
In-Reply-To: <20111019.160653.684945718064985511.davem@davemloft.net>
On Wed, 2011-10-19 at 13:06 -0700, David Miller wrote:
> From: "Michael Chan" <mchan@broadcom.com>
> Date: Thu, 13 Oct 2011 20:38:01 -0700
>
> > From: Dmitry Kravkov <dmitry@broadcom.com>
> >
> > For an FCoE or iSCSI boot device, the networking side must stay "up" all
> > the time. Otherwise, the FCoE/iSCSI interface driven by bnx2i/bnx2fc
> > will be reset and we'll lose the root file system.
> >
> > If LRO is enabled, scripts that enable IP forwarding or bridging will
> > disable LRO and cause the device to be reset. Disabling LRO on these
> > boot devices will prevent the reset.
> >
> > Signed-off-by: Dmitry Kravkov <dmitry@broadcom.com>
> > Signed-off-by: Michael Chan <mchan@broadcom.com>
>
> You're still going to have bugs after this.
>
> What if you get a FIFO overflow or other error condition which requires
> a chip reset? You'll lose the root filesystem.
That would be no different than a scsi driver experiencing fatal errors,
wouldn't it?
> Why bother resetting
> the chip at all if it's going to be useless afterwards?
If the user has configured multipath to the storage target, we can still
reset each port separately.
What we want to prevent is any hidden reset during normal operations.
>
> The bug is in the fact that iSCSI context state isn't preserved or
> reloaded across a chip reset.
>
> Please fix that instead, and that way you won't have to add special
> hacks for the root filesystem. Everything will "just work'.
>
>
next prev parent reply other threads:[~2011-10-19 20:22 UTC|newest]
Thread overview: 15+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-10-14 3:38 [PATCH net-next] bnx2x: Disable LRO on FCoE or iSCSI boot device Michael Chan
2011-10-14 15:31 ` Rick Jones
2011-10-14 15:53 ` Michael Chan
2011-10-14 16:06 ` Rick Jones
2011-10-14 16:15 ` Michael Chan
2011-10-14 20:17 ` John Fastabend
2011-10-14 20:59 ` Michael Chan
2011-10-19 20:06 ` David Miller
2011-10-19 20:12 ` Michael Chan [this message]
2011-10-19 20:47 ` David Miller
2011-10-19 20:53 ` John Fastabend
2011-10-19 21:03 ` David Miller
2011-10-27 23:30 ` Michael Chan
2012-02-13 11:20 Vasily Averin
2012-02-13 19:09 ` Michael Chan
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1319055172.7658.33.camel@HP1 \
--to=mchan@broadcom.com \
--cc=davem@davemloft.net \
--cc=dmitry@broadcom.com \
--cc=eilong@broadcom.com \
--cc=netdev@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).