From: "Michael Chan" <mchan@broadcom.com>
To: "'Rick Jones'" <rick.jones2@hp.com>
Cc: "'davem@davemloft.net'" <davem@davemloft.net>,
"'netdev@vger.kernel.org'" <netdev@vger.kernel.org>,
"Dmitry Kravkov" <dmitry@broadcom.com>,
"Eilon Greenstein" <eilong@broadcom.com>
Subject: Re: [PATCH net-next] bnx2x: Disable LRO on FCoE or iSCSI boot device
Date: Fri, 14 Oct 2011 09:15:39 -0700 [thread overview]
Message-ID: <C27F8246C663564A84BB7AB34397724266D2018306@IRVEXCHCCR01.corp.ad.broadcom.com> (raw)
In-Reply-To: <4E985DE8.3090308@hp.com>
Rick Jones wrote:
> On 10/14/2011 08:53 AM, Michael Chan wrote:
> > Rick Jones wrote:
> >
> >> Is this perhaps saying that a bnx2x-driven device being used for
> >> FCoE or iSCSI boot must not permit *any* run-time configuration
> >> change which leads to a NIC reset?
> >>
> >
> > That is right. Unless you have a multipath configuration with
> multiple
> > ports, then you can reset one port at a time.
>
> So, should there also be a "cnic_boot_device" check in many of the
> "capital letter" ethtool paths?
>
If the user is doing ethtool configuration changes or device shutdown,
it is more obvious what the consequence will be. The user may also be
careful to do it on a multipath setup.
The reset caused by the auto turn-off of LRO when you enable
ip_forward or bridging will not be obvious to the user. In addition,
all devices with LRO turned on will be reset at the same time so even
multipath will not survive.
next prev parent reply other threads:[~2011-10-14 16:15 UTC|newest]
Thread overview: 15+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-10-14 3:38 [PATCH net-next] bnx2x: Disable LRO on FCoE or iSCSI boot device Michael Chan
2011-10-14 15:31 ` Rick Jones
2011-10-14 15:53 ` Michael Chan
2011-10-14 16:06 ` Rick Jones
2011-10-14 16:15 ` Michael Chan [this message]
2011-10-14 20:17 ` John Fastabend
2011-10-14 20:59 ` Michael Chan
2011-10-19 20:06 ` David Miller
2011-10-19 20:12 ` Michael Chan
2011-10-19 20:47 ` David Miller
2011-10-19 20:53 ` John Fastabend
2011-10-19 21:03 ` David Miller
2011-10-27 23:30 ` Michael Chan
2012-02-13 11:20 Vasily Averin
2012-02-13 19:09 ` Michael Chan
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=C27F8246C663564A84BB7AB34397724266D2018306@IRVEXCHCCR01.corp.ad.broadcom.com \
--to=mchan@broadcom.com \
--cc=davem@davemloft.net \
--cc=dmitry@broadcom.com \
--cc=eilong@broadcom.com \
--cc=netdev@vger.kernel.org \
--cc=rick.jones2@hp.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).