* [net] i825xx:xscale:8390:freescale: Fix Kconfig dependancies
@ 2011-11-02 10:30 Jeff Kirsher
2011-11-04 21:41 ` David Miller
0 siblings, 1 reply; 3+ messages in thread
From: Jeff Kirsher @ 2011-11-02 10:30 UTC (permalink / raw)
To: davem; +Cc: Jeff Kirsher, netdev, gospo, sassmann
i825xx and xscale are "sub" Kconfigs to NET_VENDOR_INTEL, so
NET_VENDOR_INTEL should contain ALL the dependencies of the
"sub" Kconfigs.
Same with 8390 is a "sub" Kconfig to NET_VENDOR_NATSEMI, so
NET_VENDOR_NATSEMI needs to contains ALL the dependencies.
Freescale Kconfig only had fs_enet as a sub Kconfig, and already
contained the needed dependencies, just cleaned up the dependencies.
Reported-by: Geert Uytterhoeven <geert@linux-m68k.org>
Signed-off-by: Jeff Kirsher <jeffrey.t.kirsher@intel.com>
---
drivers/net/ethernet/freescale/Kconfig | 3 +--
drivers/net/ethernet/intel/Kconfig | 6 +++++-
drivers/net/ethernet/natsemi/Kconfig | 6 +++++-
3 files changed, 11 insertions(+), 4 deletions(-)
diff --git a/drivers/net/ethernet/freescale/Kconfig b/drivers/net/ethernet/freescale/Kconfig
index 1cf6716..c520cfd 100644
--- a/drivers/net/ethernet/freescale/Kconfig
+++ b/drivers/net/ethernet/freescale/Kconfig
@@ -7,8 +7,7 @@ config NET_VENDOR_FREESCALE
default y
depends on FSL_SOC || QUICC_ENGINE || CPM1 || CPM2 || PPC_MPC512x || \
M523x || M527x || M5272 || M528x || M520x || M532x || \
- ARCH_MXC || ARCH_MXS || \
- (PPC_MPC52xx && PPC_BESTCOMM)
+ ARCH_MXC || ARCH_MXS || (PPC_MPC52xx && PPC_BESTCOMM)
---help---
If you have a network (Ethernet) card belonging to this class, say Y
and read the Ethernet-HOWTO, available from
diff --git a/drivers/net/ethernet/intel/Kconfig b/drivers/net/ethernet/intel/Kconfig
index 61029dc..7621316 100644
--- a/drivers/net/ethernet/intel/Kconfig
+++ b/drivers/net/ethernet/intel/Kconfig
@@ -5,7 +5,11 @@
config NET_VENDOR_INTEL
bool "Intel devices"
default y
- depends on PCI || PCI_MSI
+ depends on PCI || PCI_MSI || ISA || ISA_DMA_API || ARM || \
+ ARCH_ACORN || MCA || MCA_LEGACY || SNI_RM || SUN3 || \
+ GSC || BVME6000 || MVME16x || ARCH_ENP2611 || \
+ (ARM && ARCH_IXP4XX && IXP4XX_NPE && IXP4XX_QMGR) || \
+ EXPERIMENTAL
---help---
If you have a network (Ethernet) card belonging to this class, say Y
and read the Ethernet-HOWTO, available from
diff --git a/drivers/net/ethernet/natsemi/Kconfig b/drivers/net/ethernet/natsemi/Kconfig
index 4a6b9fd..c708bc3 100644
--- a/drivers/net/ethernet/natsemi/Kconfig
+++ b/drivers/net/ethernet/natsemi/Kconfig
@@ -5,7 +5,11 @@
config NET_VENDOR_NATSEMI
bool "National Semi-conductor devices"
default y
- depends on MCA || MAC || MACH_JAZZ || PCI || XTENSA_PLATFORM_XT2000
+ depends on AMIGA_PCMCIA || ARM || EISA || EXPERIMENTAL || H8300 || \
+ ISA || M32R || MAC || MACH_JAZZ || MACH_TX49XX || MCA || \
+ MCA_LEGACY || MIPS || PCI || PCMCIA || SUPERH || \
+ XTENSA_PLATFORM_XT2000 || ZORRO
+
---help---
If you have a network (Ethernet) card belonging to this class, say Y
and read the Ethernet-HOWTO, available from
--
1.7.6.4
^ permalink raw reply related [flat|nested] 3+ messages in thread
* Re: [net] i825xx:xscale:8390:freescale: Fix Kconfig dependancies
2011-11-02 10:30 [net] i825xx:xscale:8390:freescale: Fix Kconfig dependancies Jeff Kirsher
@ 2011-11-04 21:41 ` David Miller
2011-11-04 22:30 ` Jeff Kirsher
0 siblings, 1 reply; 3+ messages in thread
From: David Miller @ 2011-11-04 21:41 UTC (permalink / raw)
To: jeffrey.t.kirsher; +Cc: netdev, gospo, sassmann
From: Jeff Kirsher <jeffrey.t.kirsher@intel.com>
Date: Wed, 2 Nov 2011 03:30:52 -0700
> i825xx and xscale are "sub" Kconfigs to NET_VENDOR_INTEL, so
> NET_VENDOR_INTEL should contain ALL the dependencies of the
> "sub" Kconfigs.
>
> Same with 8390 is a "sub" Kconfig to NET_VENDOR_NATSEMI, so
> NET_VENDOR_NATSEMI needs to contains ALL the dependencies.
>
> Freescale Kconfig only had fs_enet as a sub Kconfig, and already
> contained the needed dependencies, just cleaned up the dependencies.
>
> Reported-by: Geert Uytterhoeven <geert@linux-m68k.org>
> Signed-off-by: Jeff Kirsher <jeffrey.t.kirsher@intel.com>
Applied, but:
> + XTENSA_PLATFORM_XT2000 || ZORRO
> +
> ---help---
I removed that extraneous white-space-only line before "--help--"
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [net] i825xx:xscale:8390:freescale: Fix Kconfig dependancies
2011-11-04 21:41 ` David Miller
@ 2011-11-04 22:30 ` Jeff Kirsher
0 siblings, 0 replies; 3+ messages in thread
From: Jeff Kirsher @ 2011-11-04 22:30 UTC (permalink / raw)
To: David Miller; +Cc: netdev, gospo, sassmann
[-- Attachment #1: Type: text/plain, Size: 951 bytes --]
On Fri, 2011-11-04 at 14:41 -0700, David Miller wrote:
> From: Jeff Kirsher <jeffrey.t.kirsher@intel.com>
> Date: Wed, 2 Nov 2011 03:30:52 -0700
>
> > i825xx and xscale are "sub" Kconfigs to NET_VENDOR_INTEL, so
> > NET_VENDOR_INTEL should contain ALL the dependencies of the
> > "sub" Kconfigs.
> >
> > Same with 8390 is a "sub" Kconfig to NET_VENDOR_NATSEMI, so
> > NET_VENDOR_NATSEMI needs to contains ALL the dependencies.
> >
> > Freescale Kconfig only had fs_enet as a sub Kconfig, and already
> > contained the needed dependencies, just cleaned up the dependencies.
> >
> > Reported-by: Geert Uytterhoeven <geert@linux-m68k.org>
> > Signed-off-by: Jeff Kirsher <jeffrey.t.kirsher@intel.com>
>
> Applied, but:
>
> > + XTENSA_PLATFORM_XT2000 || ZORRO
> > +
> > ---help---
>
> I removed that extraneous white-space-only line before "--help--"
>
Sorry about that Dave, that was not intended. Thanks
[-- Attachment #2: This is a digitally signed message part --]
[-- Type: application/pgp-signature, Size: 836 bytes --]
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2011-11-04 22:30 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2011-11-02 10:30 [net] i825xx:xscale:8390:freescale: Fix Kconfig dependancies Jeff Kirsher
2011-11-04 21:41 ` David Miller
2011-11-04 22:30 ` Jeff Kirsher
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).