From: Ben Hutchings <bhutchings@solarflare.com>
To: Stephen Hemminger <shemminger@vyatta.com>
Cc: Catherine Sullivan <catherine.sullivan@intel.com>,
<netdev@vger.kernel.org>
Subject: Re: [NET_NEXT RFC PATCH 3/3] ixgbe: added reg_ops file to debugfs
Date: Thu, 10 May 2012 01:18:10 +0100 [thread overview]
Message-ID: <1336609090.2499.18.camel@bwh-desktop.uk.solarflarecom.com> (raw)
In-Reply-To: <20120509161449.43704ea7@nehalam.linuxnetplumber.net>
On Wed, 2012-05-09 at 16:14 -0700, Stephen Hemminger wrote:
> On Wed, 09 May 2012 16:09:50 -0700
> Catherine Sullivan <catherine.sullivan@intel.com> wrote:
>
> > Added the reg_ops file to debugfs with commands to read and write
> > a register to give users the ability to read and write individual
> > registers on the fly.
> >
> > Signed-off-by: Catherine Sullivan <catherine.sullivan@intel.com>
> > ---
> >
> > drivers/net/ethernet/intel/ixgbe/ixgbe_debugfs.c | 112 ++++++++++++++++++++++
> > 1 files changed, 112 insertions(+), 0 deletions(-)
> >
>
> Aren't these registers already in ethtool?
ethtool register access is read-only and would be very heavy-weight for
interactive debugging. Not sure this is the best interface to
read/write registers, but it's certainly not redundant.
> You are also allowing write without any security checking.
The file permissions are set to 0600 so it's root-only.
Ben.
--
Ben Hutchings, Staff Engineer, Solarflare
Not speaking for my employer; that's the marketing department's job.
They asked us to note that Solarflare product names are trademarked.
next prev parent reply other threads:[~2012-05-10 0:18 UTC|newest]
Thread overview: 17+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-05-09 23:09 [NET_NEXT RFC PATCH 0/3] Series short description Catherine Sullivan
2012-05-09 23:09 ` [NET_NEXT RFC PATCH 1/3] ixgbe: add debugfs support Catherine Sullivan
2012-05-09 23:10 ` Stephen Hemminger
2012-05-18 17:10 ` Sullivan, Catherine
2012-05-09 23:09 ` [NET_NEXT RFC PATCH 2/3] ixgbe: added netdev_ops file to debugfs Catherine Sullivan
2012-05-09 23:10 ` Stephen Hemminger
2012-05-09 23:13 ` Stephen Hemminger
2012-05-10 20:28 ` Sullivan, Catherine
2012-05-10 20:32 ` David Miller
2012-05-10 21:14 ` Sullivan, Catherine
2012-05-10 21:21 ` David Miller
2012-05-10 21:35 ` Stephen Hemminger
2012-05-10 22:29 ` Sullivan, Catherine
2012-05-09 23:09 ` [NET_NEXT RFC PATCH 3/3] ixgbe: added reg_ops " Catherine Sullivan
2012-05-09 23:14 ` Stephen Hemminger
2012-05-10 0:18 ` Ben Hutchings [this message]
2012-05-10 3:54 ` Stephen Hemminger
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1336609090.2499.18.camel@bwh-desktop.uk.solarflarecom.com \
--to=bhutchings@solarflare.com \
--cc=catherine.sullivan@intel.com \
--cc=netdev@vger.kernel.org \
--cc=shemminger@vyatta.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).