netdev.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Stephen Hemminger <shemminger@vyatta.com>
To: Catherine Sullivan <catherine.sullivan@intel.com>
Cc: netdev@vger.kernel.org
Subject: Re: [NET_NEXT RFC PATCH 2/3] ixgbe: added netdev_ops file to debugfs
Date: Wed, 9 May 2012 16:13:20 -0700	[thread overview]
Message-ID: <20120509161320.37fcb705@nehalam.linuxnetplumber.net> (raw)
In-Reply-To: <20120509230945.31910.48302.stgit@localhost6.localdomain6>

On Wed, 09 May 2012 16:09:45 -0700
Catherine Sullivan <catherine.sullivan@intel.com> wrote:

> Added the netdev_ops file to debugfs with a command to call the
> ndo_tx_timeout function to give users the ability to simulate a
> tx_timeout call made by the kernel.
> 
> Signed-off-by: Catherine Sullivan <catherine.sullivan@intel.com>

What is the justification for creating a new API here?

Your exposing only one thing 'tx_timeout' and that is a generic property
of the device (not ixgbe specific). That value is already available via
sysfs.

  parent reply	other threads:[~2012-05-09 23:13 UTC|newest]

Thread overview: 17+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2012-05-09 23:09 [NET_NEXT RFC PATCH 0/3] Series short description Catherine Sullivan
2012-05-09 23:09 ` [NET_NEXT RFC PATCH 1/3] ixgbe: add debugfs support Catherine Sullivan
2012-05-09 23:10   ` Stephen Hemminger
2012-05-18 17:10     ` Sullivan, Catherine
2012-05-09 23:09 ` [NET_NEXT RFC PATCH 2/3] ixgbe: added netdev_ops file to debugfs Catherine Sullivan
2012-05-09 23:10   ` Stephen Hemminger
2012-05-09 23:13   ` Stephen Hemminger [this message]
2012-05-10 20:28     ` Sullivan, Catherine
2012-05-10 20:32       ` David Miller
2012-05-10 21:14         ` Sullivan, Catherine
2012-05-10 21:21           ` David Miller
2012-05-10 21:35           ` Stephen Hemminger
2012-05-10 22:29             ` Sullivan, Catherine
2012-05-09 23:09 ` [NET_NEXT RFC PATCH 3/3] ixgbe: added reg_ops " Catherine Sullivan
2012-05-09 23:14   ` Stephen Hemminger
2012-05-10  0:18     ` Ben Hutchings
2012-05-10  3:54       ` Stephen Hemminger

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20120509161320.37fcb705@nehalam.linuxnetplumber.net \
    --to=shemminger@vyatta.com \
    --cc=catherine.sullivan@intel.com \
    --cc=netdev@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).