* [PATCH 00/14] Modify signed comparisons of unsigned variables
@ 2012-11-16 6:50 Tushar Behera
2012-11-16 6:50 ` [PATCH 08/14] xen: netback: Remove redundant check on unsigned variable Tushar Behera
` (2 more replies)
0 siblings, 3 replies; 11+ messages in thread
From: Tushar Behera @ 2012-11-16 6:50 UTC (permalink / raw)
To: linux-kernel
Cc: patches, Mauro Carvalho Chehab, Linus Walleij, Ian Campbell,
Konrad Rzeszutek Wilk, Jeremy Fitzhardinge, Chas Williams,
Jack Steiner, Arnd Bergmann, Luciano Coelho, Jiri Kosina,
ivtv-devel, linux-media, xen-devel, netdev, virtualization,
linux-atm-general, linux-usb, linux-input, linux-wireless
The occurrences were identified through the coccinelle script at
following location.
http://www.emn.fr/z-info/coccinelle/rules/find_unsigned.cocci
Signed checks for unsigned variables are removed if it is also checked
for upper error limit. For error checks, IS_ERR_VALUE() macros is used.
Tushar Behera (14):
[media] ivtv: Remove redundant check on unsigned variable
[media] meye: Remove redundant check on unsigned variable
[media] saa7134: Remove redundant check on unsigned variable
[media] tlg2300: Remove redundant check on unsigned variable
[media] atmel-isi: Update error check for unsigned variables
pinctrl: samsung: Update error check for unsigned variables
pinctrl: SPEAr: Update error check for unsigned variables
xen: netback: Remove redundant check on unsigned variable
xen: events: Remove redundant check on unsigned variable
atm: Removed redundant check on unsigned variable
HID: hiddev: Remove redundant check on unsigned variable
gru: Remove redundant check on unsigned variable
misc: tsl2550: Remove redundant check on unsigned variable
wlcore: Remove redundant check on unsigned variable
drivers/atm/fore200e.c | 2 +-
drivers/hid/usbhid/hiddev.c | 2 +-
drivers/media/pci/ivtv/ivtv-ioctl.c | 2 +-
drivers/media/pci/meye/meye.c | 2 +-
drivers/media/pci/saa7134/saa7134-video.c | 2 +-
drivers/media/platform/soc_camera/atmel-isi.c | 2 +-
drivers/media/usb/tlg2300/pd-video.c | 2 +-
drivers/misc/sgi-gru/grukdump.c | 2 +-
drivers/misc/tsl2550.c | 4 ++--
drivers/net/wireless/ti/wlcore/debugfs.c | 2 +-
drivers/net/xen-netback/netback.c | 4 ++--
drivers/pinctrl/pinctrl-samsung.c | 2 +-
drivers/pinctrl/spear/pinctrl-plgpio.c | 2 +-
drivers/xen/events.c | 2 +-
14 files changed, 16 insertions(+), 16 deletions(-)
--
1.7.4.1
CC: Mauro Carvalho Chehab <mchehab@infradead.org>
CC: Linus Walleij <linus.walleij@linaro.org>
CC: Ian Campbell <ian.campbell@citrix.com>
CC: Konrad Rzeszutek Wilk <konrad.wilk@oracle.com>
CC: Jeremy Fitzhardinge <jeremy@goop.org>
CC: Chas Williams <chas@cmf.nrl.navy.mil>
CC: Jack Steiner <steiner@sgi.com>
CC: Arnd Bergmann <arnd@arndb.de>
CC: Luciano Coelho <coelho@ti.com>
CC: Jiri Kosina <jkosina@suse.cz>
CC: ivtv-devel@ivtvdriver.org
CC: linux-media@vger.kernel.org
CC: xen-devel@lists.xensource.com
CC: netdev@vger.kernel.org
CC: virtualization@lists.linux-foundation.org
CC: linux-atm-general@lists.sourceforge.net
CC: linux-usb@vger.kernel.org
CC: linux-input@vger.kernel.org
CC: linux-wireless@vger.kernel.org
^ permalink raw reply [flat|nested] 11+ messages in thread
* [PATCH 08/14] xen: netback: Remove redundant check on unsigned variable
2012-11-16 6:50 [PATCH 00/14] Modify signed comparisons of unsigned variables Tushar Behera
@ 2012-11-16 6:50 ` Tushar Behera
2012-11-16 9:16 ` Ian Campbell
2012-11-16 6:50 ` [PATCH 10/14] atm: Removed " Tushar Behera
2012-11-16 6:50 ` [PATCH 14/14] wlcore: Remove " Tushar Behera
2 siblings, 1 reply; 11+ messages in thread
From: Tushar Behera @ 2012-11-16 6:50 UTC (permalink / raw)
To: linux-kernel; +Cc: patches, Ian Campbell, xen-devel, netdev
No need to check whether unsigned variable is less than 0.
CC: Ian Campbell <ian.campbell@citrix.com>
CC: xen-devel@lists.xensource.com
CC: netdev@vger.kernel.org
Signed-off-by: Tushar Behera <tushar.behera@linaro.org>
---
drivers/net/xen-netback/netback.c | 4 ++--
1 files changed, 2 insertions(+), 2 deletions(-)
diff --git a/drivers/net/xen-netback/netback.c b/drivers/net/xen-netback/netback.c
index aab8677..515e10c 100644
--- a/drivers/net/xen-netback/netback.c
+++ b/drivers/net/xen-netback/netback.c
@@ -190,14 +190,14 @@ static int get_page_ext(struct page *pg,
group = ext.e.group - 1;
- if (group < 0 || group >= xen_netbk_group_nr)
+ if (group >= xen_netbk_group_nr)
return 0;
netbk = &xen_netbk[group];
idx = ext.e.idx;
- if ((idx < 0) || (idx >= MAX_PENDING_REQS))
+ if (idx >= MAX_PENDING_REQS)
return 0;
if (netbk->mmap_pages[idx] != pg)
--
1.7.4.1
^ permalink raw reply related [flat|nested] 11+ messages in thread
* [PATCH 10/14] atm: Removed redundant check on unsigned variable
2012-11-16 6:50 [PATCH 00/14] Modify signed comparisons of unsigned variables Tushar Behera
2012-11-16 6:50 ` [PATCH 08/14] xen: netback: Remove redundant check on unsigned variable Tushar Behera
@ 2012-11-16 6:50 ` Tushar Behera
2012-12-28 5:16 ` Tushar Behera
2012-11-16 6:50 ` [PATCH 14/14] wlcore: Remove " Tushar Behera
2 siblings, 1 reply; 11+ messages in thread
From: Tushar Behera @ 2012-11-16 6:50 UTC (permalink / raw)
To: linux-kernel; +Cc: patches, Chas Williams, linux-atm-general, netdev
No need to check whether unsigned variable is less than 0.
CC: Chas Williams <chas@cmf.nrl.navy.mil>
CC: linux-atm-general@lists.sourceforge.net
CC: netdev@vger.kernel.org
Signed-off-by: Tushar Behera <tushar.behera@linaro.org>
---
drivers/atm/fore200e.c | 2 +-
1 files changed, 1 insertions(+), 1 deletions(-)
diff --git a/drivers/atm/fore200e.c b/drivers/atm/fore200e.c
index 361f5ae..fdd3fe7 100644
--- a/drivers/atm/fore200e.c
+++ b/drivers/atm/fore200e.c
@@ -972,7 +972,7 @@ int bsq_audit(int where, struct host_bsq* bsq, int scheme, int magn)
where, scheme, magn, buffer->index, buffer->scheme);
}
- if ((buffer->index < 0) || (buffer->index >= fore200e_rx_buf_nbr[ scheme ][ magn ])) {
+ if (buffer->index >= fore200e_rx_buf_nbr[ scheme ][ magn ]) {
printk(FORE200E "bsq_audit(%d): queue %d.%d, out of range buffer index = %ld !\n",
where, scheme, magn, buffer->index);
}
--
1.7.4.1
^ permalink raw reply related [flat|nested] 11+ messages in thread
* [PATCH 14/14] wlcore: Remove redundant check on unsigned variable
2012-11-16 6:50 [PATCH 00/14] Modify signed comparisons of unsigned variables Tushar Behera
2012-11-16 6:50 ` [PATCH 08/14] xen: netback: Remove redundant check on unsigned variable Tushar Behera
2012-11-16 6:50 ` [PATCH 10/14] atm: Removed " Tushar Behera
@ 2012-11-16 6:50 ` Tushar Behera
2012-11-16 18:24 ` Luciano Coelho
2 siblings, 1 reply; 11+ messages in thread
From: Tushar Behera @ 2012-11-16 6:50 UTC (permalink / raw)
To: linux-kernel; +Cc: patches, Luciano Coelho, linux-wireless, netdev
No need to check whether unsigned variable is less than 0.
CC: Luciano Coelho <coelho@ti.com>
CC: linux-wireless@vger.kernel.org
CC: netdev@vger.kernel.org
Signed-off-by: Tushar Behera <tushar.behera@linaro.org>
---
drivers/net/wireless/ti/wlcore/debugfs.c | 2 +-
1 files changed, 1 insertions(+), 1 deletions(-)
diff --git a/drivers/net/wireless/ti/wlcore/debugfs.c b/drivers/net/wireless/ti/wlcore/debugfs.c
index c86bb00..93f801d 100644
--- a/drivers/net/wireless/ti/wlcore/debugfs.c
+++ b/drivers/net/wireless/ti/wlcore/debugfs.c
@@ -993,7 +993,7 @@ static ssize_t sleep_auth_write(struct file *file,
return -EINVAL;
}
- if (value < 0 || value > WL1271_PSM_MAX) {
+ if (value > WL1271_PSM_MAX) {
wl1271_warning("sleep_auth must be between 0 and %d",
WL1271_PSM_MAX);
return -ERANGE;
--
1.7.4.1
^ permalink raw reply related [flat|nested] 11+ messages in thread
* Re: [PATCH 08/14] xen: netback: Remove redundant check on unsigned variable
2012-11-16 6:50 ` [PATCH 08/14] xen: netback: Remove redundant check on unsigned variable Tushar Behera
@ 2012-11-16 9:16 ` Ian Campbell
2012-12-28 5:15 ` Tushar Behera
0 siblings, 1 reply; 11+ messages in thread
From: Ian Campbell @ 2012-11-16 9:16 UTC (permalink / raw)
To: Tushar Behera; +Cc: linux-kernel, patches, xen-devel, netdev
On Fri, 2012-11-16 at 06:50 +0000, Tushar Behera wrote:
> No need to check whether unsigned variable is less than 0.
>
> CC: Ian Campbell <ian.campbell@citrix.com>
> CC: xen-devel@lists.xensource.com
> CC: netdev@vger.kernel.org
> Signed-off-by: Tushar Behera <tushar.behera@linaro.org>
Acked-by: Ian Campbell <ian.campbell@citrix.com>
Thanks.
> ---
> drivers/net/xen-netback/netback.c | 4 ++--
> 1 files changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/drivers/net/xen-netback/netback.c b/drivers/net/xen-netback/netback.c
> index aab8677..515e10c 100644
> --- a/drivers/net/xen-netback/netback.c
> +++ b/drivers/net/xen-netback/netback.c
> @@ -190,14 +190,14 @@ static int get_page_ext(struct page *pg,
>
> group = ext.e.group - 1;
>
> - if (group < 0 || group >= xen_netbk_group_nr)
> + if (group >= xen_netbk_group_nr)
> return 0;
>
> netbk = &xen_netbk[group];
>
> idx = ext.e.idx;
>
> - if ((idx < 0) || (idx >= MAX_PENDING_REQS))
> + if (idx >= MAX_PENDING_REQS)
> return 0;
>
> if (netbk->mmap_pages[idx] != pg)
^ permalink raw reply [flat|nested] 11+ messages in thread
* Re: [PATCH 14/14] wlcore: Remove redundant check on unsigned variable
2012-11-16 6:50 ` [PATCH 14/14] wlcore: Remove " Tushar Behera
@ 2012-11-16 18:24 ` Luciano Coelho
0 siblings, 0 replies; 11+ messages in thread
From: Luciano Coelho @ 2012-11-16 18:24 UTC (permalink / raw)
To: Tushar Behera; +Cc: linux-kernel, patches, linux-wireless, netdev
On Fri, 2012-11-16 at 12:20 +0530, Tushar Behera wrote:
> No need to check whether unsigned variable is less than 0.
>
> CC: Luciano Coelho <coelho@ti.com>
> CC: linux-wireless@vger.kernel.org
> CC: netdev@vger.kernel.org
> Signed-off-by: Tushar Behera <tushar.behera@linaro.org>
> ---
Applied in the wl12xx.git tree. Thanks!
--
Luca.
^ permalink raw reply [flat|nested] 11+ messages in thread
* Re: [PATCH 08/14] xen: netback: Remove redundant check on unsigned variable
2012-11-16 9:16 ` Ian Campbell
@ 2012-12-28 5:15 ` Tushar Behera
2012-12-28 10:41 ` [Xen-devel] " Wei Liu
0 siblings, 1 reply; 11+ messages in thread
From: Tushar Behera @ 2012-12-28 5:15 UTC (permalink / raw)
To: Ian Campbell; +Cc: linux-kernel, patches, xen-devel, netdev
On 11/16/2012 02:46 PM, Ian Campbell wrote:
> On Fri, 2012-11-16 at 06:50 +0000, Tushar Behera wrote:
>> No need to check whether unsigned variable is less than 0.
>>
>> CC: Ian Campbell <ian.campbell@citrix.com>
>> CC: xen-devel@lists.xensource.com
>> CC: netdev@vger.kernel.org
>> Signed-off-by: Tushar Behera <tushar.behera@linaro.org>
>
> Acked-by: Ian Campbell <ian.campbell@citrix.com>
>
> Thanks.
>
This patch was not picked up for 3.8-rc1. Any idea, who should pick this up?
>> ---
>> drivers/net/xen-netback/netback.c | 4 ++--
>> 1 files changed, 2 insertions(+), 2 deletions(-)
>>
>> diff --git a/drivers/net/xen-netback/netback.c b/drivers/net/xen-netback/netback.c
>> index aab8677..515e10c 100644
>> --- a/drivers/net/xen-netback/netback.c
>> +++ b/drivers/net/xen-netback/netback.c
>> @@ -190,14 +190,14 @@ static int get_page_ext(struct page *pg,
>>
>> group = ext.e.group - 1;
>>
>> - if (group < 0 || group >= xen_netbk_group_nr)
>> + if (group >= xen_netbk_group_nr)
>> return 0;
>>
>> netbk = &xen_netbk[group];
>>
>> idx = ext.e.idx;
>>
>> - if ((idx < 0) || (idx >= MAX_PENDING_REQS))
>> + if (idx >= MAX_PENDING_REQS)
>> return 0;
>>
>> if (netbk->mmap_pages[idx] != pg)
>
>
--
Tushar Behera
^ permalink raw reply [flat|nested] 11+ messages in thread
* Re: [PATCH 10/14] atm: Removed redundant check on unsigned variable
2012-11-16 6:50 ` [PATCH 10/14] atm: Removed " Tushar Behera
@ 2012-12-28 5:16 ` Tushar Behera
2012-12-31 15:18 ` chas williams - CONTRACTOR
0 siblings, 1 reply; 11+ messages in thread
From: Tushar Behera @ 2012-12-28 5:16 UTC (permalink / raw)
To: linux-kernel; +Cc: patches, Chas Williams, linux-atm-general, netdev
Ping.
On 11/16/2012 12:20 PM, Tushar Behera wrote:
> No need to check whether unsigned variable is less than 0.
>
> CC: Chas Williams <chas@cmf.nrl.navy.mil>
> CC: linux-atm-general@lists.sourceforge.net
> CC: netdev@vger.kernel.org
> Signed-off-by: Tushar Behera <tushar.behera@linaro.org>
> ---
> drivers/atm/fore200e.c | 2 +-
> 1 files changed, 1 insertions(+), 1 deletions(-)
>
> diff --git a/drivers/atm/fore200e.c b/drivers/atm/fore200e.c
> index 361f5ae..fdd3fe7 100644
> --- a/drivers/atm/fore200e.c
> +++ b/drivers/atm/fore200e.c
> @@ -972,7 +972,7 @@ int bsq_audit(int where, struct host_bsq* bsq, int scheme, int magn)
> where, scheme, magn, buffer->index, buffer->scheme);
> }
>
> - if ((buffer->index < 0) || (buffer->index >= fore200e_rx_buf_nbr[ scheme ][ magn ])) {
> + if (buffer->index >= fore200e_rx_buf_nbr[ scheme ][ magn ]) {
> printk(FORE200E "bsq_audit(%d): queue %d.%d, out of range buffer index = %ld !\n",
> where, scheme, magn, buffer->index);
> }
>
--
Tushar Behera
^ permalink raw reply [flat|nested] 11+ messages in thread
* Re: [Xen-devel] [PATCH 08/14] xen: netback: Remove redundant check on unsigned variable
2012-12-28 5:15 ` Tushar Behera
@ 2012-12-28 10:41 ` Wei Liu
2013-01-02 21:40 ` Konrad Rzeszutek Wilk
0 siblings, 1 reply; 11+ messages in thread
From: Wei Liu @ 2012-12-28 10:41 UTC (permalink / raw)
To: Tushar Behera
Cc: wei.liu2, Ian Campbell, netdev, xen-devel, linux-kernel, patches,
konrad.wilk
On Fri, 2012-12-28 at 05:15 +0000, Tushar Behera wrote:
> On 11/16/2012 02:46 PM, Ian Campbell wrote:
> > On Fri, 2012-11-16 at 06:50 +0000, Tushar Behera wrote:
> >> No need to check whether unsigned variable is less than 0.
> >>
> >> CC: Ian Campbell <ian.campbell@citrix.com>
> >> CC: xen-devel@lists.xensource.com
> >> CC: netdev@vger.kernel.org
> >> Signed-off-by: Tushar Behera <tushar.behera@linaro.org>
> >
> > Acked-by: Ian Campbell <ian.campbell@citrix.com>
> >
> > Thanks.
> >
>
> This patch was not picked up for 3.8-rc1. Any idea, who should pick this up?
CC'ing Konrad.
^ permalink raw reply [flat|nested] 11+ messages in thread
* Re: [PATCH 10/14] atm: Removed redundant check on unsigned variable
2012-12-28 5:16 ` Tushar Behera
@ 2012-12-31 15:18 ` chas williams - CONTRACTOR
0 siblings, 0 replies; 11+ messages in thread
From: chas williams - CONTRACTOR @ 2012-12-31 15:18 UTC (permalink / raw)
To: Tushar Behera; +Cc: linux-kernel, patches, linux-atm-general, netdev
Acked-by: chas williams - CONTRACTOR <chas@cmf.nrl.navy.mil>
On Fri, 28 Dec 2012 10:46:36 +0530
Tushar Behera <tushar.behera@linaro.org> wrote:
> Ping.
>
> On 11/16/2012 12:20 PM, Tushar Behera wrote:
> > No need to check whether unsigned variable is less than 0.
> >
> > CC: Chas Williams <chas@cmf.nrl.navy.mil>
> > CC: linux-atm-general@lists.sourceforge.net
> > CC: netdev@vger.kernel.org
> > Signed-off-by: Tushar Behera <tushar.behera@linaro.org>
> > ---
> > drivers/atm/fore200e.c | 2 +-
> > 1 files changed, 1 insertions(+), 1 deletions(-)
> >
> > diff --git a/drivers/atm/fore200e.c b/drivers/atm/fore200e.c
> > index 361f5ae..fdd3fe7 100644
> > --- a/drivers/atm/fore200e.c
> > +++ b/drivers/atm/fore200e.c
> > @@ -972,7 +972,7 @@ int bsq_audit(int where, struct host_bsq* bsq, int scheme, int magn)
> > where, scheme, magn, buffer->index, buffer->scheme);
> > }
> >
> > - if ((buffer->index < 0) || (buffer->index >= fore200e_rx_buf_nbr[ scheme ][ magn ])) {
> > + if (buffer->index >= fore200e_rx_buf_nbr[ scheme ][ magn ]) {
> > printk(FORE200E "bsq_audit(%d): queue %d.%d, out of range buffer index = %ld !\n",
> > where, scheme, magn, buffer->index);
> > }
> >
>
>
^ permalink raw reply [flat|nested] 11+ messages in thread
* Re: [Xen-devel] [PATCH 08/14] xen: netback: Remove redundant check on unsigned variable
2012-12-28 10:41 ` [Xen-devel] " Wei Liu
@ 2013-01-02 21:40 ` Konrad Rzeszutek Wilk
0 siblings, 0 replies; 11+ messages in thread
From: Konrad Rzeszutek Wilk @ 2013-01-02 21:40 UTC (permalink / raw)
To: Wei Liu, davem
Cc: Tushar Behera, Ian Campbell, netdev, xen-devel, linux-kernel, patches
On Fri, Dec 28, 2012 at 10:41:32AM +0000, Wei Liu wrote:
> On Fri, 2012-12-28 at 05:15 +0000, Tushar Behera wrote:
> > On 11/16/2012 02:46 PM, Ian Campbell wrote:
> > > On Fri, 2012-11-16 at 06:50 +0000, Tushar Behera wrote:
> > >> No need to check whether unsigned variable is less than 0.
> > >>
> > >> CC: Ian Campbell <ian.campbell@citrix.com>
> > >> CC: xen-devel@lists.xensource.com
> > >> CC: netdev@vger.kernel.org
> > >> Signed-off-by: Tushar Behera <tushar.behera@linaro.org>
> > >
> > > Acked-by: Ian Campbell <ian.campbell@citrix.com>
> > >
> > > Thanks.
> > >
> >
> > This patch was not picked up for 3.8-rc1. Any idea, who should pick this up?
>
> CC'ing Konrad.
>
And CC-ing the network maintainer. David, Ian (who is the sub-maintainer
of xen-netback) has Acked the patch.
I can put this in my queue if you would like.
^ permalink raw reply [flat|nested] 11+ messages in thread
end of thread, other threads:[~2013-01-02 21:40 UTC | newest]
Thread overview: 11+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2012-11-16 6:50 [PATCH 00/14] Modify signed comparisons of unsigned variables Tushar Behera
2012-11-16 6:50 ` [PATCH 08/14] xen: netback: Remove redundant check on unsigned variable Tushar Behera
2012-11-16 9:16 ` Ian Campbell
2012-12-28 5:15 ` Tushar Behera
2012-12-28 10:41 ` [Xen-devel] " Wei Liu
2013-01-02 21:40 ` Konrad Rzeszutek Wilk
2012-11-16 6:50 ` [PATCH 10/14] atm: Removed " Tushar Behera
2012-12-28 5:16 ` Tushar Behera
2012-12-31 15:18 ` chas williams - CONTRACTOR
2012-11-16 6:50 ` [PATCH 14/14] wlcore: Remove " Tushar Behera
2012-11-16 18:24 ` Luciano Coelho
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).