* [PATCH 1/1] net: rfkill: Fix sparse warning in rfkill-regulator.c
@ 2013-02-19 9:57 Sachin Kamat
2013-02-20 10:08 ` Johannes Berg
0 siblings, 1 reply; 3+ messages in thread
From: Sachin Kamat @ 2013-02-19 9:57 UTC (permalink / raw)
To: netdev, linux-wireless; +Cc: davem, linville, johannes, sachin.kamat
'rfkill_regulator_ops' is used only in this file. Hence make it static.
Silences the following warning:
net/rfkill/rfkill-regulator.c:54:19: warning:
symbol 'rfkill_regulator_ops' was not declared. Should it be static?
Signed-off-by: Sachin Kamat <sachin.kamat@linaro.org>
---
net/rfkill/rfkill-regulator.c | 2 +-
1 files changed, 1 insertions(+), 1 deletions(-)
diff --git a/net/rfkill/rfkill-regulator.c b/net/rfkill/rfkill-regulator.c
index 4b5ab21..d11ac79 100644
--- a/net/rfkill/rfkill-regulator.c
+++ b/net/rfkill/rfkill-regulator.c
@@ -51,7 +51,7 @@ static int rfkill_regulator_set_block(void *data, bool blocked)
return 0;
}
-struct rfkill_ops rfkill_regulator_ops = {
+static struct rfkill_ops rfkill_regulator_ops = {
.set_block = rfkill_regulator_set_block,
};
--
1.7.4.1
^ permalink raw reply related [flat|nested] 3+ messages in thread
* Re: [PATCH 1/1] net: rfkill: Fix sparse warning in rfkill-regulator.c
2013-02-19 9:57 [PATCH 1/1] net: rfkill: Fix sparse warning in rfkill-regulator.c Sachin Kamat
@ 2013-02-20 10:08 ` Johannes Berg
[not found] ` <1361354928.8629.17.camel-8Nb76shvtaUJvtFkdXX2HixXY32XiHfO@public.gmane.org>
0 siblings, 1 reply; 3+ messages in thread
From: Johannes Berg @ 2013-02-20 10:08 UTC (permalink / raw)
To: Sachin Kamat; +Cc: netdev, linux-wireless, davem, linville
On Tue, 2013-02-19 at 15:27 +0530, Sachin Kamat wrote:
> 'rfkill_regulator_ops' is used only in this file. Hence make it static.
> Silences the following warning:
> net/rfkill/rfkill-regulator.c:54:19: warning:
> symbol 'rfkill_regulator_ops' was not declared. Should it be static?
I'll take this, but it isn't going anywhere until the merge window opens
again.
johannes
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [PATCH 1/1] net: rfkill: Fix sparse warning in rfkill-regulator.c
[not found] ` <1361354928.8629.17.camel-8Nb76shvtaUJvtFkdXX2HixXY32XiHfO@public.gmane.org>
@ 2013-02-20 10:09 ` Johannes Berg
0 siblings, 0 replies; 3+ messages in thread
From: Johannes Berg @ 2013-02-20 10:09 UTC (permalink / raw)
To: Sachin Kamat
Cc: netdev-u79uwXL29TY76Z2rM5mHXA,
linux-wireless-u79uwXL29TY76Z2rM5mHXA,
davem-fT/PcQaiUtIeIZ0/mPfg9Q, linville-2XuSBdqkA4R54TAoqtyWWQ
On Wed, 2013-02-20 at 11:08 +0100, Johannes Berg wrote:
> On Tue, 2013-02-19 at 15:27 +0530, Sachin Kamat wrote:
> > 'rfkill_regulator_ops' is used only in this file. Hence make it static.
> > Silences the following warning:
> > net/rfkill/rfkill-regulator.c:54:19: warning:
> > symbol 'rfkill_regulator_ops' was not declared. Should it be static?
>
> I'll take this, but it isn't going anywhere until the merge window opens
> again.
Err, I mean closes, and we open -next.
johannes
--
To unsubscribe from this list: send the line "unsubscribe linux-wireless" in
the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2013-02-20 10:09 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2013-02-19 9:57 [PATCH 1/1] net: rfkill: Fix sparse warning in rfkill-regulator.c Sachin Kamat
2013-02-20 10:08 ` Johannes Berg
[not found] ` <1361354928.8629.17.camel-8Nb76shvtaUJvtFkdXX2HixXY32XiHfO@public.gmane.org>
2013-02-20 10:09 ` Johannes Berg
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).