* Re: Build regressions/improvements in v3.10-rc1 (s390)
[not found] ` <alpine.DEB.2.00.1305122250110.5463@ayla.of.borg>
@ 2013-05-13 7:41 ` Heiko Carstens
2013-05-13 16:41 ` Ben Hutchings
0 siblings, 1 reply; 2+ messages in thread
From: Heiko Carstens @ 2013-05-13 7:41 UTC (permalink / raw)
To: Geert Uytterhoeven, linux-net-drivers, Ben Hutchings, Stuart Hodgson
Cc: Linux Kernel Development, linux-s390, netdev
On Sun, May 12, 2013 at 10:50:45PM +0200, Geert Uytterhoeven wrote:
> On Sun, 12 May 2013, Geert Uytterhoeven wrote:
> > However, the full list of errors isn't that unmanageable, so I'm following
> > up with a digested list...
>
> drivers/net/ethernet/sfc/efx.c:646:3: error: call to '__compiletime_assert_648' declared with attribute error: BUILD_BUG_ON failed: sizeof(struct efx_rx_page_state) + EFX_PAGE_IP_ALIGN + EFX_RX_USR_BUF_SIZE > PAGE_SIZE / 2: 2 errors in 2 logs
> v3.10-rc1/s390x/s390-allyesconfig v3.10-rc1/s390x/s390-allmodconfig
that seems to a BUILD_BUG_ON that only triggers on s390, because we have
L1_CACHE_BYTES defined with 256 bytes... which seems to be more than any
other architecture has.
There was a different network driver that had a similar BUILD_BUG_ON, but
it got removed.
Right, it was the igb driver:
http://comments.gmane.org/gmane.linux.network/261378
^ permalink raw reply [flat|nested] 2+ messages in thread
* Re: Build regressions/improvements in v3.10-rc1 (s390)
2013-05-13 7:41 ` Build regressions/improvements in v3.10-rc1 (s390) Heiko Carstens
@ 2013-05-13 16:41 ` Ben Hutchings
0 siblings, 0 replies; 2+ messages in thread
From: Ben Hutchings @ 2013-05-13 16:41 UTC (permalink / raw)
To: Heiko Carstens
Cc: Geert Uytterhoeven, linux-net-drivers, Stuart Hodgson,
Linux Kernel Development, linux-s390, netdev
On Mon, 2013-05-13 at 09:41 +0200, Heiko Carstens wrote:
> On Sun, May 12, 2013 at 10:50:45PM +0200, Geert Uytterhoeven wrote:
> > On Sun, 12 May 2013, Geert Uytterhoeven wrote:
> > > However, the full list of errors isn't that unmanageable, so I'm following
> > > up with a digested list...
> >
> > drivers/net/ethernet/sfc/efx.c:646:3: error: call to '__compiletime_assert_648' declared with attribute error: BUILD_BUG_ON failed: sizeof(struct efx_rx_page_state) + EFX_PAGE_IP_ALIGN + EFX_RX_USR_BUF_SIZE > PAGE_SIZE / 2: 2 errors in 2 logs
> > v3.10-rc1/s390x/s390-allyesconfig v3.10-rc1/s390x/s390-allmodconfig
>
> that seems to a BUILD_BUG_ON that only triggers on s390, because we have
> L1_CACHE_BYTES defined with 256 bytes... which seems to be more than any
> other architecture has.
> There was a different network driver that had a similar BUILD_BUG_ON, but
> it got removed.
>
> Right, it was the igb driver:
> http://comments.gmane.org/gmane.linux.network/261378
The critical value here is EFX_RX_USR_BUF_SIZE. The hardware constrains
it to be a multiple of 32, but for performance reasons it also ought to
be a multiple of the cache line size(s). In our internal development
branch it has already been reduced to 1792, which is a multiple of 256
and should satisfy the BUILD_BUG_ON check. I'll post a patch shortly.
Ben.
--
Ben Hutchings, Staff Engineer, Solarflare
Not speaking for my employer; that's the marketing department's job.
They asked us to note that Solarflare product names are trademarked.
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2013-05-13 16:41 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
[not found] <alpine.DEB.2.00.1305122130270.3789@ayla.of.borg>
[not found] ` <alpine.DEB.2.00.1305122239040.5463@ayla.of.borg>
[not found] ` <alpine.DEB.2.00.1305122250110.5463@ayla.of.borg>
2013-05-13 7:41 ` Build regressions/improvements in v3.10-rc1 (s390) Heiko Carstens
2013-05-13 16:41 ` Ben Hutchings
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).