* [PATCH] mv643xx_eth: fix NAPI weight being > 64
@ 2013-05-14 5:17 Andrew Lunn
2013-05-14 7:48 ` David Miller
0 siblings, 1 reply; 2+ messages in thread
From: Andrew Lunn @ 2013-05-14 5:17 UTC (permalink / raw)
To: davem, buytenh, Jason Cooper; +Cc: linux ARM, netdev, Andrew Lunn
3.10-rc1 issues the following warning:
netif_napi_add() called with weight 128 on device eth%d
This patch reduce the weight to 64.
Signed-off-by: Andrew Lunn <andrew@lunn.ch>
---
drivers/net/ethernet/marvell/mv643xx_eth.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/net/ethernet/marvell/mv643xx_eth.c b/drivers/net/ethernet/marvell/mv643xx_eth.c
index d0afeea..6b5471f 100644
--- a/drivers/net/ethernet/marvell/mv643xx_eth.c
+++ b/drivers/net/ethernet/marvell/mv643xx_eth.c
@@ -2745,7 +2745,7 @@ static int mv643xx_eth_probe(struct platform_device *pdev)
INIT_WORK(&mp->tx_timeout_task, tx_timeout_task);
- netif_napi_add(dev, &mp->napi, mv643xx_eth_poll, 128);
+ netif_napi_add(dev, &mp->napi, mv643xx_eth_poll, 64);
init_timer(&mp->rx_oom);
mp->rx_oom.data = (unsigned long)mp;
--
1.7.10.4
^ permalink raw reply related [flat|nested] 2+ messages in thread
* Re: [PATCH] mv643xx_eth: fix NAPI weight being > 64
2013-05-14 5:17 [PATCH] mv643xx_eth: fix NAPI weight being > 64 Andrew Lunn
@ 2013-05-14 7:48 ` David Miller
0 siblings, 0 replies; 2+ messages in thread
From: David Miller @ 2013-05-14 7:48 UTC (permalink / raw)
To: andrew; +Cc: buytenh, jason, linux-arm-kernel, netdev
From: Andrew Lunn <andrew@lunn.ch>
Date: Tue, 14 May 2013 07:17:12 +0200
> 3.10-rc1 issues the following warning:
>
> netif_napi_add() called with weight 128 on device eth%d
>
> This patch reduce the weight to 64.
>
> Signed-off-by: Andrew Lunn <andrew@lunn.ch>
We have a macro, NAPI_POLL_WEIGHT, for this, please use it.
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2013-05-14 7:48 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2013-05-14 5:17 [PATCH] mv643xx_eth: fix NAPI weight being > 64 Andrew Lunn
2013-05-14 7:48 ` David Miller
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).