* [PATCH] NET: pch_gbe depends on x86
[not found] <51d48037.Zcczkb6ouQ0Nv+4v%fengguang.wu@intel.com>
@ 2013-07-19 6:26 ` Jiri Slaby
2013-07-22 21:51 ` David Miller
0 siblings, 1 reply; 2+ messages in thread
From: Jiri Slaby @ 2013-07-19 6:26 UTC (permalink / raw)
To: davem
Cc: linux-kernel, Jiri Slaby, Ben Hutchings, netdev,
Greg Kroah-Hartman, kbuild-all
Since 4bb1667255a86360721291fe59991d033bbc2f2a (build some drivers only
when compile-testing), PTP_1588_CLOCK_PCH depends on (X86 ||
COMPILE_TEST). But PCH_GBE selects PTP_1588_CLOCK_PCH without
depending on x86. Fix this by adding the same dependency here.
Signed-off-by: Jiri Slaby <jslaby@suse.cz>
Reported-by: <fengguang.wu@intel.com> [intel's build test robot]
Cc: "David S. Miller" <davem@davemloft.net>
Cc: Ben Hutchings <ben@decadent.org.uk>
Cc: netdev@vger.kernel.org
Cc: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Cc: kbuild-all@01.org
---
drivers/net/ethernet/oki-semi/pch_gbe/Kconfig | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/net/ethernet/oki-semi/pch_gbe/Kconfig b/drivers/net/ethernet/oki-semi/pch_gbe/Kconfig
index cb22341..a588ffd 100644
--- a/drivers/net/ethernet/oki-semi/pch_gbe/Kconfig
+++ b/drivers/net/ethernet/oki-semi/pch_gbe/Kconfig
@@ -4,7 +4,7 @@
config PCH_GBE
tristate "OKI SEMICONDUCTOR IOH(ML7223/ML7831) GbE"
- depends on PCI
+ depends on PCI && (X86 || COMPILE_TEST)
select MII
select PTP_1588_CLOCK_PCH
---help---
--
1.8.3.1
^ permalink raw reply related [flat|nested] 2+ messages in thread
* Re: [PATCH] NET: pch_gbe depends on x86
2013-07-19 6:26 ` [PATCH] NET: pch_gbe depends on x86 Jiri Slaby
@ 2013-07-22 21:51 ` David Miller
0 siblings, 0 replies; 2+ messages in thread
From: David Miller @ 2013-07-22 21:51 UTC (permalink / raw)
To: jslaby; +Cc: linux-kernel, ben, netdev, gregkh, kbuild-all
From: Jiri Slaby <jslaby@suse.cz>
Date: Fri, 19 Jul 2013 08:26:09 +0200
> Since 4bb1667255a86360721291fe59991d033bbc2f2a (build some drivers only
> when compile-testing), PTP_1588_CLOCK_PCH depends on (X86 ||
> COMPILE_TEST). But PCH_GBE selects PTP_1588_CLOCK_PCH without
> depending on x86. Fix this by adding the same dependency here.
>
> Signed-off-by: Jiri Slaby <jslaby@suse.cz>
> Reported-by: <fengguang.wu@intel.com> [intel's build test robot]
Applied, thanks.
Please use lowercase "net: " not uppercase "NET: " in your commit
subject lines. I fixed it for you this time.
Thank you.
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2013-07-22 21:51 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
[not found] <51d48037.Zcczkb6ouQ0Nv+4v%fengguang.wu@intel.com>
2013-07-19 6:26 ` [PATCH] NET: pch_gbe depends on x86 Jiri Slaby
2013-07-22 21:51 ` David Miller
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).