From: Ben Hutchings <ben@decadent.org.uk>
To: Vladimir Kondratiev <qca_vkondrat@qca.qualcomm.com>
Cc: thomas@fjellstrom.ca, Larry Finger <Larry.Finger@lwfinger.net>,
linville@tuxdriver.com, linux-wireless@vger.kernel.org,
netdev@vger.kernel.org, wil6210@qca.qualcomm.com,
Stable <stable@vger.kernel.org>
Subject: Re: [PATCH] ath: wil6210: Fix build error
Date: Mon, 22 Jul 2013 02:45:43 +0100 [thread overview]
Message-ID: <1374457543.16248.8.camel@deadeye.wl.decadent.org.uk> (raw)
In-Reply-To: <5330916.8NnOO4SNAp@lx-vladimir>
[-- Attachment #1: Type: text/plain, Size: 1257 bytes --]
On Sun, 2013-07-21 at 18:52 +0300, Vladimir Kondratiev wrote:
> On Sunday, July 21, 2013 09:35:40 AM Thomas Fjellstrom wrote:
> > If it helps, I'm running a fresh install of Debian Sid with gcc 4.8.1. I've
> > noticed that each newer successive version of gcc gets more strict with what
> > code it accepts without warning, or error. A lot of my only somewhat old code
> > tends to have a lot more warnings. Especially that signedness warning.
>
> Yes, this is the case; I have 4.7.3
>
> >
> > It also looked like that that driver or section of the kernel was compiling
> > with -Werror. I haven't verrified that but I remember seeing "treating all
> > warnings as errors" at one point.
> >
> You are right, I have this in Makefile:
> (if one turn on extra warnings with -W, there will be lots of false alarms,
> that's why this ifeq())
>
> ifeq (, $(findstring -W,$(EXTRA_CFLAGS)))
> subdir-ccflags-y += -Werror
> endif
This is a pretty weird thing to do, and you've failed to account for
-Wextra.
-Werror is generally a bad default in free software, as you have no
control over which compiler version will be used.
Ben.
--
Ben Hutchings
Once a job is fouled up, anything done to improve it makes it worse.
[-- Attachment #2: This is a digitally signed message part --]
[-- Type: application/pgp-signature, Size: 828 bytes --]
next prev parent reply other threads:[~2013-07-22 1:45 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-07-21 2:46 [PATCH] ath: wil6210: Fix build error Larry Finger
2013-07-21 7:06 ` Vladimir Kondratiev
2013-07-21 15:14 ` Larry Finger
[not found] ` <51EBFABB.8080701-tQ5ms3gMjBLk1uMJSBkQmQ@public.gmane.org>
2013-07-21 15:35 ` Thomas Fjellstrom
2013-07-21 15:52 ` Vladimir Kondratiev
2013-07-21 16:55 ` Kalle Valo
2013-07-22 1:45 ` Ben Hutchings [this message]
2013-07-22 9:56 ` Vladimir Kondratiev
2013-07-22 16:17 ` Luis R. Rodriguez
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1374457543.16248.8.camel@deadeye.wl.decadent.org.uk \
--to=ben@decadent.org.uk \
--cc=Larry.Finger@lwfinger.net \
--cc=linux-wireless@vger.kernel.org \
--cc=linville@tuxdriver.com \
--cc=netdev@vger.kernel.org \
--cc=qca_vkondrat@qca.qualcomm.com \
--cc=stable@vger.kernel.org \
--cc=thomas@fjellstrom.ca \
--cc=wil6210@qca.qualcomm.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).