From: Vladimir Kondratiev <qca_vkondrat@qca.qualcomm.com>
To: Ben Hutchings <ben@decadent.org.uk>
Cc: <thomas@fjellstrom.ca>, Larry Finger <Larry.Finger@lwfinger.net>,
<linville@tuxdriver.com>, <linux-wireless@vger.kernel.org>,
<netdev@vger.kernel.org>, <wil6210@qca.qualcomm.com>,
Stable <stable@vger.kernel.org>
Subject: Re: [PATCH] ath: wil6210: Fix build error
Date: Mon, 22 Jul 2013 12:56:56 +0300 [thread overview]
Message-ID: <458166038.k2AmqmisOp@lx-vladimir> (raw)
In-Reply-To: <1374457543.16248.8.camel@deadeye.wl.decadent.org.uk>
On Monday, July 22, 2013 02:45:43 AM Ben Hutchings wrote:
> > ifeq (, $(findstring -W,$(EXTRA_CFLAGS)))
> > subdir-ccflags-y += -Werror
> > endif
>
> This is a pretty weird thing to do, and you've failed to account for
> -Wextra.
>
> -Werror is generally a bad default in free software, as you have no
> control over which compiler version will be used.
>
Well, you convinced me. I'll send patch removing -Werror.
Thanks, Vladimir
next prev parent reply other threads:[~2013-07-22 9:56 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-07-21 2:46 [PATCH] ath: wil6210: Fix build error Larry Finger
2013-07-21 7:06 ` Vladimir Kondratiev
2013-07-21 15:14 ` Larry Finger
[not found] ` <51EBFABB.8080701-tQ5ms3gMjBLk1uMJSBkQmQ@public.gmane.org>
2013-07-21 15:35 ` Thomas Fjellstrom
2013-07-21 15:52 ` Vladimir Kondratiev
2013-07-21 16:55 ` Kalle Valo
2013-07-22 1:45 ` Ben Hutchings
2013-07-22 9:56 ` Vladimir Kondratiev [this message]
2013-07-22 16:17 ` Luis R. Rodriguez
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=458166038.k2AmqmisOp@lx-vladimir \
--to=qca_vkondrat@qca.qualcomm.com \
--cc=Larry.Finger@lwfinger.net \
--cc=ben@decadent.org.uk \
--cc=linux-wireless@vger.kernel.org \
--cc=linville@tuxdriver.com \
--cc=netdev@vger.kernel.org \
--cc=stable@vger.kernel.org \
--cc=thomas@fjellstrom.ca \
--cc=wil6210@qca.qualcomm.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).